Write-protect git repository over HTTP!

I totally misunderstood the access control mechanism (but it's logical
that it behaves the way it does), and so on git projects with "open"
source access, repos were write-for-all.

This should fix it by enforcing member-or-owner auth for writes.

Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>

.gitignore

@@ -1,19 +1,14 @@
 *~
-.buildpath
-.externalToolBuilders
-.project
-.settings
-.tx/config
-attachments
-indefero-*.zip
+tmp
 src/IDF/conf/idf.php
 src/IDF/conf/idf.test.php
-src/IDF/conf/path.php
+www/test.php
+www/media/upload
 src/IDF/gettexttemplates
+indefero-*.zip
+src/IDF/conf/path.php
+.tx/config
 src/IDF/locale/idf.pot.bak
-test/config.php
 test/test.db
 test/tmp
-tmp
-www/media/upload
-www/test.php
+test/config.php

AUTHORS

@@ -33,7 +33,6 @@ Much appreciated contributors (in alphabetical order):
     Samuel Suther <info@suther.de>                  - German translation
     Sindre R. Myren <sindrero@stud.ntnu.no>
     Stewart Platt <stew@futurete.ch>
-    Stéphane Baron <sbaron>
     Thomas Keller <me@thomaskeller.biz>             - Monotone support
     Vladimir Solomatin <slash>
     William Martin <william.martin@lcpc.fr>

NEWS.mdtext

@@ -7,19 +7,13 @@ or newer to properly run this version of Indefero!
 
 - Indefero's issue tracker can now bi-directionally link issues with variable, configurable
   terms, such as "is related to", "is blocked by" or "is duplicated by" (issue 638)
-- When you search for issues, the results can further be refined by issue state (open or closed)
-  and label (partially implements issue 548)
 - Mercurial source views now show parent revisions (if any) and detailed change information
 - Subversion source views now show detailed change information (issue 622)
 - File download URLs now contain the file name rather than the upload id; old links still work though (issues 559 and 686)
 - Display monotone file and directory attributes in the tree and file view
   (needs a monotone with an interface version of 13.1 or newer)
 - The context area is now kept in view when a page scrolls down several pages
-- Add a summary section to the issue tracker with statistics about open/close issues,
-  tags of open issue, and count of open tickets for each owner.
-- Improved home page with an customizable icon for each project.
-- The download section provide MD5 for each files.
-- Wiki page have now a css for printer output (issue 713)
+- git repositories are now available under /r/projectname/
 
 ## Bugfixes
 
@@ -38,7 +32,6 @@ or newer to properly run this version of Indefero!
   a new project or monotone key, in case an error popped up in the middle (issue 697)
 - Indefero now sends the MD5 checksum as HTTP header when downloading a file from the
   download area. Additionally, a unneeded redirect has been removed. (issue 716)
-- Source links without a specific revision did not work due to a wrong regex (issue 730)
 - Better error detection and reporting in the SyncMonotone plugin
   ATTENTION: This needs Pluf 46b7f251 or newer!
 - Fix the branch links users of the Subversion frontend get when they enter a wrong revision
@@ -47,9 +40,6 @@ or newer to properly run this version of Indefero!
   as we have no information what the author string is actually encoded in
 - Indefero no longer displays an empty parents paragraph in the commit view for root revisions of
   a git repository
-- Indefero now only shows the tags of the closed and not the open issues in the closed issues list
-- Avatar URL generation use correctly the configuration (issue 732)
-- Git cron job doesn't erase anymore manually added keys (issue 247)
 
 ## Documentation
 

doc/httprepos-git.mdtext

@@ -0,0 +1,57 @@
+# Accessing git repositories over HTTP
+
+Starting with indefero 1.2, git repositories are provided via http,
+featuring read-only and read-write access with full integration with
+indefero's access control mechanisms.
+
+## Access git repositories
+
+The repositories are available under http://YOURHOST/BASEPATH/r/PROJECT.
+
+For authentication, use the "extra password" which you can find on your
+profile page.
+
+## Setup
+
+The main thing to setup is git_repositories and git_remote_url in
+src/IDF/conf/idf.php
+
+git_remote_url should match http://YOURHOST/BASEPATH/r/%s, while
+git_repositories points to the local directory supposed to contain the
+repositories like /PATH/TO/REPOSITORIES/%s.git.
+
+## Setup requirements when using PHP over FastCGI
+
+There are a couple of things to setup when using PHP over FastCGI, as compared
+to mod_php or similar integrated mechanisms:
+
+- You will need to setup a RewriteRule for mod_rewrite (in case of Apache,
+  analogous mechanisms might need to be setup for other http daemons), which
+  passes through the Authorization HTTP Header of a request.
+
+  In case of mod_rewrite, the necessary line is
+  one of (depending on server configuration):
+      RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization},L]
+      RewriteRule .* - [E=REMOTE_USER:%{HTTP:Authorization},L]
+
+- The FastCGI adaptor must allow large requests to be handled by PHP,
+  otherwise push might fail.
+
+  For mod_fcgid, this is the FcgidMaxRequestLen option, or MaxRequestLen in
+  older versions. Set this option to some large enough value - there is no
+  issue with RAM use, as another option defines the limit after which the
+  request is backed on disk, which can remain small.
+
+## When migrating from syncgit
+
+HTTP access can be used in parallel to syncgit.
+
+If you want to disable syncgit, just undo the changes detailled
+in doc/syncgit.mdtext:
+- In src/IDF/conf/idf.php keep git_repositories
+- In src/IDF/conf/idf.php adapt git_remote_url to http://host/basepath/r/%s 
+- In src/IDF/conf/idf.php remove idf_plugin_syncgit*
+- Remove the cronjob that called gitcron.php
+- Disable the git daemon (eg. /etc/event.d/local-git-daemon)
+- You can remove the git user and group, if you also adapt the git repositories
+  to be owned by the www user.

src/IDF/Diff.php

@@ -35,7 +35,9 @@ class IDF_Diff
     public function __construct($diff, $path_strip_level = 0)
     {
         $this->path_strip_level = $path_strip_level;
-        $this->lines = IDF_FileUtil::splitIntoLines($diff, true);
+        // this works because in unified diff format even empty lines are
+        // either prefixed with a '+', '-' or ' '
+        $this->lines = preg_split("/\015\012|\015|\012/", $diff, -1, PREG_SPLIT_NO_EMPTY);
     }
 
     public function parse()
@@ -64,12 +66,12 @@ class IDF_Diff
             }
 
             // use new file name by default
-            preg_match("/^\+\+\+ ([^\t\n\r]+)/", $newfileline, $m);
+            preg_match("/^\+\+\+ ([^\t]+)/", $newfileline, $m);
             $current_file = $m[1];
             if ($current_file === '/dev/null') {
                 // except if it's /dev/null, use the old one instead
                 // eg. mtn 0.48 and newer
-                preg_match("/^--- ([^\t\r\n]+)/", $oldfileline, $m);
+                preg_match("/^--- ([^\t]+)/", $oldfileline, $m);
                 $current_file = $m[1];
             }
             if ($this->path_strip_level > 0) {
@@ -100,11 +102,10 @@ class IDF_Diff
 
                 while ($i < $diffsize && ($addlines >= 0 || $dellines >= 0)) {
                     $linetype = $this->lines[$i] != '' ? $this->lines[$i][0] : false;
-                    $content = substr($this->lines[$i], 1);
                     switch ($linetype) {
                         case ' ':
                             $files[$current_file]['chunks'][$current_chunk][] =
-                                array($delstart, $addstart, $content);
+                                array($delstart, $addstart, substr($this->lines[$i++], 1));
                             $dellines--;
                             $addlines--;
                             $delstart++;
@@ -112,26 +113,23 @@ class IDF_Diff
                             break;
                         case '+':
                             $files[$current_file]['chunks'][$current_chunk][] =
-                                array('', $addstart, $content);
+                                array('', $addstart, substr($this->lines[$i++], 1));
                             $addlines--;
                             $addstart++;
                             break;
                         case '-':
                             $files[$current_file]['chunks'][$current_chunk][] =
-                                array($delstart, '', $content);
+                                array($delstart, '', substr($this->lines[$i++], 1));
                             $dellines--;
                             $delstart++;
                             break;
                         case '\\':
-                            // no new line at the end of this file; remove pseudo new line from last line
-                            $cur = count($files[$current_file]['chunks'][$current_chunk]) - 1;
-                            $files[$current_file]['chunks'][$current_chunk][$cur][2] =
-                                rtrim($files[$current_file]['chunks'][$current_chunk][$cur][2], "\r\n");
+                            // ignore newline handling for now, see issue 636
+                            $i++;
                             continue;
                         default:
                             break 2;
                     }
-                    $i++;
                 }
                 $current_chunk++;
             }
@@ -146,82 +144,48 @@ class IDF_Diff
     public function as_html()
     {
         $out = '';
-        foreach ($this->files as $filename => $file) {
+        foreach ($this->files as $filename=>$file) {
             $pretty = '';
             $fileinfo = IDF_FileUtil::getMimeType($filename);
             if (IDF_FileUtil::isSupportedExtension($fileinfo[2])) {
                 $pretty = ' prettyprint';
             }
-
+            $out .= "\n".'<table class="diff" summary="">'."\n";
+            $out .= '<tr id="diff-'.md5($filename).'"><th colspan="3">'.Pluf_esc($filename).'</th></tr>'."\n";
             $cc = 1;
-            $offsets = array();
-            $contents = array();
-
             foreach ($file['chunks'] as $chunk) {
                 foreach ($chunk as $line) {
-                    list($left, $right, $content) = $line;
-                    if ($left and $right) {
-                        $class = 'context';
-                    } elseif ($left) {
-                        $class = 'removed';
+                    if ($line[0] and $line[1]) {
+                        $class = 'diff-c';
+                    } elseif ($line[0]) {
+                        $class = 'diff-r';
                     } else {
-                        $class = 'added';
+                        $class = 'diff-a';
                     }
-
-                    $offsets[] = sprintf('<td>%s</td><td>%s</td>', $left, $right);
-                    $content = IDF_FileUtil::emphasizeControlCharacters(Pluf_esc($content));
-                    $contents[] = sprintf('<td class="%s%s mono">%s</td>', $class, $pretty, $content);
-                }
-                if (count($file['chunks']) > $cc) {
-                    $offsets[]  = '<td class="next">...</td><td class="next">...</td>';
-                    $contents[] = '<td class="next"></td>';
+                    $line_content = self::padLine(Pluf_esc($line[2]));
+                    $out .= sprintf('<tr class="diff-line"><td class="diff-lc">%s</td><td class="diff-lc">%s</td><td class="%s%s mono">%s</td></tr>'."\n", $line[0], $line[1], $class, $pretty, $line_content);
                 }
+                if (count($file['chunks']) > $cc)
+                $out .= '<tr class="diff-next"><td>...</td><td>...</td><td>&nbsp;</td></tr>'."\n";
                 $cc++;
             }
-
-            list($added, $removed) = end($file['chunks_def']);
-
-            $added = $added[0] + $added[1];
-            $leftwidth = 1;
-            if ($added > 0)
-                $leftwidth = ((ceil(log10($added)) + 1) * 8) + 12;
-
-            $removed = $removed[0] + $removed[1];
-            $rightwidth = 1;
-            if ($removed > 0)
-                $rightwidth = ((ceil(log10($removed)) + 1) * 8) + 12;
-
-            $inner_linecounts =
-              '<table class="diff-linecounts">' ."\n".
-                '<colgroup><col width="'.$leftwidth.'" /><col width="'. $rightwidth.'" /></colgroup>' ."\n".
-                '<tr class="line">' .
-                  implode('</tr>'."\n".'<tr class="line">', $offsets).
-                '</tr>' ."\n".
-              '</table>' ."\n";
-
-
-            $inner_contents =
-              '<table class="diff-contents">' ."\n".
-                '<tr class="line">' .
-                  implode('</tr>'."\n".'<tr class="line">', $contents) .
-                '</tr>' ."\n".
-              '</table>' ."\n";
-
-            $out .= '<table class="diff unified">' ."\n".
-                      '<colgroup><col width="'.($leftwidth + $rightwidth + 1).'" /><col width="*" /></colgroup>' ."\n".
-                      '<tr id="diff-'.md5($filename).'">'.
-                        '<th colspan="2">'.Pluf_esc($filename).'</th>'.
-                      '</tr>' ."\n".
-                      '<tr>' .
-                        '<td>'. $inner_linecounts .'</td>'. "\n".
-                        '<td><div class="scroll">'. $inner_contents .'</div></td>'.
-                      '</tr>' ."\n".
-                    '</table>' ."\n";
+            $out .= '</table>';
         }
-
         return Pluf_Template::markSafe($out);
     }
 
+    public static function padLine($line)
+    {
+        $line = str_replace("\t", '    ', $line);
+        $n = strlen($line);
+        for ($i=0;$i<$n;$i++) {
+            if (substr($line, $i, 1) != ' ') {
+                break;
+            }
+        }
+        return str_repeat('&nbsp;', $i).substr($line, $i);
+    }
+
     /**
      * Review patch.
      *
@@ -244,12 +208,12 @@ class IDF_Diff
      */
     public function fileCompare($orig, $chunks, $filename, $context=10)
     {
-        $orig_lines = IDF_FileUtil::splitIntoLines($orig);
+        $orig_lines = preg_split("/\015\012|\015|\012/", $orig);
         $new_chunks = $this->mergeChunks($orig_lines, $chunks, $context);
         return $this->renderCompared($new_chunks, $filename);
     }
 
-    private function mergeChunks($orig_lines, $chunks, $context=10)
+    public function mergeChunks($orig_lines, $chunks, $context=10)
     {
         $spans = array();
         $new_chunks = array();
@@ -346,115 +310,38 @@ class IDF_Diff
         return $nnew_chunks;
     }
 
-    private function renderCompared($chunks, $filename)
+    public function renderCompared($chunks, $filename)
     {
         $fileinfo = IDF_FileUtil::getMimeType($filename);
         $pretty = '';
         if (IDF_FileUtil::isSupportedExtension($fileinfo[2])) {
             $pretty = ' prettyprint';
         }
-
+        $out = '';
         $cc = 1;
-        $left_offsets   = array();
-        $left_contents  = array();
-        $right_offsets  = array();
-        $right_contents = array();
-
-        $max_lineno_left = $max_lineno_right = 0;
-
+        $i = 0;
         foreach ($chunks as $chunk) {
             foreach ($chunk as $line) {
-                $left    = '';
-                $right   = '';
-                $content = IDF_FileUtil::emphasizeControlCharacters(Pluf_esc($line[2]));
-
+                $line1 = '&nbsp;';
+                $line2 = '&nbsp;';
+                $line[2] = (strlen($line[2])) ? self::padLine(Pluf_esc($line[2])) : '&nbsp;';
                 if ($line[0] and $line[1]) {
-                    $class = 'context';
-                    $left = $right = $content;
+                    $class = 'diff-c';
+                    $line1 = $line2 = $line[2];
                 } elseif ($line[0]) {
-                    $class = 'removed';
-                    $left = $content;
+                    $class = 'diff-r';
+                    $line1 = $line[2];
                 } else {
-                    $class = 'added';
-                    $right = $content;
+                    $class = 'diff-a';
+                    $line2 = $line[2];
                 }
-
-                $left_offsets[]   = sprintf('<td>%s</td>', $line[0]);
-                $right_offsets[]  = sprintf('<td>%s</td>', $line[1]);
-                $left_contents[]  = sprintf('<td class="%s%s mono">%s</td>', $class, $pretty, $left);
-                $right_contents[] = sprintf('<td class="%s%s mono">%s</td>', $class, $pretty, $right);
-
-                $max_lineno_left  = max($max_lineno_left, $line[0]);
-                $max_lineno_right = max($max_lineno_right, $line[1]);
-            }
-
-            if (count($chunks) > $cc) {
-                $left_offsets[]   = '<td class="next">...</td>';
-                $right_offsets[]  = '<td class="next">...</td>';
-                $left_contents[]  = '<td></td>';
-                $right_contents[] = '<td></td>';
+                $out .= sprintf('<tr class="diff-line"><td class="diff-lc">%s</td><td class="%s mono%s"><code>%s</code></td><td class="diff-lc">%s</td><td class="%s mono%s"><code>%s</code></td></tr>'."\n", $line[0], $class, $pretty, $line1, $line[1], $class, $pretty, $line2);
             }
+            if (count($chunks) > $cc)
+                $out .= '<tr class="diff-next"><td>...</td><td>&nbsp;</td><td>...</td><td>&nbsp;</td></tr>'."\n";
             $cc++;
+            $i++;
         }
-
-        $leftwidth = 1;
-        if ($max_lineno_left > 0)
-            $leftwidth = ((ceil(log10($max_lineno_left)) + 1) * 8) + 12;
-
-        $rightwidth = 1;
-        if ($max_lineno_right > 0)
-            $rightwidth = ((ceil(log10($max_lineno_right)) + 1) * 8) + 12;
-
-        $inner_linecounts_left =
-          '<table class="diff-linecounts">' ."\n".
-            '<colgroup><col width="'.$leftwidth.'" /></colgroup>' ."\n".
-            '<tr class="line">' .
-              implode('</tr>'."\n".'<tr class="line">', $left_offsets).
-            '</tr>' ."\n".
-          '</table>' ."\n";
-
-        $inner_linecounts_right =
-          '<table class="diff-linecounts">' ."\n".
-            '<colgroup><col width="'.$rightwidth.'" /></colgroup>' ."\n".
-            '<tr class="line">' .
-              implode('</tr>'."\n".'<tr class="line">', $right_offsets).
-            '</tr>' ."\n".
-          '</table>' ."\n";
-
-        $inner_contents_left =
-          '<table class="diff-contents">' ."\n".
-            '<tr class="line">' .
-              implode('</tr>'."\n".'<tr class="line">', $left_contents) .
-            '</tr>' ."\n".
-          '</table>' ."\n";
-
-        $inner_contents_right =
-          '<table class="diff-contents">' ."\n".
-            '<tr class="line">' .
-              implode('</tr>'."\n".'<tr class="line">', $right_contents) .
-            '</tr>' ."\n".
-          '</table>' ."\n";
-
-        $out =
-          '<table class="diff context">' ."\n".
-            '<colgroup>' .
-              '<col width="'.($leftwidth + 1).'" /><col width="*" />' .
-              '<col width="'.($rightwidth + 1).'" /><col width="*" />' .
-            '</colgroup>' ."\n".
-            '<tr id="diff-'.md5($filename).'">'.
-              '<th colspan="4">'.Pluf_esc($filename).'</th>'.
-            '</tr>' ."\n".
-            '<tr>' .
-              '<th colspan="2">'.__('Old').'</th><th colspan="2">'.__('New').'</th>' .
-            '</tr>'.
-            '<tr>' .
-              '<td>'. $inner_linecounts_left .'</td>'. "\n".
-              '<td><div class="scroll">'. $inner_contents_left .'</div></td>'. "\n".
-              '<td>'. $inner_linecounts_right .'</td>'. "\n".
-              '<td><div class="scroll">'. $inner_contents_right .'</div></td>'. "\n".
-            '</tr>' ."\n".
-            '</table>' ."\n";
-
         return Pluf_Template::markSafe($out);
     }
 }

src/IDF/FileUtil.php

@@ -65,9 +65,9 @@ class IDF_FileUtil
         }
         $table = array();
         $i = 1;
-        foreach (self::splitIntoLines($content) as $line) {
+        foreach (preg_split("/\015\012|\015|\012/", $content) as $line) {
             $table[] = '<tr class="c-line"><td class="code-lc" id="L'.$i.'"><a href="#L'.$i.'">'.$i.'</a></td>'
-                .'<td class="code mono'.$pretty.'">'.self::emphasizeControlCharacters(Pluf_esc($line)).'</td></tr>';
+                .'<td class="code mono'.$pretty.'">'.IDF_Diff::padLine(Pluf_esc($line)).'</td></tr>';
             $i++;
         }
         return Pluf_Template::markSafe(implode("\n", $table));
@@ -143,56 +143,6 @@ class IDF_FileUtil
         return $res;
     }
 
-    /**
-     * Splits a string into separate lines while retaining the individual
-     * line ending character for every line.
-     *
-     * OS9 line endings are not supported.
-     *
-     * @param string content
-     * @param boolean if true, skip completely empty lines
-     * @return string
-     */
-    public static function splitIntoLines($content, $skipEmpty = false)
-    {
-        $flags = PREG_SPLIT_OFFSET_CAPTURE;
-        if ($skipEmpty) $flags |= PREG_SPLIT_NO_EMPTY;
-        $splitted = preg_split("/\r\n|\n/", $content, -1, $flags);
-
-        $last_off = -1;
-        $lines = array();
-        while (($split = array_shift($splitted)) !== null) {
-            if ($last_off != -1) {
-                $lines[] .= substr($content, $last_off, $split[1] - $last_off);
-            }
-            $last_off = $split[1];
-        }
-        $lines[] = substr($content, $last_off);
-        return $lines;
-    }
-
-    /**
-     * This translates most of the C0 ASCII control characters into
-     * their visual counterparts in the 0x24## unicode plane
-     * (http://en.wikipedia.org/wiki/C0_and_C1_control_codes).
-     *
-     * We could add DEL (0x7F) to this set, but unfortunately this
-     * is not nicely mapped to 0x247F in the control plane, but 0x2421
-     * and adding an if expression below just for this is a little bit
-     * of a hassle. And of course, the more esoteric ones from C1 are
-     * missing as well...
-     *
-     * @param string $content
-     * @return string
-     */
-    public static function emphasizeControlCharacters($content)
-    {
-        return preg_replace(
-            '/([\x00-\x1F])/ue',
-            '"<span class=\"ctrl-char\" title=\"0x".bin2hex("\\1")."\">&#x24".bin2hex("\\1")."</span>"',
-            $content);
-    }
-
     /**
      * Find if a given mime type is a text file.
      * This uses the output of the self::getMimeType function.

src/IDF/Middleware.php

@@ -44,7 +44,7 @@ class IDF_Middleware
     function process_request(&$request)
     {
         $match = array();
-        if (preg_match('#^/(?:api/p|p)/([\-\w]+)/?#', $request->query, $match)) {
+        if (preg_match('#^/(?:api/p|p|r)/([\-\w]+)/?#', $request->query, $match)) {
             try {
                 $request->project = IDF_Project::getOr404($match[1]);
             } catch (Pluf_HTTP_Error404 $e) {
@@ -88,7 +88,6 @@ class IDF_Middleware
                               'showuser' => 'IDF_Template_ShowUser',
                               'ashowuser' => 'IDF_Template_AssignShowUser',
                               'appversion' => 'IDF_Template_AppVersion',
-                              'upload' => 'IDF_Template_Tag_UploadUrl',
                                             ));
         $params['modifiers'] = array_merge($params['modifiers'],
                                            array(

src/IDF/Project.php

@@ -132,7 +132,7 @@ class IDF_Project extends Pluf_Model
         }
         return $projects[0];
     }
-
+    
     /**
      * Returns the number of open/closed issues.
      *
@@ -167,7 +167,7 @@ GROUP BY uid";
             $key = ($v['id'] === '-1') ? null : $v['id'];
             $ownerStatistics[$key] = (int)$v['nb'];
         }
-
+        
         arsort($ownerStatistics);
 
         return $ownerStatistics;
@@ -178,10 +178,9 @@ GROUP BY uid";
      *
      * @param string Status ('open'), 'closed'
      * @param IDF_Tag Subfilter with a label (null)
-     * @param array Restrict further to a list of ids
      * @return int Count
      */
-    public function getIssueCountByStatus($status='open', $label=null, $ids=array())
+    public function getIssueCountByStatus($status='open', $label=null)
     {
         switch ($status) {
         case 'open':
@@ -204,48 +203,12 @@ GROUP BY uid";
             $sql2 = new Pluf_SQL('idf_tag_id=%s', array($label->id));
             $sql->SAnd($sql2);
         }
-        if (count($ids) > 0) {
-            $sql2 = new Pluf_SQL(sprintf('id IN (%s)', implode(', ', $ids)));
-            $sql->SAnd($sql2);
-        }
         $params = array('filter' => $sql->gen());
         if (!is_null($label)) { $params['view'] = 'join_tags'; }
         $gissue = new IDF_Issue();
         return $gissue->getCount($params);
     }
 
-    /**
-     * Get the tags for a specific list of issues.
-     *
-     * @param string Status ('open') or 'closed'
-     * @param array A list of issue ids
-     * @return array An array of tag objects
-     */
-    public function getTagsByIssues($issue_ids=array())
-    {
-        // make the below query always a valid one
-        if (count($issue_ids) == 0) $issue_ids[] = 0;
-
-        $assocTable = $this->_con->pfx.'idf_issue_idf_tag_assoc';
-        $query = sprintf(
-            'SELECT DISTINCT idf_tag_id FROM %s '.
-            'WHERE idf_issue_id IN (%s) '.
-            'GROUP BY idf_tag_id',
-            $assocTable, implode(',', $issue_ids)
-        );
-
-        $db = Pluf::db();
-        $dbData = $db->select($query);
-        $ids = array(0);
-        foreach ($dbData as $data) {
-            $ids[] = $data['idf_tag_id'];
-        }
-
-        $sql = new Pluf_SQL(sprintf('id IN (%s)', implode(', ', $ids)));
-        $model = new IDF_Tag();
-        return $model->getList(array('filter' => $sql->gen()));
-    }
-
     /**
      * Get the open/closed tag ids as they are often used when doing
      * listings.
@@ -452,11 +415,7 @@ GROUP BY uid";
         foreach ($this->_con->select($sql) as $idc) {
             $tag = new IDF_Tag($idc['id']);
             $tag->nb_use = $idc['nb_use'];
-            // group by class
-            if (!array_key_exists($tag->class, $tags)) {
-                $tags[$tag->class] = array();
-            }
-            $tags[$tag->class][] = $tag;
+            $tags[] = $tag;
         }
         return new Pluf_Template_ContextVars($tags);
     }

src/IDF/Scm.php

@@ -497,5 +497,10 @@ class IDF_Scm
     {
         return 0;
     }
+
+    public function repository($request, $match)
+    {
+        throw new Exception('This repository does not support web based repository access');
+    }
 }
 

src/IDF/Scm/Git.php

@@ -507,27 +507,33 @@ class IDF_Scm_Git extends IDF_Scm
                            "'".$this->mediumtree_fmt."'",
                            escapeshellarg($commit));
         }
+        $out = array();
         $cmd = Pluf::f('idf_exec_cmd_prefix', '').$cmd;
-        $out = self::shell_exec('IDF_Scm_Git::getCommit', $cmd);
-        if (strlen($out) == 0) {
+        self::exec('IDF_Scm_Git::getCommit', $cmd, $out, $ret);
+        if ($ret != 0 or count($out) == 0) {
             return false;
         }
-
-        $diffStart = false;
-        if (preg_match('/^diff (?:--git a|--cc)/m', $out, $m, PREG_OFFSET_CAPTURE)) {
-            $diffStart = $m[0][1];
-        }
-
-        $diff = '';
-        if ($diffStart !== false) {
-            $log = substr($out, 0, $diffStart);
-            $diff = substr($out, $diffStart);
+        if ($getdiff) {
+            $log = array();
+            $change = array();
+            $inchange = false;
+            foreach ($out as $line) {
+                if (!$inchange and 0 === strpos($line, 'diff --git a')) {
+                    $inchange = true;
+                }
+                if ($inchange) {
+                    $change[] = $line;
+                } else {
+                    $log[] = $line;
+                }
+            }
+            $out = self::parseLog($log);
+            $out[0]->diff = implode("\n", $change);
         } else {
-            $log = $out;
+            $out = self::parseLog($out);
+            $out[0]->diff = '';
         }
 
-        $out = self::parseLog(preg_split('/\r\n|\n/', $log));
-        $out[0]->diff = $diff;
         $out[0]->branch = implode(', ', $this->inBranches($out[0]->commit, null));
         return $out[0];
     }
@@ -918,4 +924,113 @@ class IDF_Scm_Git extends IDF_Scm
         }
         return false;
     }
+
+    public function repository($request, $match)
+    {
+        // handle a couple of workarounds for authenticating with FastCGI/PHP
+        if (!empty($_SERVER['HTTP_AUTHORIZATION']))
+            list($_SERVER['PHP_AUTH_USER'], $_SERVER['PHP_AUTH_PW']) = explode(':' , base64_decode(substr($_SERVER['HTTP_AUTHORIZATION'], 6)));
+        elseif (!empty($_SERVER['REDIRECT_HTTP_AUTHORIZATION']))
+            list($_SERVER['PHP_AUTH_USER'], $_SERVER['PHP_AUTH_PW']) = explode(':' , base64_decode(substr($_SERVER['REDIRECT_HTTP_AUTHORIZATION'], 6)));
+        elseif (!empty($_SERVER['REDIRECT_REMOTE_USER']))
+            list($_SERVER['PHP_AUTH_USER'], $_SERVER['PHP_AUTH_PW']) = explode(':' , base64_decode(substr($_SERVER['REDIRECT_REMOTE_USER'], 6)));
+
+        // authenticate: authenticate connection through "extra" password
+        if (!empty($_SERVER['PHP_AUTH_USER'])) {
+            $sql = new Pluf_SQL('login=%s', array($_SERVER['PHP_AUTH_USER']));
+            $users = Pluf::factory('Pluf_User')->getList(array('filter'=>$sql->gen()));
+            if (count($users) == 1 && $users[0]->active) {
+                $user = $users[0];
+                $realkey = substr(sha1($user->password.Pluf::f('secret_key')), 0, 8);
+                if ($_SERVER['PHP_AUTH_PW'] == $realkey) {
+                    $request->user = $user;
+                }
+            }
+        }
+
+        if (IDF_Precondition::accessSource($request) !== true) {
+            $response = new Pluf_HTTP_Response("");
+            $response->status_code = 401;
+            $response->headers['WWW-Authenticate']='Basic realm="git for '.$this->project.'"';
+            return $response;
+        }
+
+        $path = $match[2];
+ 
+        if (!file_exists($this->repo)) {
+            mkdir($this->repo, 0750, true);
+            $out = array();
+            $res = 0;
+            exec(sprintf(Pluf::f('idf_exec_cmd_prefix', '').
+                         Pluf::f('git_path', 'git').' --git-dir=%s init', escapeshellarg($this->repo)),
+                 $out, $res);
+            if ($res != 0) {
+                Pluf_Log::error(array('IDF_Scm_Git::repository', $res, $this->repo));
+                throw new Exception(sprintf('Init repository error, exit status %d.', $res));
+            }
+        }
+
+        // update files before delivering them
+        if (($path == 'objects/info/pack') || ($path == 'info/refs')) {
+            $cmd = sprintf(Pluf::f('idf_exec_cmd_prefix', '').
+                       'GIT_DIR=%s '.Pluf::f('git_path', 'git').' update-server-info -f',
+                       escapeshellarg($this->repo));
+            self::shell_exec('IDF_Scm_Git::repository', $cmd);
+        }
+
+        // smart HTTP discovery
+        if ($path == 'info/refs' && !empty($request->GET['service'])){
+            $service = $request->GET['service'];
+            switch ($service) {
+            case 'git-receive-pack':
+                if (IDF_Precondition::projectMemberOrOwner($request) !== true) {
+                    $response = new Pluf_HTTP_Response("");
+                    $response->status_code = 401;
+                    $response->headers['WWW-Authenticate']='Basic realm="git for '.$this->project.'"';
+                    return $response;
+                }
+            case 'git-upload-pack':
+                $content = sprintf('%04x',strlen($service)+15).
+                         '# service='.$service."\n0000";
+                $content .= self::shell_exec('IDF_Scm_Git::repository',
+                         Pluf::f('idf_exec_cmd_prefix', '').
+                         $service.' --stateless-rpc --advertise-refs '.
+                         $this->repo);
+                $response = new Pluf_HTTP_Response($content,
+                         'application/x-'.$service.'-advertisement');
+                return $response;
+            default:
+                throw new Exception('unknown service: '.$service);
+            }
+        }
+
+        switch($path) {
+        // smart HTTP RPC
+        case 'git-receive-pack':
+                if (IDF_Precondition::projectMemberOrOwner($request) !== true) {
+                    $response = new Pluf_HTTP_Response("");
+                    $response->status_code = 401;
+                    $response->headers['WWW-Authenticate']='Basic realm="git for '.$this->project.'"';
+                    return $response;
+                }
+        case 'git-upload-pack':
+            $response = new Pluf_HTTP_Response_CommandPassThru(
+                   Pluf::f('idf_exec_cmd_prefix', '').$path.
+                   ' --stateless-rpc '.$this->repo,
+                   'application/x-'.$path.'-result');
+            $response->setStdin(fopen('php://input', 'rb'));
+            return $response;
+
+        // regular file
+        default:
+            // make sure we're inside the repo hierarchy (ie. no break-out)
+            if (is_file($this->repo.'/'.$path) &&
+              strpos(realpath($this->repo.'/'.$path), $this->repo.'/') == 0) {
+                return new Pluf_HTTP_Response_File($this->repo.'/'.$path,
+                       'application/octet-stream');
+            } else {
+                return new Pluf_HTTP_Response_NotFound($request);
+            }
+        }
+    }
 }

src/IDF/Scm/Mercurial.php

@@ -408,23 +408,24 @@ class IDF_Scm_Mercurial extends IDF_Scm
                        escapeshellarg($commit),
                        escapeshellarg($this->repo),
                        escapeshellarg($logStyle->get()));
+        $out = array();
         $cmd = Pluf::f('idf_exec_cmd_prefix', '').$cmd;
-        $out = self::shell_exec('IDF_Scm_Mercurial::getCommit', $cmd);
-        if (strlen($out) == 0) {
-            return false;
+        self::exec('IDF_Scm_Mercurial::getCommit', $cmd, $out);
+        $log = array();
+        $change = array();
+        $inchange = false;
+        foreach ($out as $line) {
+            if (!$inchange and 0 === strpos($line, 'diff -r')) {
+                $inchange = true;
+            }
+            if ($inchange) {
+                $change[] = $line;
+            } else {
+                $log[] = $line;
+            }
         }
-
-        $diffStart = strpos($out, 'diff -r');
-        $diff = '';
-        if ($diffStart !== false) {
-            $log = substr($out, 0, $diffStart);
-            $diff = substr($out, $diffStart);
-        } else {
-            $log = $out;
-        }
-
-        $out = self::parseLog(preg_split('/\r\n|\n/', $log));
-        $out[0]->diff = $diff;
+        $out = self::parseLog($log);
+        $out[0]->diff = implode("\n", $change);
         return $out[0];
     }
 

src/IDF/Template/IssueComment.php

@@ -58,7 +58,7 @@ class IDF_Template_IssueComment extends Pluf_Template_Tag
                       implode('|', $nouns);
             $text = IDF_Template_safePregReplace('#((?:'.$prefix.')(?:\s+r?))([0-9a-f]{1,40}((?:\s+and|\s+or|,)\s+r?[0-9a-f]{1,40})*)\b#i',
                                                  array($this, 'callbackCommits'), $text);
-            $text = IDF_Template_safePregReplace('=(src:)([^\s@#,\(\)\\\\]+(?:(\\\\)[\s@#][^\s@#,\(\)\\\\]+){0,})+(?:\@([^\s#,]+))?(?:#(\d+))?=im',
+            $text = IDF_Template_safePregReplace('=(src:)([^\s@#,\(\)\\\\]+(?:(\\\\)[\s@#][^\s@#,\(\)\\\\]+){0,})+(?:\@([^\s#,]+))(?:#(\d+))?=im',
                                                  array($this, 'callbackSource'), $text);
         }
         if ($wordwrap) $text = Pluf_Text::wrapHtml($text, 69, "\n");

src/IDF/Template/Tag/UploadUrl.php

@@ -1,35 +0,0 @@
-<?php
-/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
-# ***** BEGIN LICENSE BLOCK *****
-# This file is part of InDefero, an open source project management application.
-# Copyright (C) 2011 Céondo Ltd and contributors.
-#
-# InDefero is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# InDefero is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-#
-# ***** END LICENSE BLOCK ***** */
-
-class IDF_Template_Tag_UploadUrl extends Pluf_Template_Tag
-{
-    function start($file='')
-    {
-        echo IDF_Template_Tag_UploadUrl::url($file);
-    }
-
-    public static function url($file='')
-    {
-        return Pluf::f('url_upload', Pluf_Template_Tag_MediaUrl::url() . '/upload') . $file;
-    }
-}

src/IDF/Tests/TestDiff.php

@@ -32,24 +32,21 @@ class IDF_Tests_TestDiff extends UnitTestCase
         parent::__construct('Test the diff parser.');
     }
 
-    //
-    // IDF_Diff::mergeChunks() is now private, so this test needs to be rewritten
-    //
-    //public function testBinaryDiff()
-    //{
-    //    $diff_content = file_get_contents(dirname(__FILE__).'/test-diff.diff');
-    //    $orig = file_get_contents(dirname(__FILE__).'/test-diff-view.html');
-    //    $diff = new IDF_Diff($diff_content);
-    //    $diff->parse();
-    //    $def = $diff->files['src/IDF/templates/idf/issues/view.html'];
-    //
-    //    $orig_lines = preg_split("/\015\012|\015|\012/", $orig);
-    //    $merged = $diff->mergeChunks($orig_lines, $def, 10);
-    //    $lchunk = end($merged);
-    //    $lline = end($lchunk);
-    //    $this->assertEqual(array('', '166', '{/if}{/block}'),
-    //                       $lline);
-    //}
+    public function testBinaryDiff()
+    {
+        $diff_content = file_get_contents(dirname(__FILE__).'/test-diff.diff');
+        $orig = file_get_contents(dirname(__FILE__).'/test-diff-view.html');
+        $diff = new IDF_Diff($diff_content);
+        $diff->parse();
+        $def = $diff->files['src/IDF/templates/idf/issues/view.html'];
+
+        $orig_lines = preg_split("/\015\012|\015|\012/", $orig);
+        $merged = $diff->mergeChunks($orig_lines, $def, 10);
+        $lchunk = end($merged);
+        $lline = end($lchunk);
+        $this->assertEqual(array('', '166', '{/if}{/block}'),
+                           $lline);
+    }
 
     public function testDiffWithHeaders()
     {

src/IDF/Views/Download.php

@@ -319,11 +319,13 @@ class IDF_Views_Download
         $pag->no_results_text = __('No downloads were found.');
         $pag->sort_order = array('creation_dtime', 'DESC');
         $pag->setFromRequest($request);
+        $tags = $prj->getTagCloud('downloads');
         return Pluf_Shortcuts_RenderToResponse('idf/downloads/index.html',
                                                array(
                                                      'page_title' => $title,
                                                      'label' => $tag,
                                                      'downloads' => $pag,
+                                                     'tags' => $tags,
                                                      'dlabel' => $dtag,
                                                      ),
                                                $request);

src/IDF/Views/Issue.php

@@ -71,9 +71,7 @@ class IDF_Views_Issue
                         'page_title' => $title,
                         'open' => $open,
                         'closed' => $closed,
-                        'issues' => $pag,
-                        'cloud' => 'issues',
-                );
+                        'issues' => $pag);
         if ($api) return $params;
         return Pluf_Shortcuts_RenderToResponse('idf/issues/index.html',
                                                $params, $request);
@@ -90,7 +88,7 @@ class IDF_Views_Issue
         $ownerStatistics = array();
         $status = array();
         $isTrackerEmpty = false;
-
+        
         $prj = $request->project;
         $opened = $prj->getIssueCountByStatus('open');
         $closed = $prj->getIssueCountByStatus('closed');
@@ -104,28 +102,24 @@ class IDF_Views_Issue
                 $status['Open'] = array($opened, (int)(100 * $opened / ($opened + $closed)));
                 $status['Closed'] = array($closed, (int)(100 * $closed / ($opened + $closed)));
             }
-
+            
             if ($opened > 0) {
                 // Issue owner statistics
                 $owners = $prj->getIssueCountByOwner('open');
                 foreach ($owners as $user => $nb) {
                     if ($user === '') {
                         $key = __('Not assigned');
-                        $login = null;
                     } else {
                         $obj = Pluf::factory('Pluf_User')->getOne(array('filter'=>'id='.$user));
                         $key = $obj->first_name . ' ' . $obj->last_name;
-                        $login = $obj->login;
                     }
-                    $ownerStatistics[$key] = array($nb, (int)(100 * $nb / $opened), $login);
+                    $ownerStatistics[$key] = array($nb, (int)(100 * $nb / $opened));
                 }
 
                 // Issue class tag statistics
-                $grouped_tags = $prj->getTagCloud();
-                foreach ($grouped_tags as $class => $tags) {
-                    foreach ($tags as $tag) {
-                        $tagStatistics[$class][$tag->name] = array($tag->nb_use, $tag->id);
-                    }
+                $tags = $prj->getTagCloud();
+                foreach ($tags as $t) {
+                    $tagStatistics[$t->class][$t->name] = array($t->nb_use, $t->id);
                 }
                 foreach($tagStatistics as $k => $v) {
                     $nbIssueInClass = 0;
@@ -136,15 +130,15 @@ class IDF_Views_Issue
                         $tagStatistics[$k][$kk] = array($vv[0], (int)(100 * $vv[0] / $nbIssueInClass), $vv[1]);
                     }
                 }
-
+                
                 // Sort
                 krsort($tagStatistics);
                 arsort($ownerStatistics);
             }
         }
-
+        
         $title = sprintf(__('Summary of tracked issues in %s.'), (string) $prj);
-
+        
         return Pluf_Shortcuts_RenderToResponse('idf/issues/summary.html',
                                                array('page_title' => $title,
                                                      'trackerEmpty' => $isTrackerEmpty,
@@ -155,7 +149,7 @@ class IDF_Views_Issue
                                                      ),
                                                $request);
     }
-
+    
     /**
      * View the issues watch list of a given user.
      * Limited to a specified project
@@ -319,55 +313,42 @@ class IDF_Views_Issue
      *
      * Only open issues are shown.
      */
-    public $userIssues_precond = array('IDF_Precondition::accessIssues');
-    public function userIssues($request, $match)
+    public $myIssues_precond = array('IDF_Precondition::accessIssues',
+                                     'Pluf_Precondition::loginRequired');
+    public function myIssues($request, $match)
     {
         $prj = $request->project;
-        
-        $sql = new Pluf_SQL('login=%s', array($match[2]));
-        $user = Pluf::factory('Pluf_User')->getOne(array('filter' => $sql->gen()));
-        if ($user === null) {
-            $url = Pluf_HTTP_URL_urlForView('IDF_Views_Issue::index',
-                                            array($prj->shortname));
-            return new Pluf_HTTP_Response_Redirect($url);
-        }
-        
         $otags = $prj->getTagIdsByStatus('open');
         $ctags = $prj->getTagIdsByStatus('closed');
         if (count($otags) == 0) $otags[] = 0;
         if (count($ctags) == 0) $ctags[] = 0;
-        switch ($match[3]) {
+        switch ($match[2]) {
         case 'submit':
-            $titleFormat = __('%s %s Submitted %s Issues');
-            $f_sql = new Pluf_SQL('project=%s AND submitter=%s AND status IN ('.implode(', ', $otags).')', array($prj->id, $user->id));
+            $title = sprintf(__('My Submitted %s Issues'), (string) $prj);
+            $f_sql = new Pluf_SQL('project=%s AND submitter=%s AND status IN ('.implode(', ', $otags).')', array($prj->id, $request->user->id));
             break;
         case 'submitclosed':
-            $titleFormat = __('%s %s Closed Submitted %s Issues');
-            $f_sql = new Pluf_SQL('project=%s AND submitter=%s AND status IN ('.implode(', ', $ctags).')', array($prj->id, $user->id));
+            $title = sprintf(__('My Closed Submitted %s Issues'), (string) $prj);
+            $f_sql = new Pluf_SQL('project=%s AND submitter=%s AND status IN ('.implode(', ', $ctags).')', array($prj->id, $request->user->id));
             break;
         case 'ownerclosed':
-            $titleFormat = __('%s %s Closed Working %s Issues');
-            $f_sql = new Pluf_SQL('project=%s AND owner=%s AND status IN ('.implode(', ', $ctags).')', array($prj->id, $user->id));
+            $title = sprintf(__('My Closed Working %s Issues'), (string) $prj);
+            $f_sql = new Pluf_SQL('project=%s AND owner=%s AND status IN ('.implode(', ', $ctags).')', array($prj->id, $request->user->id));
             break;
         default:
-            $titleFormat = __('%s %s Working %s Issues');
-            $f_sql = new Pluf_SQL('project=%s AND owner=%s AND status IN ('.implode(', ', $otags).')', array($prj->id, $user->id));
+            $title = sprintf(__('My Working %s Issues'), (string) $prj);
+            $f_sql = new Pluf_SQL('project=%s AND owner=%s AND status IN ('.implode(', ', $otags).')', array($prj->id, $request->user->id));
             break;
         }
-        $title = sprintf($titleFormat,
-                         $user->first_name,
-                         $user->last_name,
-                         (string) $prj);
-        
         // Get stats about the issues
-        $sql = new Pluf_SQL('project=%s AND submitter=%s AND status IN ('.implode(', ', $otags).')', array($prj->id, $user->id));
+        $sql = new Pluf_SQL('project=%s AND submitter=%s AND status IN ('.implode(', ', $otags).')', array($prj->id, $request->user->id));
         $nb_submit = Pluf::factory('IDF_Issue')->getCount(array('filter'=>$sql->gen()));
-        $sql = new Pluf_SQL('project=%s AND owner=%s AND status IN ('.implode(', ', $otags).')', array($prj->id, $user->id));
+        $sql = new Pluf_SQL('project=%s AND owner=%s AND status IN ('.implode(', ', $otags).')', array($prj->id, $request->user->id));
         $nb_owner = Pluf::factory('IDF_Issue')->getCount(array('filter'=>$sql->gen()));
         // Closed issues
-        $sql = new Pluf_SQL('project=%s AND submitter=%s AND status IN ('.implode(', ', $ctags).')', array($prj->id, $user->id));
+        $sql = new Pluf_SQL('project=%s AND submitter=%s AND status IN ('.implode(', ', $ctags).')', array($prj->id, $request->user->id));
         $nb_submit_closed = Pluf::factory('IDF_Issue')->getCount(array('filter'=>$sql->gen()));
-        $sql = new Pluf_SQL('project=%s AND owner=%s AND status IN ('.implode(', ', $ctags).')', array($prj->id, $user->id));
+        $sql = new Pluf_SQL('project=%s AND owner=%s AND status IN ('.implode(', ', $ctags).')', array($prj->id, $request->user->id));
         $nb_owner_closed = Pluf::factory('IDF_Issue')->getCount(array('filter'=>$sql->gen()));
 
         // Paginator to paginate the issues
@@ -378,7 +359,7 @@ class IDF_Views_Issue
                                        'current_user' => $request->user);
         $pag->summary = __('This table shows the open issues.');
         $pag->forced_where = $f_sql;
-        $pag->action = array('IDF_Views_Issue::userIssues', array($prj->shortname, $match[2]));
+        $pag->action = array('IDF_Views_Issue::myIssues', array($prj->shortname, $match[2]));
         $pag->sort_order = array('modif_dtime', 'ASC'); // will be reverted
         $pag->sort_reverse_order = array('modif_dtime');
         $pag->sort_link_title = true;
@@ -393,10 +374,9 @@ class IDF_Views_Issue
         $pag->items_per_page = 10;
         $pag->no_results_text = __('No issues were found.');
         $pag->setFromRequest($request);
-        return Pluf_Shortcuts_RenderToResponse('idf/issues/userIssues.html',
+        return Pluf_Shortcuts_RenderToResponse('idf/issues/my-issues.html',
                                                array('project' => $prj,
                                                      'page_title' => $title,
-                                                     'login' => $user->login,
                                                      'nb_submit' => $nb_submit,
                                                      'nb_owner' => $nb_owner,
                                                      'nb_submit_closed' => $nb_submit_closed,
@@ -449,142 +429,45 @@ class IDF_Views_Issue
 
     public $search_precond = array('IDF_Precondition::accessIssues');
     public function search($request, $match)
-    {
-        $query = !isset($request->REQUEST['q']) ? '' : $request->REQUEST['q'];
-        return $this->doSearch($request, $query, 'open');
-    }
-
-    public $searchStatus_precond = array('IDF_Precondition::accessIssues');
-    public function searchStatus($request, $match)
-    {
-        $query  = !isset($request->REQUEST['q']) ? '' : $request->REQUEST['q'];
-        $status = in_array($match[2], array('open', 'closed')) ? $match[2] : 'open';
-        return $this->doSearch($request, $query, $status);
-    }
-
-    public $searchLabel_precond = array('IDF_Precondition::accessIssues');
-    public function searchLabel($request, $match)
-    {
-        $query  = !isset($request->REQUEST['q']) ? '' : $request->REQUEST['q'];
-        $tag_id = intval($match[2]);
-        $status = in_array($match[3], array('open', 'closed')) ? $match[3] : 'open';
-        return $this->doSearch($request, $query, $status, $tag_id);
-    }
-
-    private function doSearch($request, $query, $status, $tag_id=null)
     {
         $prj = $request->project;
-        if (trim($query) == '') {
-            $url =  Pluf_HTTP_URL_urlForView('IDF_Views_Issue::index', array($prj->shortname));
+        if (!isset($request->REQUEST['q']) or trim($request->REQUEST['q']) == '') {
+            $url =  Pluf_HTTP_URL_urlForView('IDF_Views_Issue::index',
+                                             array($prj->shortname));
             return new Pluf_HTTP_Response_Redirect($url);
         }
-
-        $tag = null;
-        if ($tag_id !== null) {
-            $tag = Pluf_Shortcuts_GetObjectOr404('IDF_Tag', $tag_id);
+        $q = $request->REQUEST['q'];
+        $title = sprintf(__('Search Issues - %s'), $q);
+        $issues = new Pluf_Search_ResultSet(IDF_Search::mySearch($q, $prj, 'IDF_Issue'));
+        if (count($issues) > 100) {
+            // no more than 100 results as we do not care
+            $issues->results = array_slice($issues->results, 0, 100);
         }
-
-        $title = sprintf(__('Search issues - %s'), $query);
-        if ($status === 'closed') {
-            $title = sprintf(__('Search closed issues - %s'), $query);
-        }
-
-        // using Plufs ResultSet implementation here is inefficient, because
-        // it makes a SELECT for each item and does not allow for further
-        // filtering neither, so we just return the ids and filter by them
-        // and other things in the next round
-        $results = IDF_Search::mySearch($query, $prj, 'IDF_Issue');
-
-        $issue_ids = array(0);
-        foreach ($results as $result) {
-            $issue_ids[] = $result['model_id'];
-        }
-
-        $otags = $prj->getTagIdsByStatus($status);
-        if (count($otags) == 0) $otags[] = 0;
-        $sql = new Pluf_SQL(
-            'id IN ('.implode(',', $issue_ids).') '.
-            'AND status IN ('.implode(', ', $otags).') '.
-            ($tag_id !== null ? 'AND idf_tag_id='.$tag_id.' ' : '')
-        );
-        $model = new IDF_Issue();
-        $issues = $model->getList(array('filter' => $sql->gen(), 'view' => 'join_tags'));
-
-        // we unfortunately loose the original sort order,
-        // so we manually have to apply it here again
-        $sorted_issues = new ArrayObject();
-        $filtered_issue_ids = array(0);
-        foreach ($issue_ids as $issue_id) {
-            foreach ($issues as $issue) {
-                if ($issue->id != $issue_id)
-                    continue;
-                if (array_key_exists($issue_id, $sorted_issues))
-                    continue;
-                $sorted_issues[$issue_id] = $issue;
-                $filtered_issue_ids[] = $issue_id;
-            }
-        }
-
         $pag = new Pluf_Paginator();
+        $pag->items = $issues;
         $pag->class = 'recent-issues';
-        $pag->items = $sorted_issues;
-        $pag->item_extra_props = array(
-            'project_m' => $prj,
-            'shortname' => $prj->shortname,
-            'current_user' => $request->user
-        );
+        $pag->item_extra_props = array('project_m' => $prj,
+                                       'shortname' => $prj->shortname,
+                                       'current_user' => $request->user);
         $pag->summary = __('This table shows the found issues.');
+        $pag->action = array('IDF_Views_Issue::search', array($prj->shortname), array('q'=> $q));
         $pag->extra_classes = array('a-c', '', 'a-c', '');
-        $pag->configure(array(
-            'id' => __('Id'),
-            array('summary', 'IDF_Views_Issue_SummaryAndLabels', __('Summary')),
-            array('status', 'IDF_Views_Issue_ShowStatus', __('Status')),
-            array('modif_dtime', 'Pluf_Paginator_DateAgo', __('Last Updated')),
-        ));
-        // disable paginating
-        $pag->items_per_page = PHP_INT_MAX;
+        $list_display = array(
+                              'id' => __('Id'),
+                              array('summary', 'IDF_Views_Issue_SummaryAndLabels', __('Summary')),
+                              array('status', 'IDF_Views_Issue_ShowStatus', __('Status')),
+                              array('modif_dtime', 'Pluf_Paginator_DateAgo', __('Last Updated')),
+                              );
+        $pag->configure($list_display);
+        $pag->items_per_page = 100;
         $pag->no_results_text = __('No issues were found.');
         $pag->setFromRequest($request);
-
-        if ($tag_id === null) {
-            $pag->action = array('IDF_Views_Issue::searchStatus',
-                array($prj->shortname, $status),
-                array('q'=> $query),
-            );
-        } else {
-            $pag->action = array('IDF_Views_Issue::searchLabel',
-                array($prj->shortname, $tag_id, $status),
-                array('q'=> $query),
-            );
-        }
-
-        // get stats about the issues
-        $open = $prj->getIssueCountByStatus('open', $tag, $issue_ids);
-        $closed = $prj->getIssueCountByStatus('closed', $tag, $issue_ids);
-
-        // query the available tags for this search result
-        $all_tags = $prj->getTagsByIssues($filtered_issue_ids);
-        $grouped_tags = array();
-        foreach ($all_tags as $atag) {
-            // group by class
-            if (!array_key_exists($atag->class, $grouped_tags)) {
-                $grouped_tags[$atag->class] = array();
-            }
-            $grouped_tags[$atag->class][] = $atag;
-        }
-
-        $params = array(
-            'page_title' => $title,
-            'issues' => $pag,
-            'query' => $query,
-            'status' => $status,
-            'open' => $open,
-            'closed' => $closed,
-            'tag' => $tag,
-            'all_tags' => $grouped_tags,
-        );
-
+        $params = array('page_title' => $title,
+                        'issues' => $pag,
+                        'q' => $q,
+                        );
         return Pluf_Shortcuts_RenderToResponse('idf/issues/search.html', $params, $request);
+
     }
 
     public $view_precond = array('IDF_Precondition::accessIssues');
@@ -732,13 +615,6 @@ class IDF_Views_Issue
     {
         $prj = $request->project;
         $status = $match[2];
-        
-        if (mb_strtolower($status) == 'open') {
-            $url = Pluf_HTTP_URL_urlForView('IDF_Views_Issue::index',
-                                            array($prj->shortname));
-            return new Pluf_HTTP_Response_Redirect($url);            
-        }
-        
         $title = sprintf(__('%s Closed Issues'), (string) $prj);
         // Get stats about the issues
         $open = $prj->getIssueCountByStatus('open');

src/IDF/Views/Source.php

@@ -132,6 +132,12 @@ class IDF_Views_Source
                                                $request);
     }
 
+    public function repository($request, $match)
+    {
+        $scm = IDF_Scm::get($request->project);
+        return $scm->repository($request, $match);
+    }
+
     public $treeBase_precond = array('IDF_Precondition::accessSource',
                                      'IDF_Views_Source_Precondition::scmAvailable',
                                      'IDF_Views_Source_Precondition::revisionValid');

src/IDF/Views/Wiki.php

@@ -152,11 +152,13 @@ class IDF_Views_Wiki
         $pag->items_per_page = 25;
         $pag->no_results_text = __('No documentation pages were found.');
         $pag->setFromRequest($request);
+        $tags = $prj->getTagCloud('wiki');
         return Pluf_Shortcuts_RenderToResponse('idf/wiki/index.html',
                                                array(
                                                      'page_title' => $title,
                                                      'label' => $tag,
                                                      'pages' => $pag,
+                                                     'tags' => $tags,
                                                      'dlabel' => $dtag,
                                                      ),
                                                $request);

src/IDF/conf/urls.php

@@ -117,7 +117,7 @@ $ctl[] = array('regex' => '#^/p/([\-\w]+)/issues/$#',
                'base' => $base,
                'model' => 'IDF_Views_Issue',
                'method' => 'index');
-
+               
 $ctl[] = array('regex' => '#^/p/([\-\w]+)/issues/summary/$#',
                'base' => $base,
                'model' => 'IDF_Views_Issue',
@@ -128,16 +128,6 @@ $ctl[] = array('regex' => '#^/p/([\-\w]+)/issues/search/$#',
                'model' => 'IDF_Views_Issue',
                'method' => 'search');
 
-$ctl[] = array('regex' => '#^/p/([\-\w]+)/issues/search/status/(\w+)/$#',
-               'base' => $base,
-               'model' => 'IDF_Views_Issue',
-               'method' => 'searchStatus');
-
-$ctl[] = array('regex' => '#^/p/([\-\w]+)/issues/search/label/(\d+)/(\w+)/$#',
-               'base' => $base,
-               'model' => 'IDF_Views_Issue',
-               'method' => 'searchLabel');
-
 $ctl[] = array('regex' => '#^/p/([\-\w]+)/issues/(\d+)/$#',
                'base' => $base,
                'model' => 'IDF_Views_Issue',
@@ -163,10 +153,10 @@ $ctl[] = array('regex' => '#^/p/([\-\w]+)/issues/create/$#',
                'model' => 'IDF_Views_Issue',
                'method' => 'create');
 
-$ctl[] = array('regex' => '#^/p/([\-\w]+)/issues/(.*)/(\w+)/$#',
+$ctl[] = array('regex' => '#^/p/([\-\w]+)/issues/my/(\w+)/$#',
                'base' => $base,
                'model' => 'IDF_Views_Issue',
-               'method' => 'userIssues');
+               'method' => 'myIssues');
 
 $ctl[] = array('regex' => '#^/p/([\-\w]+)/issues/attachment/(\d+)/(.*)$#',
                'base' => $base,
@@ -255,6 +245,11 @@ $ctl[] = array('regex' => '#^/p/([\-\w]+)/source/changesrev/$#',
                'model' => 'IDF_Views_Source_Svn',
                'method' => 'changelogRev');
 
+$ctl[] = array('regex' => '#^/r/([\-\w]+)/(.*)$#',
+               'base' => $base,
+               'model' => 'IDF_Views_Source',
+               'method' => 'repository');
+
 // ---------- WIKI -----------------------------------------
 
 $ctl[] = array('regex' => '#^/p/([\-\w]+)/doc/$#',

src/IDF/templates/idf/issues/base.html

@@ -4,10 +4,10 @@
 <div id="sub-tabs">
 <a {if $inSummaryIssues}class="active" {/if}href="{url 'IDF_Views_Issue::summary', array($project.shortname)}">{trans 'Summary'}</a>
 | <a {if $inOpenIssues}class="active" {/if}href="{url 'IDF_Views_Issue::index', array($project.shortname)}">{trans 'Open Issues'}</a>
-{if !$user.isAnonymous()} | <a {if $inCreate}class="active" {/if}href="{url 'IDF_Views_Issue::create', array($project.shortname)}">{trans 'New Issue'}</a> | <a {if $inMyIssues}class="active" {/if}href="{url 'IDF_Views_Issue::userIssues', array($project.shortname, $user.login, 'submit')}">{trans 'My Issues'}</a>
+{if !$user.isAnonymous()} | <a {if $inCreate}class="active" {/if}href="{url 'IDF_Views_Issue::create', array($project.shortname)}">{trans 'New Issue'}</a> | <a {if $inMyIssues}class="active" {/if}href="{url 'IDF_Views_Issue::myIssues', array($project.shortname, 'submit')}">{trans 'My Issues'}</a>
 | <a {if $inWatchList}class="active" {/if}href="{url 'IDF_Views_Issue::watchList', array($project.shortname, 'open')}">{trans 'My watch list'}</a>{/if} |
 <form class="star" action="{url 'IDF_Views_Issue::search', array($project.shortname)}" method="get">
-<input accesskey="4" type="text" value="{$query}" name="q" size="20" />
+<input accesskey="4" type="text" value="{$q}" name="q" size="20" />
 <input type="submit" name="s" value="{trans 'Search'}" />
 </form>
 {if $inIssue} |

src/IDF/templates/idf/issues/by-label.html

@@ -8,15 +8,16 @@
 
 {/block}
 {block context}
+<p><strong>{trans 'Label:'}</strong>
+{aurl 'url', 'IDF_Views_Issue::listLabel', array($project.shortname, $label.id, 'open')}
+<a href="{$url}" class="label"><strong>{$label.class}:</strong>{$label.name}</a></p>
 {aurl 'open_url', 'IDF_Views_Issue::listLabel', array($project.shortname, $label.id, 'open')}
 {aurl 'closed_url', 'IDF_Views_Issue::listLabel', array($project.shortname, $label.id, 'closed')}
 {blocktrans}<p><strong>Open issues:</strong> <a href="{$open_url}">{$open}</a></p>
 <p><strong>Closed issues:</strong> <a href="{$closed_url}">{$closed}</a></p>
-{/blocktrans}
-<p><strong>{trans 'Label:'}</strong>
-{aurl 'url', 'IDF_Views_Issue::listLabel', array($project.shortname, $label.id, 'open')}
-<a href="{$url}" class="label"><strong>{$label.class}:</strong>{$label.name}</a></p>
-{if $completion}
+{/blocktrans}{if $completion}
 <p><strong>{trans 'Completion:'}</strong> {$completion}</p>
 {/if}
+
+
 {/block}

src/IDF/templates/idf/issues/index.html

@@ -13,5 +13,6 @@
 {blocktrans}<p><strong>Open issues:</strong> <a href="{$open_url}">{$open}</a></p>
 <p><strong>Closed issues:</strong> <a href="{$closed_url}">{$closed}</a></p>{/blocktrans}
 {assign $cloud_url = 'IDF_Views_Issue::listLabel'}
+{assign $cloud = 'issues'}
 {include 'idf/tags-cloud.html'}
 {/block}

src/IDF/templates/idf/issues/js-autocomplete.html

@@ -68,9 +68,6 @@
                 return row.to;
             }
         });
-{/literal}
-    {if $issue}
-{literal}
       $("#id_relation_issue" + idx).autocomplete("{/literal}{url 'IDF_Views_Issue::autoCompleteIssueList', array($project.shortname, $issue.id)}{literal}", {
             minChars: 0,
             width: 310,
@@ -86,9 +83,6 @@
                 return row[1];
             }
         });
-{/literal}
-    {/if}
-{literal}
     }
   });
 {/literal} //-->

src/IDF/templates/idf/issues/my-issues.html

@@ -1,5 +1,5 @@
 {extends "idf/issues/base.html"}
-{block docclass}yui-t2{if $user.login == $login}{assign $inMyIssues = true}{/if}{/block}
+{block docclass}yui-t2{assign $inMyIssues = true}{/block}
 {block body}
 {$issues.render}
 {if !$user.isAnonymous()}
@@ -8,10 +8,10 @@
 
 {/block}
 {block context}
-{aurl 'owner_url', 'IDF_Views_Issue::userIssues', array($project.shortname, $login, 'owner')}
-{aurl 'submit_url', 'IDF_Views_Issue::userIssues', array($project.shortname, $login, 'submit')}
-{aurl 'owner_closed_url', 'IDF_Views_Issue::userIssues', array($project.shortname, $login, 'ownerclosed')}
-{aurl 'submit_closed_url', 'IDF_Views_Issue::userIssues', array($project.shortname, $login, 'submitclosed')}
+{aurl 'owner_url', 'IDF_Views_Issue::myIssues', array($project.shortname, 'owner')}
+{aurl 'submit_url', 'IDF_Views_Issue::myIssues', array($project.shortname, 'submit')}
+{aurl 'owner_closed_url', 'IDF_Views_Issue::myIssues', array($project.shortname, 'ownerclosed')}
+{aurl 'submit_closed_url', 'IDF_Views_Issue::myIssues', array($project.shortname, 'submitclosed')}
 <p><strong>{trans 'Submitted issues:'}</strong> <a href="{$submit_url}">{$nb_submit}</a> 
 {if $nb_submit_closed}<br /><span class="helptext">{blocktrans $nb_submit_closed}See the <a href="{$submit_closed_url}">{$nb_submit_closed} closed</a>.{plural}See the <a href="{$submit_closed_url}">{$nb_submit_closed} closed</a>.{/blocktrans}</span>{/if}</p>
 {if $nb_owner > 0}

src/IDF/templates/idf/issues/search.html

@@ -8,25 +8,5 @@
 
 {/block}
 {block context}
-{aurl 'open_url',   'IDF_Views_Issue::searchStatus', array($project.shortname, 'open'),   array('q' => $query)}
-{aurl 'closed_url', 'IDF_Views_Issue::searchStatus', array($project.shortname, 'closed'), array('q' => $query)}
-{if $tag != null}
-{aurl 'open_url',   'IDF_Views_Issue::searchLabel', array($project.shortname, $tag.id, 'open'),   array('q' => $query)}
-{aurl 'closed_url', 'IDF_Views_Issue::searchLabel', array($project.shortname, $tag.id, 'closed'), array('q' => $query)}
-{/if}
-{blocktrans}
-<p><strong>Found open issues:</strong> <a href="{$open_url}">{$open}</a></p>
-<p><strong>Found closed issues:</strong> <a href="{$closed_url}">{$closed}</a></p>{/blocktrans}
-{if $tag !== null}
-{blocktrans}<p><strong>Label:</strong>
-<a href="{$open_url}" class="label"><strong>{$tag.class}:</strong>{$tag.name}</a></p>{/blocktrans}
-{else}
-{* yes, this is duplicated from tags-cloud.html, but the code there cannot be easily overridden *}
-<div id="tagscloud" class="smaller"><dl>{foreach $all_tags as $class => $labels}
-<dt class="label">{$class}</dt>
-{foreach $labels as $idx => $label}
-{aurl 'url', 'IDF_Views_Issue::searchLabel', array($project.shortname, $label.id, $status), array('q'=> $query)}
-<dd><a href="{$url}" class="label">{$label.name}{if $idx != count($labels) - 1},{/if}</a></dd>
-{/foreach}{/foreach}</dl></p>
-{/if}
+<p><strong>{trans 'Found issues:'}</strong> {$issues.nb_items}</p>
 {/block}

src/IDF/templates/idf/issues/summary.html

@@ -71,12 +71,7 @@
     <tbody>
     {foreach $ownerStatistics as $key => $value}
         <tr>
-        <td class="name">
-        {if !empty($value[2])}
-        {aurl 'url', 'IDF_Views_Issue::userIssues', array($project.shortname, $value[2], 'owner')}
-        <a href="{$url}">{$key}</a>
-        {else}{$key}{/if}
-        </td>
+        <td class="name">{$key}</td>
         <td class="count">{$value[0]}</td>
         <td class="graph">
             <table class='graph'>

src/IDF/templates/idf/issues/view.html

@@ -17,7 +17,7 @@
 {assign $submitter_data = $c.get_submitter_data()}
 <div class="issue-comment{if $i == 0} issue-comment-first{/if}{if $i == ($nc-1)} issue-comment-last{/if}" id="ic{$c.id}">
 {if $submitter_data.avatar != ''}
-<img style="float:right; position: relative; max-height: 60px; max-width: 60px;" src="{upload}/avatars/{$submitter_data.avatar}" alt=" " />
+<img style="float:right; position: relative; max-height: 60px; max-width: 60px;" src="{media}/upload/avatars/{$submitter_data.avatar}" alt=" " />
 {else}
 <img style="float:right; position: relative; max-height: 60px; max-width: 60px;" src="http://www.gravatar.com/avatar/{$submitter.email|md5}.jpg?s=60&amp;d={media}/idf/img/spacer.gif" alt=" " />
 {/if}

src/IDF/templates/idf/js-hotkeys.html

@@ -10,8 +10,8 @@
 {if $hasWikiAccess}{hotkey 'Shift+o', 'IDF_Views_Wiki::index', array($project.shortname)}{/if}
 {if $hasSourceAccess}{hotkey 'Shift+s', 'IDF_Views_Source::treeBase', array($project.shortname, $project.getScmRoot())}{/if}
 {if $hasIssuesAccess and !$user.isAnonymous()}
-{hotkey 'Shift+m', 'IDF_Views_Issue::userIssues', array($project.shortname, $user.login, 'submit')}
-{hotkey 'Shift+w', 'IDF_Views_Issue::userIssues', array($project.shortname, $user.login, 'owner')}
+{hotkey 'Shift+m', 'IDF_Views_Issue::myIssues', array($project.shortname, 'submit')}
+{hotkey 'Shift+w', 'IDF_Views_Issue::myIssues', array($project.shortname, 'owner')}
 {/if}{/if} //-->
 </script>
 

src/IDF/templates/idf/review/base-full.html

@@ -4,7 +4,7 @@
 <div id="sub-tabs">
 <a {if $inOpenReviews}class="active" {/if}href="{url 'IDF_Views_Review::index', array($project.shortname)}">{trans 'Open Reviews'}</a> {*
 
-{if !$user.isAnonymous()} | <a {if $inCreate}class="active" {/if}href="{url 'IDF_Views_Issue::create', array($project.shortname)}">{trans 'New Issue'}</a> | <a {if $inMyIssues}class="active" {/if}href="{url 'IDF_Views_Issue::userIssues', array($project.shortname, $user.login, 'submit')}">{trans 'My Issues'}</a>{/if} |
+{if !$user.isAnonymous()} | <a {if $inCreate}class="active" {/if}href="{url 'IDF_Views_Issue::create', array($project.shortname)}">{trans 'New Issue'}</a> | <a {if $inMyIssues}class="active" {/if}href="{url 'IDF_Views_Issue::myIssues', array($project.shortname, 'submit')}">{trans 'My Issues'}</a>{/if} |
 <form class="star" action="{url 'IDF_Views_Issue::search', array($project.shortname)}" method="get">
 <input accesskey="4" type="text" value="{$q}" name="q" size="20" />
 <input type="submit" name="s" value="{trans 'Search'}" />

src/IDF/templates/idf/review/index.html

@@ -5,4 +5,17 @@
 {if !$user.isAnonymous()}
 {aurl 'url', 'IDF_Views_Review::create', array($project.shortname)}
 <p><a href="{$url}"><img style="vertical-align: text-bottom;" src="{media '/idf/img/add.png'}" alt="+" align="bottom" /></a> <a href="{$url}">{trans 'Start Code Review'}</a></p>{/if}
+
 {/block}
+{block context}
+{*
+{aurl 'open_url', 'IDF_Views_Issue::index', array($project.shortname)}
+{aurl 'closed_url', 'IDF_Views_Issue::listStatus', array($project.shortname, 'closed')}
+{blocktrans}<p><strong>Open issues:</strong> <a href="{$open_url}">{$open}</a></p>
+<p><strong>Closed issues:</strong> <a href="{$closed_url}">{$closed}</a></p>{/blocktrans}
+{assign $class = ''}{assign $i = 0}
+<p class="smaller">{foreach $project.getTagCloud($cloud) as $label}
+{aurl 'url', 'IDF_Views_Issue::listLabel', array($project.shortname, $label.id, 'open')}
+{if $class != $label.class}{if $i != 0}<br />{/if}<strong class="label">{$label.class}:</strong> {/if}
+<a href="{$url}" class="label">{$label.name}</a>,{assign $class = $label.class}{assign $i = $i + 1}{/foreach}</p>
+*}{/block}

src/IDF/templates/idf/review/view.html

@@ -10,26 +10,8 @@
 {/if}
 </div>
 {/if}
-{if !$user.isAnonymous()}
-<div class="issue-submit-info" style="width: 50%; float: right; position: relative;">
-<p><strong>{trans 'How to Participate in a Code Review'}</strong></p>
-
-<p>{blocktrans}Code review is a process in which
-after or before changes are commited into the code repository,
-different people discuss the code changes. The goal is
-to <strong>improve the quality of the code and the
-contributions</strong>, as such, you must be pragmatic when writing
-your review. Correctly mention the line numbers (in the old or in the
-new file) and try to keep a good balance between seriousness and fun.
-{/blocktrans}</p>
-<p>{blocktrans}
-<strong>Proposing code for review is intimidating</strong>, you know
-you will receive critics, so please, as a reviewer, <strong>keep this
-process fun</strong>, use it to help your contributor learn your
-coding standards and the structure of the code and <strong>make them want
-to propose more contributions</strong>.
-{/blocktrans}</p></div>
-{/if}
+<table class="disp" summary="">
+<tr><td>
 <table class="commit" summary="">
 <tr>
 <th><strong>{trans 'Created:'}</strong></th><td>{$patch.creation_dtime|date:"%Y-%m-%d %H:%M:%S"} ({$patch.creation_dtime|dateago})</td>
@@ -63,12 +45,39 @@ to propose more contributions</strong>.
 <th>&nbsp;</th><td><a href="{$url}"><img style="vertical-align: text-bottom;" src="{media '/idf/img/package-grey.png'}" alt="{trans 'Archive'}" align="bottom" /></a> <a href="{$url}" class="soft">{trans 'Download the corresponding diff file'}</a></td>
 </tr>
 </table>
+</td><td>
+{if !$user.isAnonymous()}
+<div class="issue-submit-info" style="width: 90%; float: right; position: relative;">
+<p><strong>{trans 'How to Participate in a Code Review'}</strong></p>
+
+<p>{blocktrans}Code review is a process in which
+after or before changes are commited into the code repository,
+different people discuss the code changes. The goal is
+to <strong>improve the quality of the code and the
+contributions</strong>, as such, you must be pragmatic when writing
+your review. Correctly mention the line numbers (in the old or in the
+new file) and try to keep a good balance between seriousness and fun.
+{/blocktrans}</p>
+<p>{blocktrans}
+<strong>Proposing code for review is intimidating</strong>, you know
+you will receive critics, so please, as a reviewer, <strong>keep this
+process fun</strong>, use it to help your contributor learn your
+coding standards and the structure of the code and <strong>make them want
+to propose more contributions</strong>.
+{/blocktrans}</p></div>
+{/if}
+</td></tr>
+</table>
 
 <form method="post" action=".">
 {foreach $files as $file=>$def}
-
-    {$def[0]}
-
+<table class="diff" summary=" ">
+<tbody>
+<tr id="diff-{$file|md5}"><th colspan="4">{$file}</th></tr>
+<tr><th colspan="2">{trans 'Old'}</th><th colspan="2">{trans 'New'}</th></tr>
+{$def[0]}
+</tbody>
+</table>
 {assign $fcomments = $def[2]}
 {assign $nc = $fcomments.count()}
 {assign $i = 1}
@@ -100,7 +109,7 @@ to propose more contributions</strong>.
 {foreach $comments as $c}{ashowuser 'submitter', $c.get_submitter(), $request}{assign $submitter = $c.get_submitter()}{assign $submitter_data = $c.get_submitter_data()}
 <div class="issue-comment{if $i == 1} issue-comment-first{/if}{if $i == ($nc)} issue-comment-last{/if}" id="ic{$c.id}">
 {if $submitter_data.avatar != ''}
-    <img style="float:right; position: relative; max-height: 60px; max-width: 60px;" src="{upload}/avatars/{$submitter_data.avatar}" alt=" " />
+    <img style="float:right; position: relative; max-height: 60px; max-width: 60px;" src="{media}/upload/avatars/{$submitter_data.avatar}" alt=" " />
 {else}
     <img style="float:right; position: relative;" src="http://www.gravatar.com/avatar/{$submitter.email|md5}.jpg?s=60&amp;d={media}/idf/img/spacer.gif" alt=" " />
 {/if}

src/IDF/templates/idf/tags-cloud.html

@@ -1,6 +1,8 @@
-<div id="tagscloud" class="smaller"><dl>{foreach $project.getTagCloud($cloud) as $class => $labels}
-<dt class="label">{$class}</dt>
-{foreach $labels as $idx => $label}
+{assign $class = ''}{assign $i = 0}
+<div id="tagscloud" class="smaller"><dl>{foreach $project.getTagCloud($cloud) as $label}
 {aurl 'url', $cloud_url, array($project.shortname, $label.id, 'open')}
-<dd><a href="{$url}" class="label">{$label.name}{if $idx != count($labels) - 1},{/if}</a></dd>
-{/foreach}{/foreach}</dl></p>
+{if $class != $label.class}<dt class="label">{$label.class}</dt>{assign $i = 0}{/if}
+<dd><a href="{$url}" class="label">{$label.name},</a></dd>
+{assign $class = $label.class}
+{assign $i = $i + 1}
+{/foreach}</dl></p>

src/IDF/templates/idf/user/public.html

@@ -3,7 +3,7 @@
 <table class="form" summary="">
 <tr>
 <th style="text-align: right">{if $user_data.avatar != ''}
-    <img style="max-height: 60px; max-width: 60px;" src="{upload}/avatars/{$user_data.avatar}" alt=" " />
+    <img style="max-height: 60px; max-width: 60px;" src="{media}/upload/avatars/{$user_data.avatar}" alt=" " />
 {else}
     <img src="http://www.gravatar.com/avatar/{$member.email|md5}.jpg?s=60&amp;d={media}/idf/img/spacer.gif" alt=" " />
 {/if}

src/IDF/templates/idf/wiki/view.html

@@ -1,10 +1,5 @@
 {extends "idf/wiki/base.html"}
-
-{block extraheader}
-{if $oldrev}<meta name="ROBOTS" content="NOINDEX" />{/if}
-<link rel="stylesheet" type="text/css" media="print" href="{media '/idf/css/print-wiki.css'}" />
-{/block}
-
+{block extraheader}{if $oldrev}<meta name="ROBOTS" content="NOINDEX" />{/if}{/block}
 {block docclass}yui-t3{assign $inView=true}{/block}
 
 {block body}

test/IDF/DiffTest.php

@@ -38,9 +38,11 @@ class IDF_DiffTest extends PHPUnit_Framework_TestCase
             }
 
             $expectedfile = str_replace('.diff', '.expected', $difffile);
+            $expectedcontent = @file_get_contents($expectedfile);
+
             $diffcontent = file_get_contents($difffile);
             $diff = new IDF_Diff($diffcontent, $diffprefix);
-            $this->assertEquals(require_once($expectedfile),
+            $this->assertEquals(unserialize($expectedcontent),
                                 $diff->parse(),
                                 'parsed diff '.$difffile.' does not match');
         }

test/bootstrap.php

@@ -21,7 +21,7 @@ if (file_exists($testconfig['db_database'])) {
 }
 
 echo ">>> creating empty test database...\n";
-passthru('php ' . escapeshellarg(PLUF_PATH.'/migrate.php') . ' --conf=' . escapeshellarg(TESTDIR.'/config.php').' -a -i');
+passthru('php ' . PLUF_PATH . '/migrate.php --conf=' . TESTDIR . '/config.php -a -i');
 
 echo ">>> setting up web application...\n";
 require 'Pluf.php';

test/data/IDF_DiffTest/test-02-svn-new-files-with-properties.diff

@@ -15,10 +15,375 @@ Index: LinuxBIOSv1/src/include/cpu/i786/cpufixup.h
 +
 +
 
-Eigenschafts<EFBFBD>nderungen: LinuxBIOSv1\src\include\cpu\i786\cpufixup.h
+Eigenschafts<EFBFBD>nderungen: LinuxBIOSv1\src\include\cpu\i786\cpufixup.h
 ___________________________________________________________________
-Hinzugef<EFBFBD>gt: svn:keywords
+Hinzugef<EFBFBD>gt: svn:keywords
    + Author Date Id Revision
-Hinzugef<EFBFBD>gt: svn:eol-style
+Hinzugef<EFBFBD>gt: svn:eol-style
+   + native
+
+Index: LinuxBIOSv1/src/mainboard/tyan/guiness/cmos.layout
+===================================================================
+--- LinuxBIOSv1/src/mainboard/tyan/guiness/cmos.layout	(Revision 0)
++++ LinuxBIOSv1/src/mainboard/tyan/guiness/cmos.layout	(Revision 665)
+@@ -0,0 +1,63 @@
++entries
++
++#start-bit length  config config-ID    name
++#0            8       r       0        seconds
++#8            8       r       0        alarm_seconds
++#16           8       r       0        minutes
++#24           8       r       0        alarm_minutes
++#32           8       r       0        hours
++#40           8       r       0        alarm_hours
++#48           8       r       0        day_of_week
++#56           8       r       0        day_of_month
++#64           8       r       0        month
++#72           8       r       0        year
++#80           4       r       0        rate_select
++#84           3       r       0        REF_Clock
++#87           1       r       0        UIP
++#88           1       r       0        auto_switch_DST
++#89           1       r       0        24_hour_mode
++#90           1       r       0        binary_values_enable
++#91           1       r       0        square-wave_out_enable
++#92           1       r       0        update_finished_enable
++#93           1       r       0        alarm_interrupt_enable
++#94           1       r       0        periodic_interrupt_enable
++#95           1       r       0        disable_clock_updates
++#96         288       r       0        temporary_filler
++0          384       r       0        reserved_memory
++384          1       e       4        boot_option
++385          1       e       4        last_boot
++386          3       e       5        baud_rate
++392          4       e       6        debug_level
++396          1       e       1        power_on_after_fail
++#401          1       e       1        ECC_memory
++#402          1       e       2        hda_disk
++#403          1       e       2        hdb_disk
++#404          1       e       2        hdc_disk
++#405          1       e       2        hdd_disk
++#406          2       e       7        boot_device
++
++enumerations
++
++#ID value   text
++1     0     Disable
++1     1     Enable
++#2     0     No
++#2     1     Yes
++4     0     Fallback
++4     1     Normal
++5     0     115200
++5     1     57600
++5     2     38400
++5     3     19200
++5     4     9600
++5     5     4800
++5     6     2400
++5     7     1200
++6     6     Notice
++6     7     Info
++6     8     Debug
++6     9     Spew
++#7     0     Network
++#7     1     HDD
++#7     2     Floppy
++#7     3     ROM
+
+Eigenschafts<EFBFBD>nderungen: LinuxBIOSv1\src\mainboard\tyan\guiness\cmos.layout
+___________________________________________________________________
+Hinzugef<EFBFBD>gt: svn:keywords
+   + Author Date Id Revision
+Hinzugef<EFBFBD>gt: svn:eol-style
+   + native
+
+Index: LinuxBIOSv1/src/config/linuxbios_c.ld
+===================================================================
+--- LinuxBIOSv1/src/config/linuxbios_c.ld	(Revision 0)
++++ LinuxBIOSv1/src/config/linuxbios_c.ld	(Revision 665)
+@@ -0,0 +1,105 @@
++/*
++ *	Memory map:
++ *
++ *	_RAMBASE		
++ *				: data segment
++ *				: bss segment
++ *				: heap
++ *				: stack
++ */
++/*
++ * Bootstrap code for the STPC Consumer
++ * Copyright (c) 1999 by Net Insight AB. All Rights Reserved.
++ *
++ * $Id$
++ *
++ */
++
++/*
++ *	Written by Johan Rydberg, based on work by Daniel Kahlin.
++ *      Rewritten by Eric Biederman
++ */
++/*
++ *	We use ELF as output format. So that we can
++ *	debug the code in some form. 
++ */
++INCLUDE ldoptions
++
++ENTRY(_start)
++
++SECTIONS
++{
++	. = _RAMBASE;
++	/*
++	 * First we place the code and read only data (typically const declared).
++	 * This get placed in rom.
++	 */
++	.text : {
++		_text = .;
++		*(.text);
++		*(.text.*);
++		. = ALIGN(16);
++		_etext = .;
++	}
++	.rodata : {
++		_rodata = .;
++		. = ALIGN(4);
++		streams = . ;
++		*(.rodata.streams)
++		estreams = .;
++		. = ALIGN(4);
++		pci_drivers = . ;
++		*(.rodata.pci_drivers)
++		epci_drivers = . ;
++		*(.rodata)
++		*(.rodata.*)
++		_erodata = .;
++	}	
++	/*
++	 * After the code we place initialized data (typically initialized
++	 * global variables). This gets copied into ram by startup code.
++	 * __data_start and __data_end shows where in ram this should be placed,
++	 * whereas __data_loadstart and __data_loadend shows where in rom to
++	 * copy from.
++	 */
++	.data : {
++		_data = .;
++		*(.data)
++		_edata = .;
++	}
++	/*
++	 * bss does not contain data, it is just a space that should be zero
++	 * initialized on startup. (typically uninitialized global variables)
++	 * crt0.S fills between _bss and _ebss with zeroes.
++	 */
++	_bss = .;
++	.bss . : {
++		*(.bss)
++		*(.sbss)
++		*(COMMON)
++	}
++	_ebss = .;
++	_end = .;
++	_stack = .;
++	.stack . : {
++		/* Reserve a stack for each possible cpu, +1 extra */
++		. = ((MAX_CPUS * STACK_SIZE) + STACK_SIZE) ; 
++	}
++	_estack = .;
++	_heap = .;
++	.heap . : {
++		/* Reserve 256K for the heap */
++		. = HEAP_SIZE ;
++		. = ALIGN(4);
++	}
++	_eheap = .;
++	/* The ram segment
++ 	 * This is all address of the memory resident copy of linuxBIOS.
++	 */
++	_ram_seg = _text;
++	_eram_seg = _eheap;
++	/DISCARD/ : {
++		*(.comment)
++		*(.note)
++	}
++}
+
+Eigenschafts<EFBFBD>nderungen: LinuxBIOSv1\src\config\linuxbios_c.ld
+___________________________________________________________________
+Hinzugef<EFBFBD>gt: svn:keywords
+   + Author Date Id Revision
+Hinzugef<EFBFBD>gt: svn:eol-style
+   + native
+
+Index: LinuxBIOSv1/src/arch/i386/include/arch/rom_segs.h
+===================================================================
+--- LinuxBIOSv1/src/arch/i386/include/arch/rom_segs.h	(Revision 0)
++++ LinuxBIOSv1/src/arch/i386/include/arch/rom_segs.h	(Revision 665)
+@@ -0,0 +1,10 @@
++#ifndef ROM_SEGS_H
++#define ROM_SEGS_H
++
++#define ROM_CODE_SEG 0x08
++#define ROM_DATA_SEG 0x10
++
++#define CACHE_RAM_CODE_SEG 0x18
++#define CACHE_RAM_DATA_SEG 0x20
++
++#endif /* ROM_SEGS_H */
+
+Eigenschafts<EFBFBD>nderungen: LinuxBIOSv1\src\arch\i386\include\arch\rom_segs.h
+___________________________________________________________________
+Hinzugef<EFBFBD>gt: svn:keywords
+   + Author Date Id Revision
+Hinzugef<EFBFBD>gt: svn:eol-style
+   + native
+
+Index: LinuxBIOSv1/src/arch/i386/lib/c_start.S
+===================================================================
+--- LinuxBIOSv1/src/arch/i386/lib/c_start.S	(Revision 0)
++++ LinuxBIOSv1/src/arch/i386/lib/c_start.S	(Revision 665)
+@@ -0,0 +1,135 @@
++#include <arch/asm.h>
++#include <arch/intel.h>
++#ifdef SMP
++#include <cpu/p6/apic.h>
++#endif
++	.section ".text"
++	.code32
++	.globl _start
++_start:
++	cli
++	lgdt	%cs:gdtaddr
++	ljmp	$0x10, $1f
++1:	movl	$0x18, %ax
++	movl	%eax, %ds
++	movl	%eax, %es
++	movl	%eax, %ss
++	movl	%eax, %fs
++	movl	%eax, %gs
++
++	intel_chip_post_macro(0x13)		/* post 12 */
++
++	/** clear stack */
++	leal	EXT(_stack), %edi
++	movl	$EXT(_estack), %ecx
++	subl	%edi, %ecx
++	xorl	%eax, %eax
++	rep
++	stosb
++
++	/** clear bss */
++	leal	EXT(_bss), %edi
++	movl	$EXT(_ebss), %ecx
++	subl	%edi, %ecx
++	jz	.Lnobss
++	xorl	%eax, %eax
++	rep
++	stosb
++.Lnobss:
++
++	/* set new stack */
++	movl	$_estack, %esp
++#ifdef SMP
++	/* Get the cpu id */
++	movl	$APIC_DEFAULT_BASE, %edi
++	movl	APIC_ID(%edi), %eax
++	shrl	$24, %eax
++
++	/* Get the cpu index (MAX_CPUS on error) */
++	movl	$-4, %ebx
++1:	addl	$4, %ebx
++	cmpl	$(MAX_CPUS << 2), %ebx
++	je	2
++	cmpl	%eax, EXT(initial_apicid)(%ebx)
++	jne	1b
++2:	shrl	$2, %ebx
++
++	/* Now compute the appropriate stack */
++	movl	%ebx, %eax
++	movl	$STACK_SIZE, %ebx
++	mull	%ebx
++	subl	%eax, %esp
++
++	/* push the boot_complete flag */
++	pushl	%ebp
++
++	/* Save the stack location */
++	movl	%esp, %ebp
++
++	/*
++	 *	Now we are finished. Memory is up, data is copied and
++	 *	bss is cleared.   Now we call the main routine and
++	 *	let it do the rest.
++	 */ 
++	intel_chip_post_macro(0xfe)	/* post fe */
++
++	/* Resort the stack location */
++	movl	%ebp, %esp
++	
++	/* The boot_complete flag has already been pushed */
++	call	EXT(hardwaremain)
++	/*NOTREACHED*/
++.Lhlt:
++	intel_chip_post_macro(0xee)	/* post fe */
++	hlt
++	jmp	.Lhlt
++#endif
++
++
++	.globl gdt, gdt_end, gdt_limit
++
++gdt_limit = gdt_end - gdt - 1 /* compute the table limit */
++gdtaddr:
++	.word	gdt_limit
++	.long	gdt                /* we know the offset */
++
++gdt:
++// selgdt 0
++	.word	0x0000, 0x0000		/* dummy */
++	.byte	0x00, 0x00, 0x00, 0x00
++
++// selgdt 8
++	.word	0x0000, 0x0000		/* dummy */
++	.byte	0x00, 0x00, 0x00, 0x00
++
++// selgdt 0x10 
++/* flat code segment */
++	.word	0xffff, 0x0000		
++	.byte	0x00, 0x9b, 0xcf, 0x00	
++	
++//selgdt 0x18
++/* flat data segment */
++	.word	0xffff, 0x0000		
++	.byte	0x00, 0x93, 0xcf, 0x00	
++
++//selgdt 0x20
++	.word	0x0000, 0x0000		/* dummy */
++	.byte	0x00, 0x00, 0x00, 0x00
++
++#if defined(CONFIG_VGABIOS) && (CONFIG_VGABIOS == 1)
++	// from monty:
++	/* 0x00009a00,0000ffffULL,   20h: 16-bit 64k code at 0x00000000 */
++        /* 0x00009200,0000ffffULL    28h: 16-bit 64k data at 0x00000000 */
++// selgdt 0x28
++/*16-bit 64k code at 0x00000000 */
++	.word 0xffff, 0x0000
++	.byte 0, 0x9a, 0, 0
++
++// selgdt 0x30
++/*16-bit 64k data at 0x00000000 */
++	.word 0xffff, 0x0000
++	.byte 0, 0x92, 0, 0
++#endif // defined(CONFIG_VGABIOS) && (CONFIG_VGABIOS == 1)
++gdt_end:
++
++.code32
+
+Eigenschafts<EFBFBD>nderungen: LinuxBIOSv1\src\arch\i386\lib\c_start.S
+___________________________________________________________________
+Hinzugef<EFBFBD>gt: svn:keywords
+   + Author Date Id Revision
+Hinzugef<EFBFBD>gt: svn:eol-style
    + native
 

test/data/IDF_DiffTest/test-03-mtn-new-file-single-line.expected

@@ -1,33 +1 @@
-<?php return array (
-  'a' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '',
-          1 => '1',
-          2 => "abc\r\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '0',
-          1 => '0',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"a";a:2:{s:6:"chunks";a:1:{i:0;a:1:{i:0;a:3:{i:0;s:0:"";i:1;s:1:"1";i:2;s:3:"abc";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"0";i:1;s:1:"0";}i:1;a:2:{i:0;s:1:"1";i:1;i:1;}}}}}

test/data/IDF_DiffTest/test-04-mtn-new-file-multi-lines.expected

@@ -1,39 +1 @@
-<?php return array (
-  'a' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '',
-          1 => '1',
-          2 => "abc\r\n",
-        ),
-        1 => 
-        array (
-          0 => '',
-          1 => 2,
-          2 => "abc\r\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '0',
-          1 => '0',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => '2',
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"a";a:2:{s:6:"chunks";a:1:{i:0;a:2:{i:0;a:3:{i:0;s:0:"";i:1;s:1:"1";i:2;s:3:"abc";}i:1;a:3:{i:0;s:0:"";i:1;i:2;i:2;s:3:"abc";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"0";i:1;s:1:"0";}i:1;a:2:{i:0;s:1:"1";i:1;s:1:"2";}}}}}

test/data/IDF_DiffTest/test-05-mtn-change-to-single-line.expected

@@ -1,39 +1 @@
-<?php return array (
-  'a' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '1',
-          2 => "abc\r\n",
-        ),
-        1 => 
-        array (
-          0 => 2,
-          1 => '',
-          2 => "abc\r\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '2',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"a";a:2:{s:6:"chunks";a:1:{i:0;a:2:{i:0;a:3:{i:0;s:1:"1";i:1;s:1:"1";i:2;s:3:"abc";}i:1;a:3:{i:0;i:2;i:1;s:0:"";i:2;s:3:"abc";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"1";i:1;s:1:"2";}i:1;a:2:{i:0;s:1:"1";i:1;i:1;}}}}}

test/data/IDF_DiffTest/test-06-mtn-single-line.expected

@@ -1,39 +1 @@
-<?php return array (
-  'a' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '',
-          2 => "abc\r\n",
-        ),
-        1 => 
-        array (
-          0 => '',
-          1 => '1',
-          2 => "ls\r\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"a";a:2:{s:6:"chunks";a:1:{i:0;a:2:{i:0;a:3:{i:0;s:1:"1";i:1;s:0:"";i:2;s:3:"abc";}i:1;a:3:{i:0;s:0:"";i:1;s:1:"1";i:2;s:2:"ls";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"1";i:1;i:1;}i:1;a:2:{i:0;s:1:"1";i:1;i:1;}}}}}

test/data/IDF_DiffTest/test-07-mtn-single-line-to-multiline.expected

@@ -1,39 +1 @@
-<?php return array (
-  'a' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '1',
-          2 => "ls\r\n",
-        ),
-        1 => 
-        array (
-          0 => '',
-          1 => 2,
-          2 => "ls\r\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => '2',
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"a";a:2:{s:6:"chunks";a:1:{i:0;a:2:{i:0;a:3:{i:0;s:1:"1";i:1;s:1:"1";i:2;s:2:"ls";}i:1;a:3:{i:0;s:0:"";i:1;i:2;i:2;s:2:"ls";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"1";i:1;i:1;}i:1;a:2:{i:0;s:1:"1";i:1;s:1:"2";}}}}}

test/data/IDF_DiffTest/test-08-mtn-multiline-diff-with-property.expected

@@ -1,45 +1 @@
-<?php return array (
-  'a' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '1',
-          2 => "ls\r\n",
-        ),
-        1 => 
-        array (
-          0 => 2,
-          1 => 2,
-          2 => "ls\r\n",
-        ),
-        2 => 
-        array (
-          0 => '',
-          1 => 3,
-          2 => "l\r\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '2',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => '3',
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"a";a:2:{s:6:"chunks";a:1:{i:0;a:3:{i:0;a:3:{i:0;s:1:"1";i:1;s:1:"1";i:2;s:2:"ls";}i:1;a:3:{i:0;i:2;i:1;i:2;i:2;s:2:"ls";}i:2;a:3:{i:0;s:0:"";i:1;i:3;i:2;s:1:"l";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"1";i:1;s:1:"2";}i:1;a:2:{i:0;s:1:"1";i:1;s:1:"3";}}}}}

test/data/IDF_DiffTest/test-09-hg-new-file.expected

@@ -1,33 +1 @@
-<?php return array (
-  'a' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '',
-          1 => '1',
-          2 => "foo\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '0',
-          1 => '0',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => '1',
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"a";a:2:{s:6:"chunks";a:1:{i:0;a:1:{i:0;a:3:{i:0;s:0:"";i:1;s:1:"1";i:2;s:3:"foo";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"0";i:1;s:1:"0";}i:1;a:2:{i:0;s:1:"1";i:1;s:1:"1";}}}}}

test/data/IDF_DiffTest/test-10-hg-change.expected

@@ -1,39 +1 @@
-<?php return array (
-  'a' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '1',
-          2 => "foo\n",
-        ),
-        1 => 
-        array (
-          0 => '',
-          1 => 2,
-          2 => "bf\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '1',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => '2',
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"a";a:2:{s:6:"chunks";a:1:{i:0;a:2:{i:0;a:3:{i:0;s:1:"1";i:1;s:1:"1";i:2;s:3:"foo";}i:1;a:3:{i:0;s:0:"";i:1;i:2;i:2;s:2:"bf";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"1";i:1;s:1:"1";}i:1;a:2:{i:0;s:1:"1";i:1;s:1:"2";}}}}}

test/data/IDF_DiffTest/test-11-git-add-singleline-file.expected

@@ -1,33 +1 @@
-<?php return array (
-  'a' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '',
-          1 => '1',
-          2 => "abc\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '0',
-          1 => '0',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"a";a:2:{s:6:"chunks";a:1:{i:0;a:1:{i:0;a:3:{i:0;s:0:"";i:1;s:1:"1";i:2;s:3:"abc";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"0";i:1;s:1:"0";}i:1;a:2:{i:0;s:1:"1";i:1;i:1;}}}}}

test/data/IDF_DiffTest/test-12-git-add-multiline-file.expected

@@ -1,45 +1 @@
-<?php return array (
-  'b' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '',
-          1 => '1',
-          2 => "a\n",
-        ),
-        1 => 
-        array (
-          0 => '',
-          1 => 2,
-          2 => "b\n",
-        ),
-        2 => 
-        array (
-          0 => '',
-          1 => 3,
-          2 => "\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '0',
-          1 => '0',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => '3',
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"b";a:2:{s:6:"chunks";a:1:{i:0;a:3:{i:0;a:3:{i:0;s:0:"";i:1;s:1:"1";i:2;s:1:"a";}i:1;a:3:{i:0;s:0:"";i:1;i:2;i:2;s:1:"b";}i:2;a:3:{i:0;s:0:"";i:1;i:3;i:2;b:0;}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"0";i:1;s:1:"0";}i:1;a:2:{i:0;s:1:"1";i:1;s:1:"3";}}}}}

test/data/IDF_DiffTest/test-13-git-change-file.expected

@@ -1,51 +1 @@
-<?php return array (
-  'b' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '1',
-          2 => "a\n",
-        ),
-        1 => 
-        array (
-          0 => '',
-          1 => 2,
-          2 => "l\n",
-        ),
-        2 => 
-        array (
-          0 => 2,
-          1 => 3,
-          2 => "b\n",
-        ),
-        3 => 
-        array (
-          0 => 3,
-          1 => 4,
-          2 => "\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '3',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => '4',
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"b";a:2:{s:6:"chunks";a:1:{i:0;a:4:{i:0;a:3:{i:0;s:1:"1";i:1;s:1:"1";i:2;s:1:"a";}i:1;a:3:{i:0;s:0:"";i:1;i:2;i:2;s:1:"l";}i:2;a:3:{i:0;i:2;i:1;i:3;i:2;s:1:"b";}i:3;a:3:{i:0;i:3;i:1;i:4;i:2;b:0;}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"1";i:1;s:1:"3";}i:1;a:2:{i:0;s:1:"1";i:1;s:1:"4";}}}}}

test/data/IDF_DiffTest/test-14-git-change-file-to-singleline.expected

@@ -1,45 +1 @@
-<?php return array (
-  'b' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '1',
-          2 => "a\n",
-        ),
-        1 => 
-        array (
-          0 => 2,
-          1 => '',
-          2 => "b\n",
-        ),
-        2 => 
-        array (
-          0 => 3,
-          1 => '',
-          2 => "\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '3',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:1:"b";a:2:{s:6:"chunks";a:1:{i:0;a:3:{i:0;a:3:{i:0;s:1:"1";i:1;s:1:"1";i:2;s:1:"a";}i:1;a:3:{i:0;i:2;i:1;s:0:"";i:2;s:1:"b";}i:2;a:3:{i:0;i:3;i:1;s:0:"";i:2;b:0;}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"1";i:1;s:1:"3";}i:1;a:2:{i:0;s:1:"1";i:1;i:1;}}}}}

test/data/IDF_DiffTest/test-15-git-change-single-line-invalid.expected

@@ -1,39 +1 @@
-<?php return array (
-  'test_file' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '',
-          2 => "Steddy is awesome\n",
-        ),
-        1 => 
-        array (
-          0 => '',
-          1 => '1',
-          2 => 'Steddy is very awesome',
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:9:"test_file";a:2:{s:6:"chunks";a:1:{i:0;a:2:{i:0;a:3:{i:0;s:1:"1";i:1;s:0:"";i:2;s:17:"Steddy is awesome";}i:1;a:3:{i:0;s:0:"";i:1;s:1:"1";i:2;s:22:"Steddy is very awesome";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"1";i:1;i:1;}i:1;a:2:{i:0;s:1:"1";i:1;i:1;}}}}}

test/data/IDF_DiffTest/test-16-git-newline-removed.expected

@@ -1,39 +1 @@
-<?php return array (
-  'foo' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '',
-          2 => "This is foo\n",
-        ),
-        1 => 
-        array (
-          0 => '',
-          1 => '1',
-          2 => 'This is foo',
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:3:"foo";a:2:{s:6:"chunks";a:1:{i:0;a:2:{i:0;a:3:{i:0;s:1:"1";i:1;s:0:"";i:2;s:11:"This is foo";}i:1;a:3:{i:0;s:0:"";i:1;s:1:"1";i:2;s:11:"This is foo";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"1";i:1;i:1;}i:1;a:2:{i:0;s:1:"1";i:1;i:1;}}}}}

test/data/IDF_DiffTest/test-17-git-newline-added.expected

@@ -1,39 +1 @@
-<?php return array (
-  'foo' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '',
-          2 => "This is foo",
-        ),
-        1 => 
-        array (
-          0 => '',
-          1 => '1',
-          2 => "This is foo\n",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => 1,
-        ),
-      ),
-    ),
-  ),
-);
+a:1:{s:3:"foo";a:2:{s:6:"chunks";a:1:{i:0;a:2:{i:0;a:3:{i:0;s:1:"1";i:1;s:0:"";i:2;s:11:"This is foo";}i:1;a:3:{i:0;s:0:"";i:1;s:1:"1";i:2;s:11:"This is foo";}}}s:10:"chunks_def";a:1:{i:0;a:2:{i:0;a:2:{i:0;s:1:"1";i:1;i:1;}i:1;a:2:{i:0;s:1:"1";i:1;i:1;}}}}}

test/data/IDF_DiffTest/test-18-git-lineendings.diff

@@ -1,10 +0,0 @@
-diff --git a/lineendings b/lineendings
-index 7c2b7ec..9c59944 100644
---- a/lineendings
-+++ b/lineendings
-@@ -1,3 +1,4 @@
-+Unix, again
- Windows
- Unix
- Old Macintosh
-Nothing

test/data/IDF_DiffTest/test-18-git-lineendings.expected

@@ -1,51 +0,0 @@
-<?php return array (
-  'lineendings' => 
-  array (
-    'chunks' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '',
-          1 => '1',
-          2 => "Unix, again\n",
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => 2,
-          2 => "Windows\r\n",
-        ),
-        2 => 
-        array (
-          0 => 2,
-          1 => 3,
-          2 => "Unix\n",
-        ),
-        3 => 
-        array (
-          0 => 3,
-          1 => 4,
-          2 => "Old Macintosh\rNothing",
-        ),
-      ),
-    ),
-    'chunks_def' => 
-    array (
-      0 => 
-      array (
-        0 => 
-        array (
-          0 => '1',
-          1 => '3',
-        ),
-        1 => 
-        array (
-          0 => '1',
-          1 => '4',
-        ),
-      ),
-    ),
-  ),
-);

www/media/idf/css/print-wiki.css

@@ -1,32 +0,0 @@
-/*
-# ***** BEGIN LICENSE BLOCK *****
-# This file is part of InDefero, an open source project management application.
-# Copyright (C) 2008-2011 Céondo Ltd and contributors.
-#
-# InDefero is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# InDefero is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-#
-# ***** END LICENSE BLOCK ***** */
-
-#hd, #ft, #context {
-    display: none;
-}
-
-.yui-t3 #yui-main .yui-b {
-    margin: 0;
-}
-
-#wiki-toc {
-    float: none;
-}

www/media/idf/css/style.css

@@ -212,17 +212,17 @@ span.px-header-title a, span.px-header-title a:link, span.px-header-title a:visi
  * Issue
  */
 #tagscloud dl {
-  margin: 0;
+    margin: 0;
 }
 
 #tagscloud dt {
-  margin-top: .5em;
-  font-weight: bold;
+    margin-top: .5em;
+    font-weight: bold;
 }
 
 #tagscloud dd {
-  margin: 0;
-  display: inline;
+    margin: 0;
+    display: inline;
 }
 
 a.issue-c {
@@ -506,16 +506,16 @@ table td.fileicon {
   cursor: default;
   display: block;
   /*
-   if width will be 100% horizontal scrollbar will apear
-   when scroll mode will be used
-   */
+     if width will be 100% horizontal scrollbar will apear
+     when scroll mode will be used
+     */
   /*width: 100%;*/
   font: menu;
   font-size: 12px;
   /*
-   it is very important, if line-height not setted or setted
-   in relative units scroll will be broken in firefox
-   */
+     it is very important, if line-height not setted or setted
+     in relative units scroll will be broken in firefox
+     */
   line-height: 16px;
   overflow: hidden;
 }
@@ -571,38 +571,9 @@ table.commit table.changes table.properties td.removed {
 /**
  * syntax highlighting of diffs
  */
-span.ctrl-char {
-  color: white;
-  background: black;
-  text-align: center;
-  display: inline-block;
-  padding: 1px 1px 0px 1px;
-  margin-left: 1px;
-  margin-right: 1px;
-  -moz-border-radius: 2px;
-  -webkit-border-radius: 2px;
-  cursor: default;
-}
-
-/* special formatting for the TAB character: make it wider, so it is rendered more properly */ 
-span.ctrl-char[title="0x09"] {
-  width: 24px;
-}
-
 table.diff {
+  border-bottom: 1px solid #d3d7cf;
   width: 100%;
-  table-layout: fixed;
-}
-
-table.diff td {
-  border: none;
-  vertical-align: top;
-  padding: 0;
-}
-
-table.diff.unified > tbody > tr > td + td,
-table.diff.context > tbody > tr > td + td + td + td {
-    border-right: 1px solid #d3d7cf;
 }
 
 table.diff th {
@@ -611,92 +582,61 @@ table.diff th {
   border-color: #d3d7cf;
 }
 
-table.diff div.scroll {
-  overflow: auto;
+
+table.diff tr {
+  border-left: 1px solid #d3d7cf;
+  border-right: 1px solid #d3d7cf;
+  border-bottom: none;
+  border-top: none;
 }
 
-table.diff-contents td,
-table.diff-linecounts td {
+table.diff td {
+  font-size: 90%;
   vertical-align: top;
+  padding: 1px;
   border-color: inherit;
-  padding: 0;
 }
 
-table.diff-contents td.next,
-table.diff-linecounts td.next  {
+table.diff td.diff-lc {
+  text-align: right;
+  padding: 1px 5px;
+  border-color: inherit;
+  border-top: 1px solid #d3d7cf;
+  border-bottom: 1px solid #d3d7cf;
+  width: 3em;
+}
+
+td.diff-a {
+  background-color: #dfd;
+}
+
+td.diff-r {
+  background-color: #fdd;
+}
+
+td.diff-a, td.diff-r, td.diff-c  {
+  border-bottom: none;
+  border-top: none;
+  white-space: pre;
+}
+
+td.diff-a > span,
+td.diff-r > span,
+td.diff-c > span {
+  float: left;
+}
+
+table.diff tr.diff-next {
   background-color: #e4e8E0;
   vertical-align: top;
   text-align: right;
   border-color: #d3d7cf;
-  padding: 1px 10px;
 }
 
-table.diff-linecounts {
-  margin: 0;
+table.diff tr.diff-next td {
+  padding: 1px 5px;
 }
 
-table.diff-contents {
-  border-bottom: 1px solid #d3d7cf;
-  width: 100%;
-  margin: 0;
-}
-
-table.diff-linecounts tr,
-table.diff-contents tr {
-  height: 18px;
-}
-
-table.diff-linecounts tr {
-  border: 1px solid #d3d7cf;
-}
-
-table.diff-linecounts tr:first-child {
-  border-top: 0px;
-}
-
-table.diff-linecounts td {
-  font-size: 90%;
-  padding: 1px 10px;
-  text-align: right;
-  border-left: 1px solid #d3d7cf;
-}
-
-table.diff-contents td {
-  line-height: 12px;
-  padding: 2px;
-  font-size: 90%; 
-  border: none;
-  white-space: pre;
-}
-
-table.diff-contents td.added {
-  background-color: #dfd;
-}
-
-table.diff-contents td.removed {
-  background-color: #fdd;
-}
-
-table.diff-contents td > span.ctrl-char {
-  visibility: hidden;
-}
-
-table.diff-contents td:hover > span.ctrl-char {
-  visibility: visible;
-}
-
-table.diff-contents td.added > span.ctrl-char {
-  background: #0A0;   
-}
-
-table.diff-contents td.removed > span.ctrl-char {
-  background: #A00;
-}
-
-/* override prettify css rule */
-table.diff-contents td > span.ctrl-char > * {
-  color: white;
-}
 
 /**
  * view file content
@@ -740,14 +680,6 @@ table.code td.code {
   padding-left: 5px;
 }
 
-table.code td.code span.ctrl-char {
-  visibility: hidden;
-}
-
-table.code td.code:hover span.ctrl-char {
-  visibility: visible;
-}
-
 table.code td.code-lc {
   text-align: right;
   padding: 1px 5px;
@@ -869,37 +801,37 @@ ol > li {
 }
 
 #wiki-toc {
-  float: right;
-  margin-left: 10px;
-  margin-bottom: 10px;
-  max-width: 33%;
+    float: right;
+    margin-left: 10px;
+    margin-bottom: 10px;
+    max-width: 33%;
 }
 
 #wiki-toc-content {
-  border:  1px solid #999999;
-  border-width: 1px 0;
-  padding: 10px 0;
-  padding-bottom: 15px;
-  background-color: #ffffff;
-  display: block;
+    border:  1px solid #999999;
+    border-width: 1px 0;
+    padding: 10px 0;
+    padding-bottom: 15px;
+    background-color: #ffffff;
+    display: block;
 }
 
 #wiki-toc-content a {
-  display: block;
-  margin-top: 0.5em;
-  font-size: 90%;
+    display: block;
+    margin-top: 0.5em;
+    font-size: 90%;
 }
 
 #wiki-toc-content a:first-child {
-  margin-top: 0;
+    margin-top: 0;
 }
 
 #wiki-toc-content a.wiki-h2 {
-  margin-left: 1em;
+    margin-left: 1em;
 }
 
 #wiki-toc-content a.wiki-h3 {
-  margin-left: 2em;
+    margin-left: 2em;
 }
 
 /**
@@ -1138,86 +1070,87 @@ span.scm-action.property-changed {
  *  Stats on index
  */
 #stats > h3 {
-  text-decoration : underline;
+    text-decoration : underline;
 }
 
 #stats table tr td {
-  border-style: none;
+    border-style: none;
 }
 
 #stats td {
-  padding: .2em;
+    padding: .2em;
 }
 
 /*
  *  Project list on index
  */
 div.p-list-img {
-  float: left;
-  height: 32px;
-  margin-top: .5em;
+    float: left;
+    height: 32px;
+    margin-top: .5em;
 }
 
 div.p-list-prj {
-  float: left;
-  margin: .5em 0 .5em .8em;
+    float: left;
+    margin: .5em 0 .5em .8em;
 }
 
 div.p-list-prj p {
-  margin: 0px;
+    margin: 0px;
 }
 
 div.p-list-private {
-  bottom: 16px;
-  right: -3px;
-  position: relative;
+    bottom: 16px;
+    right: -3px;
+    position: relative;
 }
 
 /*
  * Issue summary
  */
 div.issue-summary {
-  float: left;
-  width: 50%;
+    float: left;
+    width: 50%;
 }
 
 div.issue-summary > div {
-  margin-right: 3em;
-  padding-top: 1em;
+    margin-right: 3em;
+    padding-top: 1em;
 }
 
 div.issue-summary h2 {
-  border-bottom: 1px solid #A5E26A;
+    border-bottom: 1px solid #A5E26A;
 }
 
 table.issue-summary {
-  width: 100%;
+    width: 100%;
 }
 
 table.issue-summary tr td {
-  border: 0;
-  padding: .1em .005em;
+    border: 0;
+    padding: .1em .005em;
 }
 
 table.issue-summary td.graph {
-  width: 60%;
+    width: 60%;
 }
 
 table.issue-summary td.count {
-  text-align: right;
-  padding-right: .5em;
+    text-align: right;
+    padding-right: .5em;
 }
 
 table.graph {
-  width: 100%;
-  margin: 0;
-  padding: 0;
+    width: 100%;
+    margin: 0;
+    padding: 0;
 }
 
 table.issue-summary td.graph-color {
-  background: #3C78B5;
+    background: #3C78B5;
 }
 
 table.issue-summary td.graph-percent {
-  padding-left: 1em;
+    padding-left: 1em;
 }
+