Commit Graph

88 Commits

Author SHA1 Message Date
Thomas Keller
464c1a8ef5 Fix / adapt the side-by-side review diff rendering. 2011-10-09 03:14:43 +02:00
Thomas Keller
234b70845c Render the TAB char wider, so it is easier recognized as tab 2011-10-09 02:04:13 +02:00
Thomas Keller
6abd0b6faa - Move common static methods out of IDF_Diff and into IDF_FileUtil.
- Make stuff that should be private in IDF_Diff really private
  and comment out a test that was the only call path for a previously
  public method.
- Apply the whitespace emphasizing on the normal file view as well
  and get finally rid of padLine()
2011-10-09 01:54:51 +02:00
Thomas Keller
7438a2bf19 Improve the rendering of the control characters greatly by using
the Unicode counterparts in th 0x24## plane and add a little bit
of explanation what we are doing there and why we are doing this.
2011-10-09 00:55:42 +02:00
Thomas Keller
2e0995abac Fixed rendering in Firefox which did, unlike Chrome, not expand the last
row's height to fit the up-popping horizontal scrollbar, but all rows
just a little, so the heights did not match. I've reworked this to not
used the ill-advised rowspan any longer, but two separate tables whose
heights match each other now in both browsers.

Also I fixed a bug in the whitespace detection code - utf8 characters
where broken into single bytes, so apparently the [:print:] character
class does not accout for them, even in //u mode, so we're selecting
the characters that we want to make visible on our own (basically
control characters lower than space, I might add more).
2011-10-09 00:13:34 +02:00
Thomas Keller
f19f07ec59 Change the unidiff rendering by letting the actual content be rendered
into a separate container that can overflow and side-scroll for long lines.

This effectively removes the need for all kinds of line-breaking hacks
that have been applied before and only worked when the browser was
actually able to break a word group apart somewhere.

Lines are now always rendered as-is; as a nice side effect the line numbers
are always visible, independently how far one scrolled into one direction,
so the context is always clear. If the rendering area is made smaller, the
table rendering also degrades gracefully and provides horizontal scrolling
for views that did not need them before.

The size that is occupied by the number display is now also automatically
determined by the size that is needed to render the biggest line number
in a column. Empty columns are rendered with a zero size.

Currently all this works nicely with a recent version of Chrome, Firefox
still needs some fine tuning for the vertical positioning. Other browsers
are untested as of now.
2011-10-06 02:06:51 +02:00
Thomas Keller
83761c66c5 The left floating breaks the vertical alignment of the unprintable characters. Remove that workaround, which was introduced to wrap very long lines; it should be replaced by something smarter. 2011-10-06 00:00:07 +02:00
Thomas Keller
d0e2977746 Add support for line ending detection in our diff parser.
Line endings are now preserved during the diff parsing. When the diff
is then rendered later on, we replace non-printable characters by their
ordinal counterparts, so a user can easily grasp changes when a hunk
comes with edits that might be invisible at first.

The expected format for the diff test suite has changed from serialized
PHP to var_export, which is easier readable, editable and understandable,
while still keeping parsable as well.

Support for old Macintosh line endings could not be added, mainly because
modern SCMs do not support single \r in their unified diff output either
and working around and parsing these "lines" would have been a major
headache with not much outcome (given the fact that all Macs that have been
sold since 2001 or 2002 have been BSD-based and as such used Unix line
endings by default).

This commit fixes issue 636.
2011-10-05 02:44:04 +02:00
William MARTIN
6e7c9f7c4b Use css instead of   2011-06-15 17:29:29 +02:00
William MARTIN
ef5b93e3f7 Fix the special case of a empty issue tracker, for the issue summary. 2011-06-15 11:18:41 +02:00
William MARTIN
69ae1c08ef Add an sub-tab under Issue to add a summury view 2011-06-15 09:11:47 +02:00
Thomas Keller
7ff6f09f67 We can actually differentiate between copies and renames in Hg, so lets
add support for another change type, 'copies'. The previous implementation
for Hg was also slightly flawed in the way that it mixed sources with
targets.
2011-06-10 01:34:33 +02:00
Thomas Keller
c0e26133bd Keep the context area in the view if a view scrolls down several pages. 2011-06-02 02:04:52 +02:00
William MARTIN
998f4576fe Fix div collision 2011-05-31 15:39:46 +02:00
Thomas Keller
8502a36481 Mark two new strings in the latest updates view for translation;
prettify the RSS icon display somewhat.
2011-05-16 23:49:08 +02:00
Thomas Keller
45d53e8d21 Merge branch 'feature.better-home' into develop 2011-04-27 00:07:40 +02:00
Thomas Keller
b36b8e3afb Final adjustions to the project logo code
- remove the question mark from the default logo for simplification,
  add a soft drop shadow to make the logo more visible on not so light
  backgrounds
- display the project logo and the lock icon in the project list dropdown
- re-position the project title and display the lock icon (if needed)
  on top of the main logo
The code now works best with uploaded logos of 32x32px^2; smaller logos
will be downsampled and repositioned on a best breed basis.
2011-04-27 00:03:44 +02:00
William MARTIN
dc31155de1 Second pass of code review 2011-04-11 15:37:40 +02:00
William MARTIN
836ff71364 Update code to fix thomas review's 2011-04-06 15:33:26 +02:00
William MARTIN
5ea4b02205 Update copyrigt 2011-04-02 21:37:07 +02:00
William MARTIN
587aa11cda Update the index template 2011-04-01 14:14:30 +02:00
Thomas Keller
045eb766f1 Improve the rendering of the prev / next links in the issue view and note the change in NEWS. 2011-03-18 02:14:22 +01:00
Thomas Keller
be7725694e Let browsers properly render whitespace and expand the long line fix for unchanged and removed lines (fixes issue 623 again) 2011-03-17 23:23:28 +01:00
William MARTIN
da7fc3e7e3 Fix issue 623
File with only one big line can create a very large row table
2011-03-04 15:18:11 +01:00
Thomas Keller
41cfbbd0d9 Let the table of contents not take more than 33% of the available space;
improve the CSS a bit by making the font a little smaller and by introducing
a margin between every line. Partially closes issue 618.
2011-03-01 00:01:03 +01:00
William MARTIN
6f1bb309d4 Apply the UI enhancement of issue tags cloud to wiki and download part too. 2011-02-23 22:35:43 +01:00
William MARTIN
cdedaa4604 Fix issue 591
Improve render of issue tag list
2011-02-23 20:20:02 +01:00
William MARTIN
5e6d61b3a7 Add more statistics on the projects list page 2011-02-23 14:29:01 +01:00
Thomas Keller
7bcfb806b0 Create valid HTML for the branch and tag list headings (no block
elements inside headings) and also use a lower heading, h3 and not h1
for the subheadings.
Reduce the amount of code duplication with include's for each VCS.
2011-01-27 14:12:42 +01:00
Thomas Keller
2908e28999 Vertical-align properly. 2011-01-26 02:40:28 +01:00
Thomas Keller
52d76cd146 Make the change list in the commit view a little nicer by styling the
individual change types with colored markers and apply a little help
hint to each of them.
2011-01-26 02:27:08 +01:00
Thomas Keller
ccb1bd33d4 Add a clear button to the tag / branch filter input fields; simplify
the jQuery code a bit.
2011-01-26 01:37:29 +01:00
Loïc d'Anterroches
58804923ef Cosmetic fix to prevent wrapping of the date. 2011-01-23 17:08:07 +01:00
Thomas Keller
d445a65788 Beef up the branch and tag lists as per issue 601 - currently
only for the monotone plugin's source view.
2011-01-17 01:20:33 +01:00
William MARTIN
93af6a68bd Add table of contents on wiki pages 2011-01-07 22:33:18 +01:00
William MARTIN
afa91188d8 Enhancement of the view of an issue.
Add link previous and after to quickly jump to another issue.
Those links are pointing to issue with the same status (open/closed).

With little trick on url we can do the same thing for browse "my issue" and "my watchlist".
2011-01-06 22:38:38 +01:00
William MARTIN
9ccbcea743 Fixed issue 557, better CSS to render UL/OL. 2011-01-05 12:07:57 +01:00
Thomas Keller
39c29dbe10 Started on issue 544, extended commit details
* Scm.php: new SCM method "getChanges" which returns all available
  change information grouped by type
* Monotone.php: implement getChanges via get_revision
* <other scms>: rename "changes" member for getCommit to "diff" which
  matches better
* Source.php: query the commit's changes and set them in the template
* commit.html: render the changes, type-by-type. Link to the tree or
  the individual diff if applicable
* styles.css: some initial style sheet work
2010-12-08 01:48:26 +01:00
Thomas Keller
784c9718eb Implemented an extended user profile based on a patch from Jethro Carr (issue 510).
Changes with respect to the original patch:
- use Gconf instead of separate table / data scheme
- better form validation for URLs and emails
- no htmlentity-encoded contents in the database (pluf automatically safe-encodes
  stuff before it writes out contents into templates)
- add visual separators in the form views to have a distinct view of basic
  (important) data and other data which are only displayed in the public profile
- give a hint about the maximum display size of 60x60 px^2 and use max-width and
  max-height in the templates to avoid nasty distortions by the browser
- use target=_blank and rel=nofollow on the twitter and website links in the profile
- some whitespace / formatting / code style fixes
2010-12-05 01:22:32 +01:00
Thomas Keller
0af51d90ba More CSS tweaks for the project list dropdown 2010-10-16 01:42:34 +02:00
Thomas Keller
1887e9effd Ensure that the project list popup doesn't exceed the page height when
many projects are listed - instead make it scrollable.
2010-10-15 12:35:50 +00:00
Thomas Keller
7e10524f92 Add a popup menu in the main menu which allows to quickly jump between projects.
* refactor out the common menu code from several base*.html classes into main-menu.html
  and put the raw links into a unordered list (which makes it easier to create dynamic
  menus as we cannot insert block items into inline items in strict mode)
* query the list of available projects on every request and set them for every template
  in Middleware.php
* make the popup menu pretty
2010-10-15 00:40:09 +00:00
Thomas Keller
d994e0efb0 Remove the CSS3 pre-line rule, which is recognized by modern browsers
and leads to collapsing of multiple consecutive whitespaces
(closes issue 528).
2010-10-09 12:42:05 +00:00
Loic d'Anterroches
68cc1ed5d3 Improved the CSS style. 2009-07-08 14:28:30 +02:00
Loic d'Anterroches
1815aaa909 Fixed to have a better workaround for Firefox not to break Safari. 2009-06-29 22:10:32 +02:00
Loic d'Anterroches
3848bd8d22 Added longer description for the downloads. 2009-06-22 21:08:33 +02:00
Charles Melbye
b320375d60 Fixed issue 231, small CSS bug in WebKit-based browsers 2009-06-19 15:20:59 +02:00
Loic d'Anterroches
d014b36ee2 Added more room at the top of the page. 2009-05-30 20:33:47 +02:00
Mehdi Kabab
b9773b555c Fixed issue 189, no rounded tab in webkit (safari / chrome). 2009-04-16 11:47:42 +02:00
Mehdi Kabab
4276088410 Fixed issue 175, sub-tabs are displayed on two lines when the project title is too long. 2009-04-07 10:29:35 +02:00