diff --git a/doc/reviewing-contributions.xml b/doc/reviewing-contributions.xml index 0961307f84d..430ba7b4c55 100644 --- a/doc/reviewing-contributions.xml +++ b/doc/reviewing-contributions.xml @@ -6,18 +6,20 @@ Reviewing contributions - The following section is a draft, and the policy for reviewing is still being - discussed in issues such as #11166 - and and + #20836 . - The nixpkgs project receives a fairly high number of contributions via - GitHub pull-requests. Reviewing and approving these is an important task and - a way to contribute to the project. + The nixpkgs project receives a fairly high number of contributions via GitHub + pull-requests. Reviewing and approving these is an important task and a way + to contribute to the project. The high change rate of nixpkgs makes any pull request that remains open for @@ -38,10 +40,10 @@ to respect every community member and their work. - GitHub provides reactions as a simple and quick way to provide - feedback to pull-requests or any comments. The thumb-down reaction should be - used with care and if possible accompanied with some explanation so the - submitter has directions to improve their contribution. + GitHub provides reactions as a simple and quick way to provide feedback to + pull-requests or any comments. The thumb-down reaction should be used with + care and if possible accompanied with some explanation so the submitter has + directions to improve their contribution. Pull-request reviews should include a list of what has been reviewed in a @@ -101,8 +103,9 @@ - mention-bot usually notifies GitHub users based on the submitted changes, - but it can happen that it misses some of the package maintainers. + mention-bot usually notifies GitHub users based on the submitted + changes, but it can happen that it misses some of the package + maintainers. @@ -114,8 +117,8 @@ - License can change with version updates, so it should be checked to match - the upstream license. + License can change with version updates, so it should be checked to + match the upstream license. @@ -140,8 +143,8 @@ Pull-requests are often targeted to the master or staging branch, and - building the pull-request locally when it is submitted can trigger - many source builds. + building the pull-request locally when it is submitted can trigger many + source builds. It is possible to rebase the changes on nixos-unstable or