Final adjustions to the project logo code

- remove the question mark from the default logo for simplification,
  add a soft drop shadow to make the logo more visible on not so light
  backgrounds
- display the project logo and the lock icon in the project list dropdown
- re-position the project title and display the lock icon (if needed)
  on top of the main logo
The code now works best with uploaded logos of 32x32px^2; smaller logos
will be downsampled and repositioned on a best breed basis.

.gitignore

@@ -9,3 +9,6 @@ indefero-*.zip
 src/IDF/conf/path.php
 .tx/config
 src/IDF/locale/idf.pot.bak
+test/test.db
+test/tmp
+test/config.php

AUTHORS

@@ -31,6 +31,7 @@ Much appreciated contributors (in alphabetical order):
     Raphaël Emourgeon <raphael>
     Samuel Suther <info@suther.de>                  - German translation
     Sindre R. Myren <sindrero@stud.ntnu.no>
+    Stewart Platt <stew@futurete.ch>
     Thomas Keller <me@thomaskeller.biz>             - Monotone support
     Vladimir Solomatin <slash>
     William Martin <william.martin@lcpc.fr>

INSTALL.mdtext

@@ -4,6 +4,12 @@ The installation of InDefero is composed of 2 parts, first the
 installation of the [Pluf framework](http://www.pluf.org) and second,
 the installation of InDefero by itself.
 
+## PHP modules for indefero
+
+Indefero need the GD module for PHP. It's named "php5-gd" in debian.
+
+    $ apt-get install php5-gd
+
 ## Recommended Layout of the Files
 
 If your server document root is in `/var/www` a good thing is to keep
@@ -126,6 +132,7 @@ The documentation is available in the `doc` folder.
 * Subversion: `doc/syncsvn.mdtext`.
 * Mercurial: `doc/syncmercurial.mdtext`.
 * Git: `doc/syncgit.mdtext`.
+* Monotone: `doc/syncmonotone.mdtext`
 
 ## For the Apache Webserver Users
 

NEWS.mdtext

@@ -1,3 +1,16 @@
+# InDefero 1.2 - xxx xxx xx xx:xx 2011 UTC
+
+## New Features
+
+## Bugfixes 
+
+- monotone zip archive entries now all carry the revision date as mtime (issue 645)
+- Timeline only displays filter options for items a user has actually access to (issue 655)
+
+## Documentation
+
+## Translations
+
 # InDefero 1.1.1 - Mon Mar 28 15:52 2011 UTC
 
 ## Bugfixes

logo/no_logo.svg

@@ -0,0 +1,173 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!-- Created with Inkscape (http://www.inkscape.org/) -->
+
+<svg
+   xmlns:dc="http://purl.org/dc/elements/1.1/"
+   xmlns:cc="http://creativecommons.org/ns#"
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
+   xmlns:svg="http://www.w3.org/2000/svg"
+   xmlns="http://www.w3.org/2000/svg"
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
+   sodipodi:docname="no_logo.svg"
+   inkscape:version="0.47 r22583"
+   id="svg2985"
+   height="32"
+   width="32"
+   version="1.1"
+   inkscape:export-filename="/Users/tommyd/Entwicklung/indefero/www/media/idf/img/no_logo.png"
+   inkscape:export-xdpi="89.989998"
+   inkscape:export-ydpi="89.989998">
+  <sodipodi:namedview
+     pagecolor="#ffffff"
+     bordercolor="#666666"
+     borderopacity="1"
+     objecttolerance="10"
+     gridtolerance="10"
+     guidetolerance="10"
+     inkscape:pageopacity="0"
+     inkscape:pageshadow="2"
+     inkscape:window-width="1440"
+     inkscape:window-height="852"
+     id="namedview9"
+     showgrid="false"
+     inkscape:zoom="16.0625"
+     inkscape:cx="8.5507561"
+     inkscape:cy="16.122403"
+     inkscape:window-x="0"
+     inkscape:window-y="0"
+     inkscape:window-maximized="0"
+     inkscape:current-layer="g2847"
+     showguides="true"
+     inkscape:guide-bbox="true">
+    <sodipodi:guide
+       orientation="1,0"
+       position="16,25.836575"
+       id="guide3752" />
+    <sodipodi:guide
+       orientation="0,1"
+       position="-18.677042,16"
+       id="guide3754" />
+  </sodipodi:namedview>
+  <defs
+     id="defs2987">
+    <inkscape:perspective
+       sodipodi:type="inkscape:persp3d"
+       inkscape:vp_x="0 : 16 : 1"
+       inkscape:vp_y="0 : 1000 : 0"
+       inkscape:vp_z="32 : 16 : 1"
+       inkscape:persp3d-origin="16 : 10.666667 : 1"
+       id="perspective13" />
+    <inkscape:perspective
+       id="perspective2863"
+       inkscape:persp3d-origin="0.5 : 0.33333333 : 1"
+       inkscape:vp_z="1 : 0.5 : 1"
+       inkscape:vp_y="0 : 1000 : 0"
+       inkscape:vp_x="0 : 0.5 : 1"
+       sodipodi:type="inkscape:persp3d" />
+    <inkscape:perspective
+       id="perspective3676"
+       inkscape:persp3d-origin="0.5 : 0.33333333 : 1"
+       inkscape:vp_z="1 : 0.5 : 1"
+       inkscape:vp_y="0 : 1000 : 0"
+       inkscape:vp_x="0 : 0.5 : 1"
+       sodipodi:type="inkscape:persp3d" />
+    <inkscape:perspective
+       id="perspective3717"
+       inkscape:persp3d-origin="0.5 : 0.33333333 : 1"
+       inkscape:vp_z="1 : 0.5 : 1"
+       inkscape:vp_y="0 : 1000 : 0"
+       inkscape:vp_x="0 : 0.5 : 1"
+       sodipodi:type="inkscape:persp3d" />
+    <filter
+       inkscape:collect="always"
+       id="filter3816"
+       x="-0.14434362"
+       width="1.2886872"
+       y="-0.11562817"
+       height="1.2312563">
+      <feGaussianBlur
+         inkscape:collect="always"
+         stdDeviation="1.1799243"
+         id="feGaussianBlur3818" />
+    </filter>
+  </defs>
+  <metadata
+     id="metadata2990">
+    <rdf:RDF>
+      <cc:Work
+         rdf:about="">
+        <dc:format>image/svg+xml</dc:format>
+        <dc:type
+           rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
+        <dc:title></dc:title>
+      </cc:Work>
+    </rdf:RDF>
+  </metadata>
+  <g
+     inkscape:groupmode="layer"
+     id="layer2"
+     inkscape:label="shadow"
+     style="display:inline"
+     sodipodi:insensitive="true">
+    <g
+       transform="translate(0.44042901,0.78704792)"
+       id="g2847-8"
+       style="opacity:0.79710143;fill:#000000;stroke:#000000;stroke-opacity:1;filter:url(#filter3816)">
+      <g
+         id="g3838-0"
+         style="fill:#000000;stroke:#000000;stroke-opacity:1" />
+      <g
+         id="g2401-2"
+         transform="matrix(0.21219597,0,0,0.21219597,-70.751966,-27.73328)"
+         style="fill:#000000;fill-opacity:1;stroke:#000000;stroke-width:2.4000001;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none"
+         inkscape:export-filename="/home/loa/Projects/indefero/logo/powered-by-indefero.png"
+         inkscape:export-xdpi="12.330909"
+         inkscape:export-ydpi="12.330909">
+        <path
+           id="path2383-4"
+           d="m 396.19089,173.14471 c -7.67621,0.80661 -14.40195,5.39406 -19.58101,10.89131 -7.23597,7.88004 -11.69742,18.07908 -13.32198,28.60362 -1.7236,11.28173 -0.25925,23.20635 5.07686,33.37271 3.78607,7.24384 9.53161,13.92339 17.29701,16.96772 3.86478,1.53937 8.98362,1.03284 11.67912,-2.41036 2.64357,-3.5671 2.69463,-8.234 2.85756,-12.48867 0.045,-7.61054 -0.54749,-15.25544 0.45618,-22.83193 0.87131,-9.50623 4.03944,-18.56751 6.71612,-27.66851 1.16242,-4.44333 2.25094,-9.02808 1.97499,-13.64988 -0.48817,-4.62476 -3.58059,-9.31042 -8.2964,-10.4067 -1.57489,-0.44882 -3.23412,-0.48948 -4.85845,-0.37931 z"
+           style="fill:#000000;fill-opacity:1;fill-rule:nonzero;stroke:#000000;stroke-width:2.4000001;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;stroke-dashoffset:0"
+           inkscape:connector-curvature="0" />
+        <path
+           id="path2391-8"
+           d="m 433.14691,149.28687 c 7.2059,2.76589 12.51512,8.93778 16.09494,15.58815 4.94991,9.48434 6.61962,20.49058 5.46486,31.07695 -1.25505,11.34342 -5.75582,22.48271 -13.54134,30.92159 -5.53192,6.01709 -12.81048,10.98198 -21.09918,11.91276 -4.13154,0.4866 -8.94486,-1.32748 -10.65734,-5.35104 -1.63027,-4.12976 -0.4717,-8.65084 0.47212,-12.80269 1.92628,-7.36287 4.47721,-14.59393 5.4687,-22.17201 1.61875,-9.40784 0.90381,-18.98034 0.67386,-28.46402 0.0272,-4.59278 0.1624,-9.30303 1.62515,-13.69592 1.66851,-4.34082 5.86829,-8.06645 10.70716,-7.90484 1.63738,-0.0259 3.25061,0.36424 4.79107,0.89107 z"
+           style="fill:#000000;fill-opacity:1;fill-rule:nonzero;stroke:#000000;stroke-width:2.4000001;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;stroke-dashoffset:0"
+           inkscape:connector-curvature="0" />
+      </g>
+    </g>
+  </g>
+  <g
+     inkscape:groupmode="layer"
+     id="layer3"
+     inkscape:label="logo"
+     style="display:inline">
+    <g
+       id="layer1"
+       transform="translate(-0.06540759,0.09444087)">
+      <g
+         id="g2847">
+        <g
+           id="g3838" />
+        <g
+           id="g2401"
+           transform="matrix(0.21219597,0,0,0.21219597,-70.751966,-27.73328)"
+           style="fill:#e6e6e6;fill-opacity:1;stroke:#a0a0a0;stroke-width:2.4000001;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none"
+           inkscape:export-filename="/home/loa/Projects/indefero/logo/powered-by-indefero.png"
+           inkscape:export-xdpi="12.330909"
+           inkscape:export-ydpi="12.330909">
+          <path
+             id="path2383"
+             d="m 396.19089,173.14471 c -7.67621,0.80661 -14.40195,5.39406 -19.58101,10.89131 -7.23597,7.88004 -11.69742,18.07908 -13.32198,28.60362 -1.7236,11.28173 -0.25925,23.20635 5.07686,33.37271 3.78607,7.24384 9.53161,13.92339 17.29701,16.96772 3.86478,1.53937 8.98362,1.03284 11.67912,-2.41036 2.64357,-3.5671 2.69463,-8.234 2.85756,-12.48867 0.045,-7.61054 -0.54749,-15.25544 0.45618,-22.83193 0.87131,-9.50623 4.03944,-18.56751 6.71612,-27.66851 1.16242,-4.44333 2.25094,-9.02808 1.97499,-13.64988 -0.48817,-4.62476 -3.58059,-9.31042 -8.2964,-10.4067 -1.57489,-0.44882 -3.23412,-0.48948 -4.85845,-0.37931 z"
+             style="fill:#e6e6e6;fill-opacity:1;fill-rule:nonzero;stroke:#a0a0a0;stroke-width:2.4000001;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;stroke-dashoffset:0"
+             inkscape:connector-curvature="0" />
+          <path
+             id="path2391"
+             d="m 433.14691,149.28687 c 7.2059,2.76589 12.51512,8.93778 16.09494,15.58815 4.94991,9.48434 6.61962,20.49058 5.46486,31.07695 -1.25505,11.34342 -5.75582,22.48271 -13.54134,30.92159 -5.53192,6.01709 -12.81048,10.98198 -21.09918,11.91276 -4.13154,0.4866 -8.94486,-1.32748 -10.65734,-5.35104 -1.63027,-4.12976 -0.4717,-8.65084 0.47212,-12.80269 1.92628,-7.36287 4.47721,-14.59393 5.4687,-22.17201 1.61875,-9.40784 0.90381,-18.98034 0.67386,-28.46402 0.0272,-4.59278 0.1624,-9.30303 1.62515,-13.69592 1.66851,-4.34082 5.86829,-8.06645 10.70716,-7.90484 1.63738,-0.0259 3.25061,0.36424 4.79107,0.89107 z"
+             style="fill:#e6e6e6;fill-opacity:1;fill-rule:nonzero;stroke:#a0a0a0;stroke-width:2.4000001;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;stroke-dashoffset:0"
+             inkscape:connector-curvature="0" />
+        </g>
+      </g>
+    </g>
+  </g>
+</svg>

phpunit.xml

@@ -12,4 +12,16 @@
             <directory>test/IDF/</directory>
         </testsuite>
     </testsuites>
+
+    <filter>
+        <whitelist>
+            <directory suffix=".php">src/IDF</directory>
+            <exclude>
+                <directory suffix=".php">src/IDF/Tests</directory>
+                <directory suffix=".php">src/IDF/conf</directory>
+                <file>src/IDF/version.php</file>
+            </exclude>
+        </whitelist>
+    </filter>
 </phpunit>
+

run-tests

@@ -0,0 +1,14 @@
+#!/usr/bin/env php
+<?php
+
+$xmlfile = dirname(__FILE__) .'/test/report.xml';
+passthru('phpunit --coverage-clover='.$xmlfile);
+$xml = simplexml_load_string(file_get_contents($xmlfile));
+unlink($xmlfile);
+printf(
+   '>>> code coverage %s/%s (%s%%)'."\n",
+   $xml->project->metrics['coveredstatements'],
+   $xml->project->metrics['statements'],
+   round(($xml->project->metrics['coveredstatements']/(float)$xml->project->metrics['statements']) * 100.0, 2)
+);
+

src/IDF/Form/ProjectConf.php

@@ -0,0 +1,140 @@
+<?php
+/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+# ***** BEGIN LICENSE BLOCK *****
+# This file is part of InDefero, an open source project management application.
+# Copyright(C) 2008-2011 Céondo Ltd and contributors.
+#
+# InDefero is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+#(at your option) any later version.
+#
+# InDefero is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+# ***** END LICENSE BLOCK ***** */
+
+
+/**
+ * Configuration of the project.
+ */
+class IDF_Form_ProjectConf extends Pluf_Form
+{
+    public $project = null;
+
+    public function initFields($extra=array())
+    {
+        $this->project = $extra['project'];
+
+        // Basic part
+        $this->fields['name'] = new Pluf_Form_Field_Varchar(array('required' => true,
+                                                                  'label' => __('Name'),
+                                                                  'initial' => $this->project->name,
+                                                                 ));
+        $this->fields['shortdesc'] = new Pluf_Form_Field_Varchar(array('required' => true,
+                                                                       'label' => __('Short Description'),
+                                                                       'initial' => $this->project->shortdesc,
+                                                                       'widget_attrs' => array('size' => '68'),
+                                                                      ));
+        $this->fields['description'] = new Pluf_Form_Field_Varchar(array('required' => true,
+                                                                         'label' => __('Description'),
+                                                                         'initial' => $this->project->description,
+                                                                         'widget_attrs' => array('cols' => 68,
+                                                                                                 'rows' => 26,
+                                                                                                ),
+                                                                         'widget' => 'Pluf_Form_Widget_TextareaInput',
+                                                                        ));
+                                                                        
+        // Logo part
+        $upload_path = Pluf::f('upload_path', false);
+        if (false === $upload_path) {
+            throw new Pluf_Exception_SettingError(__('The "upload_path" configuration variable was not set.'));
+        }
+        $upload_path .= '/' . $this->project->shortname;
+        $filename = '/%s'; 
+        $this->fields['logo'] = new Pluf_Form_Field_File(array('required' => false,
+                                                         'label' => __('Update the logo'),
+                                                         'initial' => '',
+                                                         'help_text' => __('The logo must be a picture with a size of 32 by 32.'),
+                                                         'max_size' => Pluf::f('max_upload_size', 5 * 1024),
+                                                         'move_function_params' => 
+                                                         array('upload_path' => $upload_path,
+                                                               'upload_path_create' => true,
+                                                               'file_name' => $filename,
+                                                               )
+                                                         ));
+                                                         
+        $this->fields['logo_remove'] = new Pluf_Form_Field_Boolean(array('required' => false,
+                                                                         'label' => __('Remove the current logo'),
+                                                                         'initial' => false,
+                                                                         'widget' => 'Pluf_Form_Widget_CheckboxInput',
+                                                                         ));
+    }
+    
+    /**
+     * If we have uploaded a file, but the form failed remove it.
+     *
+     */
+    function failed()
+    {
+        if (!empty($this->cleaned_data['logo']) 
+            && file_exists(Pluf::f('upload_path').'/'.$this->cleaned_data['logo'])) {
+            unlink(Pluf::f('upload_path').'/'.$this->cleaned_data['logo']);
+        }
+    }
+    
+    public function clean()
+    {
+        if (!isset($this->cleaned_data['logo_remove'])) {
+            $this->cleaned_data['logo_remove'] = false;
+        }
+        
+        return $this->cleaned_data;
+    }
+    
+    public function clean_logo()
+    {
+        if (empty($this->cleaned_data['logo'])) {
+            return '';
+        }
+        
+        $meta = getimagesize(Pluf::f('upload_path') . '/' . $this->project->shortname . $this->cleaned_data['logo']);
+        
+        if ($meta === false) {
+            throw new Pluf_Form_Invalid("Could not determine the size of the uploaded picture.");
+        }
+        
+        if ($meta[0] !== 32 || $meta[1] !== 32) {
+            throw new Pluf_Form_Invalid("The picture must have a size of 32 by 32.");
+        }
+
+        return $this->cleaned_data['logo'];
+    }
+
+    public function save($commit=true)
+    {
+        $conf = $this->project->getConf();
+        
+        // Basic part
+        $this->project->name = $this->cleaned_data['name'];
+        $this->project->shortdesc = $this->cleaned_data['shortdesc'];
+        $this->project->description = $this->cleaned_data['description'];
+        $this->project->update();
+        
+        // Logo part
+        if ($this->cleaned_data['logo'] !== "") {
+            $conf->setVal('logo', $this->cleaned_data['logo']);
+        }
+        if ($this->cleaned_data['logo_remove'] === true) {
+            @unlink(Pluf::f('upload_path') . '/' . $this->project->shortname . $conf->getVal('logo'));
+            $conf->delVal('logo');
+        }
+    }
+}

src/IDF/Scm/Monotone.php

@@ -36,12 +36,12 @@ class IDF_Scm_Monotone extends IDF_Scm
     private static $instances = array();
 
     /**
-     * @see IDF_Scm::__construct()
+     * Constructor
      */
-    public function __construct($project)
+    public function __construct(IDF_Project $project, IDF_Scm_Monotone_IStdio $stdio)
     {
         $this->project = $project;
-        $this->stdio = new IDF_Scm_Monotone_Stdio($project);
+        $this->stdio = $stdio;
     }
 
     /**
@@ -458,8 +458,9 @@ class IDF_Scm_Monotone extends IDF_Scm
     public static function factory($project)
     {
         if (!array_key_exists($project->shortname, self::$instances)) {
+            $stdio = new IDF_Scm_Monotone_Stdio($project);
             self::$instances[$project->shortname] =
-                new IDF_Scm_Monotone($project);
+                new IDF_Scm_Monotone($project, $stdio);
         }
         return self::$instances[$project->shortname];
     }

src/IDF/Scm/Monotone/BasicIO.php

@@ -21,6 +21,8 @@
 #
 # ***** END LICENSE BLOCK ***** */
 
+require_once 'IDF/Scm/Exception.php';
+
 /**
  * Utility class to parse and compile basic_io stanzas
  *
@@ -31,6 +33,11 @@ class IDF_Scm_Monotone_BasicIO
     /**
      * Parses monotone's basic_io format
      *
+     * Known quirks:
+     * - does not handle multi-values starting with a hash '[]' (no known output)
+     * - does not validate hashes (should be /[0-9a-f]{40}/i)
+     * - does not handle forbidden \0
+     *
      * @param string $in
      * @return array of arrays
      */
@@ -54,50 +61,56 @@ class IDF_Scm_Monotone_BasicIO
                     $stanzaLine['key'] .= $ch;
                 }
 
-                // symbol w/o a value list
+                // ensure we don't look at a symbol w/o a value list
-                if ($pos >= $length || $in[$pos] == "\n") break;
+                if ($pos >= $length || $in[$pos] == "\n") {
- 
-                if ($in[$pos] == '[') {
                     unset($stanzaLine['values']);
-                    ++$pos; // opening square bracket
-                    $stanzaLine['hash'] = substr($in, $pos, 40);
-                    $pos += 40;
-                    ++$pos; // closing square bracket
-                }
-                else
-                {
                     unset($stanzaLine['hash']);
-                    $valCount = 0;
+                }
-                    // if hashs and plain values are encountered in the same
+                else {
-                    // value list, we add the hash values as simple values as well
+                    if ($in[$pos] == '[') {
-                    while ($in[$pos] == '"' || $in[$pos] == '[') {
+                        unset($stanzaLine['values']);
-                        $isHashValue = $in[$pos] == '[';
+                        ++$pos; // opening square bracket
-                        ++$pos; // opening quote / bracket
+                        while ($pos < $length && $in[$pos] != ']') {
-                        $stanzaLine['values'][$valCount] = '';
+                            $stanzaLine['hash'] .= $in[$pos];
-                        while ($pos < $length) {
-                            $ch = $in[$pos]; $pr = $in[$pos-1];
-                            if (($isHashValue && $ch == ']')
-                                ||(!$isHashValue && $ch == '"' && $pr != '\\'))
-                                 break;
                             ++$pos;
-                            $stanzaLine['values'][$valCount] .= $ch;
                         }
-                        ++$pos; // closing quote
+                        ++$pos; // closing square bracket
+                    }
+                    else
+                    {
+                        unset($stanzaLine['hash']);
+                        $valCount = 0;
+                        // if hashs and plain values are encountered in the same
+                        // value list, we add the hash values as simple values as well
+                        while ($in[$pos] == '"' || $in[$pos] == '[') {
+                            $isHashValue = $in[$pos] == '[';
+                            ++$pos; // opening quote / bracket
+                            $stanzaLine['values'][$valCount] = '';
+                            while ($pos < $length) {
+                                $ch = $in[$pos]; $pr = $in[$pos-1];
+                                if (($isHashValue && $ch == ']')
+                                    ||(!$isHashValue && $ch == '"' && $pr != '\\'))
+                                     break;
+                                ++$pos;
+                                $stanzaLine['values'][$valCount] .= $ch;
+                            }
+                            ++$pos; // closing quote
 
-                        if (!$isHashValue) {
+                            if (!$isHashValue) {
-                            $stanzaLine['values'][$valCount] = str_replace(
+                                $stanzaLine['values'][$valCount] = str_replace(
-                                array("\\\\", "\\\""),
+                                    array("\\\\", "\\\""),
-                                array("\\", "\""),
+                                    array("\\", "\""),
-                                $stanzaLine['values'][$valCount]
+                                    $stanzaLine['values'][$valCount]
-                            );
+                                );
-                        }
+                            }
 
-                        if ($pos >= $length)
+                            if ($pos >= $length)
-                            break;
+                                break;
 
-                        if ($in[$pos] == ' ') {
+                            if ($in[$pos] == ' ') {
-                            ++$pos; // space
+                                ++$pos; // space
-                            ++$valCount;
+                                ++$valCount;
+                            }
                         }
                     }
                 }
@@ -114,6 +127,12 @@ class IDF_Scm_Monotone_BasicIO
     /**
      * Compiles monotone's basicio format
      *
+     * Known quirks:
+     * - does not validate keys for /[a-z_]+/
+     * - does not validate hashes (should be /[0-9a-f]{40}/i)
+     * - does not support intermixed value / hash formats
+     * - does not handle forbidden \0
+     *
      * @param array $in Array of arrays
      * @return string
      */
@@ -129,7 +148,7 @@ class IDF_Scm_Monotone_BasicIO
 
             $maxkeylength = 0;
             foreach ((array)$stanza as $lx => $line) {
-                if (!array_key_exists('key', $line)) {
+                if (!array_key_exists('key', $line) || empty($line['key'])) {
                     throw new IDF_Scm_Exception(
                         '"key" not found in basicio stanza '.$sx.', line '.$lx
                     );
@@ -157,13 +176,6 @@ class IDF_Scm_Monotone_BasicIO
                              $value).'"';
                     }
                 }
-                else
-                {
-                    throw new IDF_Scm_Exception(
-                        'neither "hash" nor "values" found in basicio '.
-                        'stanza '.$sx.', line '.$lx
-                    );
-                }
 
                 $out .= "\n";
             }

src/IDF/Scm/Monotone/IStdio.php

@@ -0,0 +1,66 @@
+<?php
+/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+# ***** BEGIN LICENSE BLOCK *****
+# This file is part of InDefero, an open source project management application.
+# Copyright (C) 2011 Céondo Ltd and contributors.
+#
+# InDefero is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# InDefero is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+# ***** END LICENSE BLOCK ***** */
+
+/**
+ * Monotone stdio interface
+ *
+ * @author Thomas Keller <me@thomaskeller.biz>
+ */
+interface IDF_Scm_Monotone_IStdio
+{
+    /**
+     * Constructor
+     */
+    public function __construct(IDF_Project $project);
+
+    /**
+     * Starts the stdio process and resets the command counter
+     */
+    public function start();
+
+    /**
+     * Stops the stdio process and closes all pipes
+     */
+    public function stop();
+
+    /**
+     * Executes a command over stdio and returns its result
+     *
+     * @param array Array of arguments
+     * @param array Array of options as key-value pairs. Multiple options
+     *              can be defined in sub-arrays, like
+     *              "r" => array("123...", "456...")
+     * @return string
+     */
+    public function exec(array $args, array $options = array());
+
+    /**
+     * Returns the last out-of-band output for a previously executed
+     * command as associative array with 'e' (error), 'w' (warning),
+     * 'p' (progress) and 't' (ticker, unparsed) as keys
+     *
+     * @return array
+     */
+    public function getLastOutOfBandOutput();
+}
+

src/IDF/Scm/Monotone/Stdio.php

@@ -21,6 +21,8 @@
 #
 # ***** END LICENSE BLOCK ***** */
 
+require_once 'IDF/Scm/Monotone/IStdio.php';
+
 /**
  * Monotone stdio class
  *
@@ -29,7 +31,7 @@
  *
  * @author Thomas Keller <me@thomaskeller.biz>
  */
-class IDF_Scm_Monotone_Stdio
+class IDF_Scm_Monotone_Stdio implements IDF_Scm_Monotone_IStdio
 {
     /** this is the most recent STDIO version. The number is output
         at the protocol start. Older versions of monotone (prior 0.47)
@@ -68,7 +70,7 @@ class IDF_Scm_Monotone_Stdio
      *
      * @return string
      */
-    public function _getAuthOptions()
+    private function _getAuthOptions()
     {
         $prjconf = $this->project->getConf();
         $name = $prjconf->getVal('mtn_client_key_name', false);

src/IDF/Scm/Monotone/ZipRender.php

@@ -45,7 +45,7 @@ class IDF_Scm_Monotone_ZipRender extends Pluf_HTTP_Response
     private $stdio = null;
     private $revision = null;
 
-    function __construct($stdio, $revision)
+    function __construct(IDF_Scm_Monotone_IStdio $stdio, $revision)
     {
         parent::__construct($revision, 'application/x-zip');
         $this->stdio = $stdio;
@@ -60,6 +60,26 @@ class IDF_Scm_Monotone_ZipRender extends Pluf_HTTP_Response
         $this->outputHeaders();
 
         if ($output_body) {
+            $certs = $this->stdio->exec(array('certs', $this->revision));
+            $stanzas = IDF_Scm_Monotone_BasicIO::parse($certs);
+
+            // use the revision's date (if there is one) as timestamp
+            // for all file entries
+            $timestamp = time();
+            foreach ($stanzas as $stanza) {
+                $next_is_date = false;
+                foreach ($stanza as $line) {
+                    if ($line['key'] == 'name' && $line['values'][0] == 'date') {
+                        $next_is_date = true;
+                        continue;
+                    }
+                    if ($next_is_date && $line['key'] == 'value') {
+                        $timestamp = strtotime($line['values'][0]);
+                        break;
+                    }
+                }
+            }
+
             $manifest = $this->stdio->exec(array('get_manifest_of', $this->revision));
             $stanzas = IDF_Scm_Monotone_BasicIO::parse($manifest);
 
@@ -69,7 +89,11 @@ class IDF_Scm_Monotone_ZipRender extends Pluf_HTTP_Response
                 if ($stanza[0]['key'] != 'file')
                     continue;
                 $content = $this->stdio->exec(array('get_file', $stanza[1]['hash']));
-                $zip->add_file($stanza[0]['values'][0], $content);
+                $zip->add_file(
+                    $stanza[0]['values'][0],
+                    $content,
+                    array('time' => $timestamp)
+                );
             }
 
             $zip->finish();

src/IDF/Views/Project.php

@@ -31,6 +31,25 @@ Pluf::loadFunction('Pluf_Shortcuts_GetFormForModel');
  */
 class IDF_Views_Project
 {
+    /**
+     * Home page of a project.
+     */
+    public $logo_precond = array('IDF_Precondition::baseAccess');
+    public function logo($request, $match)
+    {
+        $prj = $request->project;
+        
+        $logo = $prj->getConf()->getVal('logo');
+        if (empty($logo)) {
+            $url = Pluf::f('url_media') . '/idf/img/no_logo.png';
+            return new Pluf_HTTP_Response_Redirect($url);
+        }
+        
+        $info = IDF_FileUtil::getMimeType($logo);
+        return new Pluf_HTTP_Response_File(Pluf::f('upload_path') . '/' . $prj->shortname . $logo,
+                                           $info[0]);
+    }
+    
     /**
      * Home page of a project.
      */
@@ -62,20 +81,26 @@ class IDF_Views_Project
     }
 
     /**
-     * Returns an associative array with available model filters
+     * Returns an associative array with all accessible model filters
      *
      * @return array
      */
-    private static function getAvailableModelFilters()
+    private static function getAccessibleModelFilters($request)
     {
-        return array(
+        $filters = array('all' => __('All Updates'));
-            'all'       => __('All Updates'),
+
-            'commits'   => __('Commits'),
+        if (true === IDF_Precondition::accessSource($request))
-            'issues'    => __('Issues and Comments'),
+            $filters['commits'] = __('Commits');
-            'downloads' => __('Downloads'),
+        if (true === IDF_Precondition::accessIssues($request))
-            'documents' => __('Documents'),
+            $filters['issues'] = __('Issues and Comments');
-            'reviews'   => __('Reviews and Patches'),
+        if (true === IDF_Precondition::accessDownloads($request))
-        );
+            $filters['downloads'] = __('Downloads');
+        if (true === IDF_Precondition::accessWiki($request))
+            $filters['documents'] = __('Documents');
+        if (true === IDF_Precondition::accessReview($request))
+            $filters['reviews'] = __('Reviews and Patches');
+
+        return $filters;
     }
 
     /**
@@ -141,11 +166,11 @@ class IDF_Views_Project
         $prj = $request->project;
 
         $model_filter = @$match[2];
-        $all_model_filters = self::getAvailableModelFilters();
+        $accessible_model_filters = self::getAccessibleModelFilters($request);
-        if (!array_key_exists($model_filter, $all_model_filters)) {
+        if (!array_key_exists($model_filter, $accessible_model_filters)) {
             $model_filter = 'all';
         }
-        $title = (string)$prj . ' ' . $all_model_filters[$model_filter];
+        $title = (string)$prj . ' ' . $accessible_model_filters[$model_filter];
 
         $pag = new IDF_Timeline_Paginator(new IDF_Timeline());
         $pag->class = 'recent-issues';
@@ -183,7 +208,7 @@ class IDF_Views_Project
                                                      'feedurl' => $feedurl,
                                                      'timeline' => $pag,
                                                      'model_filter' => $model_filter,
-                                                     'all_model_filters' => $all_model_filters,
+                                                     'accessible_model_filters' => $accessible_model_filters,
                                                      ),
                                                $request);
 
@@ -214,11 +239,11 @@ class IDF_Views_Project
         $prj = $request->project;
         $model_filter = @$match[2];
 
-        $all_model_filters = self::getAvailableModelFilters();
+        $accessible_model_filters = self::getAccessibleModelFilters($request);
-        if (!array_key_exists($model_filter, $all_model_filters)) {
+        if (!array_key_exists($model_filter, $accessible_model_filters)) {
             $model_filter = 'all';
         }
-        $title = $all_model_filters[$model_filter];
+        $title = $accessible_model_filters[$model_filter];
 
         $classes = self::determineModelClasses($request, $model_filter);
         $sqls = sprintf('model_class IN (%s)', implode(', ', $classes));
@@ -267,29 +292,29 @@ class IDF_Views_Project
     {
         $prj = $request->project;
         $title = sprintf(__('%s Project Summary'), (string) $prj);    
-        $form_fields = array('fields'=> array('name', 'shortdesc',
+        $extra = array('project' => $prj);  
-                                              'description'));
         if ($request->method == 'POST') {
-            $form = Pluf_Shortcuts_GetFormForModel($prj, $request->POST,
+            $form = new IDF_Form_ProjectConf(array_merge($request->POST,
-                                                   $form_fields);
+                                                         $request->FILES),
+                                             $extra);      
             if ($form->isValid()) {
-                $prj = $form->save();
+                $form->save();
                 $request->user->setMessage(__('The project has been updated.'));
                 $url = Pluf_HTTP_URL_urlForView('IDF_Views_Project::admin',
                                                 array($prj->shortname));
                 return new Pluf_HTTP_Response_Redirect($url);
             }
         } else {
-            $form = Pluf_Shortcuts_GetFormForModel($prj, $prj->getData(),
+            $form = new IDF_Form_ProjectConf($prj->getData(), $extra);    
-                                                   $form_fields);
         }
-        $form->fields['description']->widget->attrs['cols'] = 68;
+        
-        $form->fields['description']->widget->attrs['rows'] = 26;
+        $logo = $prj->getConf()->getVal('logo');
-        $form->fields['shortdesc']->widget->attrs['size'] = 67;
         return Pluf_Shortcuts_RenderToResponse('idf/admin/summary.html',
                                                array(
                                                      'page_title' => $title,
                                                      'form' => $form,
+                                                     'project' => $prj,
+                                                     'logo' => $logo,
                                                      ),
                                                $request);        
     }

src/IDF/conf/urls.php

@@ -74,6 +74,11 @@ $ctl[] = array('regex' => '#^/p/([\-\w]+)/$#',
                'model' => 'IDF_Views_Project',
                'method' => 'home');
                
+$ctl[] = array('regex' => '#^/p/([\-\w]+)/logo/$#',
+               'base' => $base,
+               'model' => 'IDF_Views_Project',
+               'method' => 'logo');
+
 $ctl[] = array('regex' => '#^/p/([\-\w]+)/timeline/(\w+)/$#',
                'base' => $base,
                'model' => 'IDF_Views_Project',

src/IDF/templates/idf/admin/summary.html

@@ -9,7 +9,7 @@
 {/if}
 </div>
 {/if}
-<form method="post" action=".">
+<form method="post" enctype="multipart/form-data" action=".">
 <table class="form" summary="">
 <tr>
 <th><strong>{$form.f.name.labelTag}:</strong></th>
@@ -30,6 +30,30 @@
 {$form.f.description|unsafe}
 </td>
 </tr>
+<tr>
+<th><strong>{trans 'Current logo'}:</strong></th>
+<td>
+{if $logo}
+<img src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'Project logo'}" />
+{else}
+{trans 'Your project does not have a logo configured yet.'}
+{/if}
+</td>
+</tr>
+<tr>
+<th><strong>{$form.f.logo.labelTag}:</strong></th>
+<td>{if $form.f.logo.errors}{$form.f.logo.fieldErrors}{/if}
+{$form.f.logo|unsafe}
+</td>
+</tr>
+{if $logo}
+<tr>
+<th><strong>{$form.f.logo_remove.labelTag}:</strong></th>
+<td>{if $form.f.logo_remove.errors}{$form.f.logo_remove.fieldErrors}{/if}
+{$form.f.logo_remove|unsafe}
+</td>
+</tr>
+{/if}
 <tr><td>&nbsp;</td>
 <td>
 <input type="submit" name="submit" value="{trans 'Save Changes'}" />

src/IDF/templates/idf/base-full.html

@@ -37,7 +37,7 @@
 <body>
 <div id="{block docid}doc3{/block}">
   <div id="hd">
-    {if $project}<h1 class="project-title">{$project}</h1>{/if}
+    {if $project}<h1 class="project-title">{$project}<img class="logo" src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'Project logo'}" />{if $project.private}<img class="lock" src="{media '/idf/img/lock.png'}" alt="{trans 'Private project'}" />{/if}{$p}</h1>{/if}
     {include 'idf/main-menu.html'}
 <div id="header">
 <div id="main-tabs">

src/IDF/templates/idf/base.html

@@ -37,7 +37,7 @@
 <body>
 <div id="{block docid}doc3{/block}" class="{block docclass}yui-t3{/block}">
   <div id="hd">
-    {if $project}<h1 class="project-title">{$project}</h1>{/if}
+    {if $project}<h1 class="project-title">{$project}<img class="logo" src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'Project logo'}" />{if $project.private}<img class="lock" src="{media '/idf/img/lock.png'}" alt="{trans 'Private project'}" />{/if}{$p}</h1>{/if}
     {include 'idf/main-menu.html'}
 <div id="header">
 <div id="main-tabs">

src/IDF/templates/idf/index.html

@@ -9,9 +9,28 @@
 {aurl 'url', 'IDF_Views_Admin::projectCreate'}
 <p><a href="{$url}"><img style="vertical-align: text-bottom;" src="{media '/idf/img/add.png'}" alt="+" align="bottom" /></a> <a href="{$url}">{trans 'Create Project'}</a></p>{/if}
 {else}
-<ul>{foreach $projects as $p}
+{foreach $projects as $p}
-<li>{if $p.private}<img style="vertical-align: text-bottom;" src="{media '/idf/img/lock.png'}" alt="{trans 'Private project'}" /> {/if}<a href="{url 'IDF_Views_Project::home', array($p.shortname)}">{$p}</a>{if $p.shortdesc}, {$p.shortdesc}{/if}</li>
+<div class="p-list-img">
-{/foreach}</ul>
+    <a href="{url 'IDF_Views_Project::home', array($p.shortname)}">
+    <img src="{url 'IDF_Views_Project::logo', array($p.shortname)}" alt="{trans 'Project logo'}" />
+    </a>
+    {if $p.private}
+    <div class="p-list-private">
+        <a href="{url 'IDF_Views_Project::home', array($p.shortname)}">
+            <img style="float:right" src="{media '/idf/img/lock.png'}" alt="{trans 'Private project'}" />
+        </a>
+    </div>
+    {/if}
+</div>
+<div class="p-list-prj">
+    <p>
+        <a href="{url 'IDF_Views_Project::home', array($p.shortname)}"><strong>{$p}</strong></a>
+        {if $p.private} - {trans 'Private project'}{/if}
+    </p>
+    <p>{$p.shortdesc}</p>
+</div>
+<div style="clear: both"></div>
+{/foreach}
 {/if}
 {/block}
 {block context}

src/IDF/templates/idf/main-menu.html

@@ -8,8 +8,7 @@
 {/if}<li id="project-list"><a href="{url 'IDF_Views::index'}">{trans 'Project List'} &#x25be;</a>
 {if $allProjects.count() != 0}
 <ul>{foreach $allProjects as $p}
-<li>{if $p.private}<img style="vertical-align: text-bottom;" src="{media '/idf/img/lock.png'}" alt="{trans 'Private project'}" /> {/if}
+<li><a href="{url 'IDF_Views_Project::home', array($p.shortname)}"><img class="logo" src="{url 'IDF_Views_Project::logo', array($p.shortname)}" alt="{trans 'Project logo'}" />{if $p.private}<img class="lock" src="{media '/idf/img/lock.png'}" alt="{trans 'Private project'}" />{/if}{$p}</a></li>
-<a href="{url 'IDF_Views_Project::home', array($p.shortname)}">{$p}</a></li>
 {/foreach}</ul>
 {/if}</li>{if $isAdmin}<li><a href="{url 'IDF_Views_Admin::projects'}">{trans 'Forge Management'}</a></li>{/if}<li>
 <a href="{url 'IDF_Views::faq'}" title="{trans 'Help and accessibility features'}">{trans 'Help'}</a></li>

src/IDF/templates/idf/project/timeline.html

@@ -15,7 +15,7 @@
 {block context}
 <p><span class="label{if 'all' == $model_filter} active{/if}"><a href="{url 'IDF_Views_Project::timeline', array($project.shortname, 'all')}">{trans 'All Updates'}</a></span></p>
 <p><strong>{trans 'Filter by type'}</strong><br />
-{foreach $all_model_filters as $filter_key => $filter_name}
+{foreach $accessible_model_filters as $filter_key => $filter_name}
 {if $filter_key != 'all'}
 <span class="label{if $filter_key == $model_filter} active{/if}"><a href="{url 'IDF_Views_Project::timeline', array($project.shortname, $filter_key)}">{$filter_name}</a></span><br />
 {/if}

src/IDF/version.php

@@ -1,5 +1,5 @@
 <?php
 return array(
-    'version'  => '1.1.2-dev',
+    'version'  => '1.2-dev',
     'revision' => '$Format:%H$',
 );

test/IDF/DiffTest.php

@@ -1,4 +1,25 @@
 <?php
+/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+# ***** BEGIN LICENSE BLOCK *****
+# This file is part of InDefero, an open source project management application.
+# Copyright (C) 2011 Céondo Ltd and contributors.
+#
+# InDefero is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# InDefero is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+# ***** END LICENSE BLOCK ***** */
 
 include 'IDF/Diff.php';
 

test/IDF/Scm/Monotone/BasicIOTest.php

@@ -0,0 +1,176 @@
+<?php
+/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+# ***** BEGIN LICENSE BLOCK *****
+# This file is part of InDefero, an open source project management application.
+# Copyright (C) 2011 Céondo Ltd and contributors.
+#
+# InDefero is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# InDefero is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+# ***** END LICENSE BLOCK ***** */
+
+include 'IDF/Scm/Monotone/BasicIO.php';
+
+class IDF_Scm_Monotone_BasicIOTest extends PHPUnit_Framework_TestCase
+{
+    public function testParse()
+    {
+        $stanzas = IDF_Scm_Monotone_BasicIO::parse(null);
+        $this->assertTrue(is_array($stanzas) && count($stanzas) == 0);
+
+        // single stanza, single line, only key
+        $stanzas = IDF_Scm_Monotone_BasicIO::parse('foo');
+        $this->assertEquals(1, count($stanzas));
+        $stanza = $stanzas[0];
+        $this->assertEquals(1, count($stanza));
+        $entry = $stanza[0];
+        $this->assertEquals('foo', $entry['key']);
+        $this->assertTrue(!array_key_exists('hash', $entry));
+        $this->assertTrue(!array_key_exists('values', $entry));
+
+        // single stanza, single line, key with hash
+        $stanzas = IDF_Scm_Monotone_BasicIO::parse("foo    [0123456789012345678901234567890123456789]");
+        $this->assertEquals(1, count($stanzas));
+        $stanza = $stanzas[0];
+        $this->assertEquals(1, count($stanza));
+        $entry = $stanza[0];
+        $this->assertEquals('foo', $entry['key']);
+        $this->assertEquals("0123456789012345678901234567890123456789", $entry['hash']);
+        $this->assertTrue(!array_key_exists('values', $entry));
+
+        // single stanza, single line, key with two values
+        $stanzas = IDF_Scm_Monotone_BasicIO::parse("foo    \"bar\n\nbaz\" \"bla\"");
+        $this->assertEquals(1, count($stanzas));
+        $stanza = $stanzas[0];
+        $this->assertEquals(1, count($stanza));
+        $entry = $stanza[0];
+        $this->assertEquals('foo', $entry['key']);
+        $this->assertTrue(!array_key_exists('hash', $entry));
+        $this->assertEquals(array("bar\n\nbaz", "bla"), $entry['values']);
+
+        // single stanza, single line, key with a value and a hash
+        $stanzas = IDF_Scm_Monotone_BasicIO::parse("foo    \"bar\n\nbaz\" [0123456789012345678901234567890123456789]");
+        $this->assertEquals(1, count($stanzas));
+        $stanza = $stanzas[0];
+        $this->assertEquals(1, count($stanza));
+        $entry = $stanza[0];
+        $this->assertEquals('foo', $entry['key']);
+        $this->assertTrue(!array_key_exists('hash', $entry));
+        $this->assertEquals(array("bar\n\nbaz", "0123456789012345678901234567890123456789"), $entry['values']);
+
+        // single stanza, two lines, keys with single value / hash
+        $stanzas = IDF_Scm_Monotone_BasicIO::parse("foo    \"bar\"\nbaz [0123456789012345678901234567890123456789]");
+        $this->assertEquals(1, count($stanzas));
+        $stanza = $stanzas[0];
+        $this->assertEquals(2, count($stanza));
+        $entry = $stanza[0];
+        $this->assertEquals('foo', $entry['key']);
+        $this->assertTrue(!array_key_exists('hash', $entry));
+        $this->assertEquals(array("bar"), $entry['values']);
+        $entry = $stanza[1];
+        $this->assertEquals('baz', $entry['key']);
+        $this->assertTrue(!array_key_exists('values', $entry));
+        $this->assertEquals("0123456789012345678901234567890123456789", $entry['hash']);
+
+         // two stanza, one two liner, one one liner
+        $stanzas = IDF_Scm_Monotone_BasicIO::parse("foo    \"bar\"\nbaz [0123456789012345678901234567890123456789]\n\nbla \"blub\"");
+        $this->assertEquals(2, count($stanzas));
+        $stanza = $stanzas[0];
+        $this->assertEquals(2, count($stanza));
+        $entry = $stanza[0];
+        $this->assertEquals('foo', $entry['key']);
+        $this->assertTrue(!array_key_exists('hash', $entry));
+        $this->assertEquals(array("bar"), $entry['values']);
+        $entry = $stanza[1];
+        $this->assertEquals('baz', $entry['key']);
+        $this->assertTrue(!array_key_exists('values', $entry));
+        $this->assertEquals("0123456789012345678901234567890123456789", $entry['hash']);
+        $stanza = $stanzas[1];
+        $this->assertEquals(1, count($stanza));
+        $entry = $stanza[0];
+        $this->assertEquals('bla', $entry['key']);
+        $this->assertTrue(!array_key_exists('hash', $entry));
+        $this->assertEquals(array("blub"), $entry['values']);
+
+        // (un)escaping tests
+        $stanzas = IDF_Scm_Monotone_BasicIO::parse('foo    "bar\\baz" "bla\"blub"');
+        $this->assertEquals(1, count($stanzas));
+        $stanza = $stanzas[0];
+        $this->assertEquals(1, count($stanza));
+        $entry = $stanza[0];
+        $this->assertEquals('foo', $entry['key']);
+        $this->assertTrue(!array_key_exists('hash', $entry));
+        $this->assertEquals(array('bar\baz', 'bla"blub'), $entry['values']);
+
+    }
+
+    public function testCompile()
+    {
+        $stanzas = array(
+            array(
+                array('key' => 'foo'),
+                array('key' => 'bar', 'values' => array('one', "two\nthree")),
+            ),
+            array(
+                array('key' => 'baz', 'hash' => '0123456789012345678901234567890123456789'),
+                array('key' => 'blablub', 'values' => array('one"two', 'three\four')),
+            ),
+        );
+
+        $ex =<<<END
+foo
+bar "one" "two
+three"
+
+    baz [0123456789012345678901234567890123456789]
+blablub "one\"two" "three\\\\four"
+
+END;
+        $this->assertEquals($ex, IDF_Scm_Monotone_BasicIO::compile($stanzas));
+
+        // keys must not be null
+        $stanzas = array(
+            array(
+                array('key' => null, 'values' => array('foo')),
+            ),
+        );
+
+        $thrown = false;
+        try {
+            IDF_Scm_Monotone_BasicIO::compile($stanzas);
+        } catch (IDF_Scm_Exception $e) {
+            $this->assertRegExp('/^"key" not found in basicio stanza/', $e->getMessage());
+            $thrown = true;
+        }
+        $this->assertTrue($thrown);
+
+        // ...nor completly non-existing
+        $stanzas = array(
+            array(
+                array('values' => array('foo')),
+            ),
+        );
+
+        $thrown = false;
+        try {
+            IDF_Scm_Monotone_BasicIO::compile($stanzas);
+        } catch (IDF_Scm_Exception $e) {
+            $this->assertRegExp('/^"key" not found in basicio stanza/', $e->getMessage());
+            $thrown = true;
+        }
+        $this->assertTrue($thrown);
+    }
+}
+

test/IDF/Scm/Monotone/ZipRenderTest.php

@@ -0,0 +1,161 @@
+<?php
+/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+# ***** BEGIN LICENSE BLOCK *****
+# This file is part of InDefero, an open source project management application.
+# Copyright (C) 2011 Céondo Ltd and contributors.
+#
+# InDefero is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# InDefero is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+# ***** END LICENSE BLOCK ***** */
+
+require_once 'IDF/Scm/Monotone/ZipRender.php';
+require_once 'IDF/Scm/Monotone/IStdio.php';
+
+class ZipRenderStdioMock implements IDF_Scm_Monotone_IStdio
+{
+    // unused
+    public function __construct(IDF_Project $project) {}
+
+    // unused
+    public function start() {}
+
+    // unused
+    public function stop() {}
+
+    public function exec(array $args, array $options = array())
+    {
+        if ($args[0] == 'certs') {
+            $basicio =<<<END
+      key [0504aea5d3716d31281171aaecf3a7c227e5545b]
+signature "ok"
+     name "author"
+    value "joe@home"
+    trust "trusted"
+
+      key [0504aea5d3716d31281171aaecf3a7c227e5545b]
+signature "ok"
+     name "branch"
+    value "foo"
+    trust "trusted"
+
+      key [0504aea5d3716d31281171aaecf3a7c227e5545b]
+signature "ok"
+     name "changelog"
+    value "test"
+    trust "trusted"
+
+      key [0504aea5d3716d31281171aaecf3a7c227e5545b]
+signature "ok"
+     name "date"
+    value "2009-07-06T22:06:27"
+    trust "trusted"
+
+END;
+            return $basicio;
+        }
+        if ($args[0] == 'get_manifest_of') {
+            $basicio =<<<END
+format_version "1"
+
+dir ""
+
+   file "foo"
+content [6fcf9dfbd479ed82697fee719b9f8c610a11ff2a]
+
+dir "bar"
+
+   file "bar/baz"
+content [9063a9f0e032b6239403b719cbbba56ac4e4e45f]
+
+END;
+            return $basicio;
+        }
+
+        if ($args[0] == 'get_file') {
+            if ($args[1] == '6fcf9dfbd479ed82697fee719b9f8c610a11ff2a') {
+                return 'This is foo.';
+            }
+            if ($args[1] == '9063a9f0e032b6239403b719cbbba56ac4e4e45f') {
+                return 'This is baz.';
+            }
+            throw new Exception('unexpected id ' . $args[1]);
+        }
+
+        throw new Exception('unexpected command ' . $args[0]);
+    }
+
+    // unused
+    public function getLastOutOfBandOutput() {}
+}
+
+class IDF_Scm_Monotone_ZipRenderTest extends PHPUnit_Framework_TestCase
+{
+    // we can not test header sending with PHP-CLI, as header() is ignored
+    // in this environment
+    public function testRender()
+    {
+        $mock = new ZipRenderStdioMock(new IDF_Project());
+        $renderer = new IDF_Scm_Monotone_ZipRender($mock, '97fee719b9f8c610a11ff2a9063a9f0e032b6');
+
+        ob_start();
+        $renderer->render(true);
+        $zipcontents = ob_get_contents();
+        ob_end_clean();
+
+        // for this version php needs to be compiled with --enable-zip
+        if (function_exists('zip_open')) {
+            // yes, I'd rather have used php://memory here, but ZipArchive::open()
+            // complained that it could not open the stream in question
+            $filename = tempnam(Pluf::f('tmp_folder', '/tmp'), __CLASS__.'.');
+            file_put_contents($filename, $zipcontents);
+
+            $za = new ZipArchive();
+            $za->open($filename);
+            $this->assertEquals(2, $za->numFiles);
+
+            // 2009-07-06T22:06:27 - one second
+            // (don't ask me why, seems to be some quirk in zipstream)
+            $mtime = 1246910787 - 1;
+
+            // foo
+            $data = $za->statIndex(0);
+            $this->assertEquals('foo', $data['name']);
+            $this->assertEquals(12, $data['size']);
+            $this->assertEquals($mtime, $data['mtime']);
+
+            // bar/baz
+            $data = $za->statIndex(1);
+            $this->assertEquals('bar/baz', $data['name']);
+            $this->assertEquals(12, $data['size']);
+            $this->assertEquals($mtime, $data['mtime']);
+
+            $za->close();
+            unlink($filename);
+        }
+        else {
+            $wrapped_act = wordwrap(
+                base64_encode($zipcontents),
+                32, "\n", true
+            );
+            $wrapped_exp = wordwrap(
+                base64_encode(file_get_contents(DATADIR . '/' . __CLASS__ . '/data.zip')),
+                32, "\n", true
+            );
+
+            $this->assertEquals($wrapped_exp, $wrapped_act);
+        }
+    }
+}

test/bootstrap.php

@@ -1,7 +1,27 @@
 <?php
 
+$config_file =  dirname(__FILE__) . '/config.php';
+if (!file_exists($config_file)) {
+    die("'test/config.php' does not exist\n");
+}
+
+echo ">>> setting paths...\n";
 define('SRCDIR', realpath(dirname(__FILE__) . '/../src'));
 define('TESTDIR', dirname(__FILE__));
 define('DATADIR', TESTDIR . '/data');
-
 set_include_path(get_include_path() . PATH_SEPARATOR . SRCDIR);
+
+$testconfig = require_once $config_file;
+if (file_exists($testconfig['db_database'])) {
+    echo ">>> removing any existing database\n";
+    unlink($testconfig['db_database']);
+}
+
+echo ">>> creating empty test database...\n";
+passthru('php ' . PLUF_PATH . '/migrate.php --conf=' . TESTDIR . '/config.php -a -i');
+
+echo ">>> setting up web application...\n";
+require 'Pluf.php';
+// for PHPUnit 3.5 and beyond this is needed, since it comes with its own class loader
+spl_autoload_register('__autoload');
+Pluf::start(TESTDIR . '/config.php');

test/config.php-dist

@@ -0,0 +1,95 @@
+<?php
+/**
+ * This is a basic test configuration file for unit tests. It mimics most of
+ * the defaults from IDF/conf/idf.php-dist, but sets up a local sqlite database
+ * which is purged before each test run and uses a different temporary file
+ * directory.
+ *
+ * You can keep most of these settings as is, but ensure that you set up
+ * 'pear_path' at least, otherwise you'll get strange errors.
+ */
+
+require_once dirname(__FILE__).'/../src/IDF/conf/path.php';
+
+$cfg = array();
+$cfg['debug'] = true;
+$cfg['debug_scm'] = true;
+$cfg['git_repositories'] = '/home/git/repositories/%s.git';
+$cfg['git_remote_url'] = 'git://localhost/%s.git';
+$cfg['git_write_remote_url'] = 'git@localhost:%s.git';
+$cfg['svn_repositories'] = 'file:///home/svn/repositories/%s';
+$cfg['svn_remote_url'] = 'http://localhost/svn/%s';
+$cfg['mtn_path'] = 'mtn';
+$cfg['mtn_opts'] = array('--no-workspace', '--no-standard-rcfiles');
+$cfg['mtn_repositories'] = '/home/mtn/repositories/%s.mtn';
+$cfg['mtn_remote_url'] = 'mtn://my-host.biz/%s';
+$cfg['mtn_db_access'] = 'local';
+#$cfg['mtn_confdir'] = '/path/to/dir/tree/';
+#$cfg['mtn_confdir_extra'] = array('hooks.d/something.lua')
+#$cfg['mtn_usher_conf'] = '/path/to/usher.conf';
+$cfg['mercurial_repositories'] = '/home/mercurial/repositories/%s';
+#$cfg['mercurial_remote_url'] = 'http://projects.ceondo.com/hg/%s';
+$cfg['admins'] = array(array('Admin', 'you@example.com'),);
+$cfg['send_emails'] = true;
+$cfg['mail_backend'] = 'smtp';
+$cfg['mail_host'] = 'localhost';
+$cfg['mail_port'] = 25;
+$cfg['idf_base'] = '/index.php';
+$cfg['url_base'] = 'http://localhost';
+$cfg['url_media'] = 'http://localhost/media';
+$cfg['url_upload'] = 'http://localhost/media/upload';
+$cfg['upload_path'] = '/home/www/indefero/www/media/upload';
+$cfg['upload_issue_path'] = '/home/www/indefero/attachments';
+$cfg['secret_key'] = '';
+$cfg['from_email'] = 'sender@example.com';
+$cfg['bounce_email'] = 'no-reply@example.com';
+$cfg['tmp_folder'] = dirname(__FILE__) . '/tmp';
+$cfg['db_login'] = 'www';
+$cfg['db_password'] = '';
+$cfg['db_server'] = '';
+$cfg['db_version'] = '5.1';
+$cfg['db_table_prefix'] = 'indefero_';
+$cfg['db_engine'] = 'SQLite';
+$cfg['db_database'] = dirname(__FILE__).'/test.db';
+# $cfg['idf_extra_upload_ext'] = 'ext1 ext2';
+# $cfg['max_upload_size'] = 2097152;
+# $cfg['time_zone'] = 'Europe/Berlin';
+$cfg['pear_path'] = '/usr/share/php';
+$cfg['login_success_url'] = $cfg['url_base'].$cfg['idf_base'];
+$cfg['after_logout_page'] = $cfg['url_base'].$cfg['idf_base'];
+$cfg['cache_engine'] = 'Pluf_Cache_File';
+$cfg['cache_timeout'] = 300;
+$cfg['cache_file_folder'] = $cfg['tmp_folder'].'/cache';
+$cfg['template_folders'] = array(dirname(__FILE__).'/../src/IDF/templates');
+$cfg['installed_apps'] = array('Pluf', 'IDF');
+$cfg['pluf_use_rowpermission'] = true;
+$cfg['middleware_classes'] = array(
+    'Pluf_Middleware_Csrf',
+    'Pluf_Middleware_Session',
+    'IDF_Middleware',
+    'Pluf_Middleware_Translation',
+);
+$cfg['template_context_processors'] = array('IDF_Middleware_ContextPreProcessor');
+$cfg['idf_views'] = dirname(__FILE__).'/../src/IDF/conf/urls.php';
+
+$cfg['languages'] = array('en', 'fr', 'de', 'es_ES');
+$cfg['allowed_scm'] = array(
+    'git' => 'IDF_Scm_Git',
+    'svn' => 'IDF_Scm_Svn',
+    'mercurial' => 'IDF_Scm_Mercurial',
+    'mtn' => 'IDF_Scm_Monotone',
+);
+# $cfg['git_core_quotepath'] = false;
+# $cfg['idf_strong_key_check'] = false;
+# $cfg['idf_mimetypes_db'] = '/etc/mime.types';
+# $cfg['idf_extra_text_ext'] = 'ext1 ext2 ext3';
+# $cfg['idf_exec_cmd_prefix'] = '/usr/bin/env -i ';
+# $cfg['svn_path'] = 'svn';
+# $cfg['svnlook_path'] = 'svnlook';
+# $cfg['svnadmin_path'] = 'svnadmin';
+# $cfg['hg_path'] = 'hg';
+# $cfg['git_path'] = 'git';
+# $cfg['idf_no_size_check'] = false;
+
+return $cfg;
+

www/media/idf/css/style.css

@@ -327,12 +327,27 @@ h1.title {
 }
 
 h1.project-title {
-  font-weight: normal;
   float: right;
-  z-index: 100;
+  font-weight: normal;
-  text-align: right;
+  margin-top: 0.5em;
-  padding-right: 5px;
   margin-bottom: 0;
+  text-align: right;
+  z-index: 100;
+  position: relative;
+  padding-right: 3px;
+}
+
+h1.project-title img.logo {
+  max-height: 22px;
+  vertical-align: text-bottom;
+  padding-left: 7px;
+}
+
+h1.project-title img.lock {
+  width: 12px;
+  position: absolute;
+  right: 1px;
+  top: 12px;
 }
 
 .note {
@@ -871,8 +886,21 @@ ol > li {
   margin: 7px;
   white-space: nowrap;
   font-size: 0.95em;
-  list-style-type: square;
+  list-style-type: none;
-  list-style-position: inside;
+  position: relative;
+}
+
+#project-list ul li img.logo {
+  max-height: 16px;
+  vertical-align: text-bottom;
+  padding-right: 5px;
+}
+
+#project-list ul li img.lock {
+  position: absolute;
+  width: 9px;
+  left: 9px;
+  top: 9px;
 }
 
 #project-list ul li:first-child {
@@ -1043,3 +1071,27 @@ span.scm-action.property-changed {
 #stats td {
     padding: .2em;
 }
+
+/*
+ *  Project list on index
+ */
+div.p-list-img {
+    float: left;
+    height: 32px;
+    margin-top: .5em;
+}
+
+div.p-list-prj {
+    float: left;
+    margin: .5em 0 .5em .8em;
+}
+
+div.p-list-prj p {
+    margin: 0px;
+}
+
+div.p-list-private {
+    bottom: 16px;
+    right: -3px;
+    position: relative;
+}