From e7c2e721b415ccfd87f22b43b0facec2f6aa37a1 Mon Sep 17 00:00:00 2001
From: Thomas Keller <me@thomaskeller.biz>
Date: Sun, 2 Oct 2011 00:05:08 +0200
Subject: [PATCH] The tag cloud was fixed to "issues" for both, the open and
 closed issue list which is clearly wrong.

---
 NEWS.mdtext                             |  1 +
 src/IDF/Views/Issue.php                 | 16 +++++++++-------
 src/IDF/templates/idf/issues/index.html |  1 -
 3 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/NEWS.mdtext b/NEWS.mdtext
index 4732038..f0ecaf0 100644
--- a/NEWS.mdtext
+++ b/NEWS.mdtext
@@ -39,6 +39,7 @@ or newer to properly run this version of Indefero!
   as we have no information what the author string is actually encoded in
 - Indefero no longer displays an empty parents paragraph in the commit view for root revisions of
   a git repository
+- Indefero now only shows the tags of the closed and not the open issues in the closed issues list
 
 ## Documentation
 
diff --git a/src/IDF/Views/Issue.php b/src/IDF/Views/Issue.php
index 9c749af..953557c 100644
--- a/src/IDF/Views/Issue.php
+++ b/src/IDF/Views/Issue.php
@@ -71,7 +71,9 @@ class IDF_Views_Issue
                         'page_title' => $title,
                         'open' => $open,
                         'closed' => $closed,
-                        'issues' => $pag);
+                        'issues' => $pag,
+                        'cloud' => 'issues',
+                );
         if ($api) return $params;
         return Pluf_Shortcuts_RenderToResponse('idf/issues/index.html',
                                                $params, $request);
@@ -88,7 +90,7 @@ class IDF_Views_Issue
         $ownerStatistics = array();
         $status = array();
         $isTrackerEmpty = false;
-        
+
         $prj = $request->project;
         $opened = $prj->getIssueCountByStatus('open');
         $closed = $prj->getIssueCountByStatus('closed');
@@ -102,7 +104,7 @@ class IDF_Views_Issue
                 $status['Open'] = array($opened, (int)(100 * $opened / ($opened + $closed)));
                 $status['Closed'] = array($closed, (int)(100 * $closed / ($opened + $closed)));
             }
-            
+
             if ($opened > 0) {
                 // Issue owner statistics
                 $owners = $prj->getIssueCountByOwner('open');
@@ -130,15 +132,15 @@ class IDF_Views_Issue
                         $tagStatistics[$k][$kk] = array($vv[0], (int)(100 * $vv[0] / $nbIssueInClass), $vv[1]);
                     }
                 }
-                
+
                 // Sort
                 krsort($tagStatistics);
                 arsort($ownerStatistics);
             }
         }
-        
+
         $title = sprintf(__('Summary of tracked issues in %s.'), (string) $prj);
-        
+
         return Pluf_Shortcuts_RenderToResponse('idf/issues/summary.html',
                                                array('page_title' => $title,
                                                      'trackerEmpty' => $isTrackerEmpty,
@@ -149,7 +151,7 @@ class IDF_Views_Issue
                                                      ),
                                                $request);
     }
-    
+
     /**
      * View the issues watch list of a given user.
      * Limited to a specified project
diff --git a/src/IDF/templates/idf/issues/index.html b/src/IDF/templates/idf/issues/index.html
index e3b2d2a..979c7ee 100644
--- a/src/IDF/templates/idf/issues/index.html
+++ b/src/IDF/templates/idf/issues/index.html
@@ -13,6 +13,5 @@
 {blocktrans}<p><strong>Open issues:</strong> <a href="{$open_url}">{$open}</a></p>
 <p><strong>Closed issues:</strong> <a href="{$closed_url}">{$closed}</a></p>{/blocktrans}
 {assign $cloud_url = 'IDF_Views_Issue::listLabel'}
-{assign $cloud = 'issues'}
 {include 'idf/tags-cloud.html'}
 {/block}