Second pass of code review

INSTALL.mdtext

@@ -4,6 +4,12 @@ The installation of InDefero is composed of 2 parts, first the
 installation of the [Pluf framework](http://www.pluf.org) and second,
 the installation of InDefero by itself.
 
+## PHP modules for indefero
+
+Indefero need the GD module for PHP. It's named "php5-gd" in debian.
+
+    $ apt-get install php5-gd
+
 ## Recommended Layout of the Files
 
 If your server document root is in `/var/www` a good thing is to keep

logo/no_logo.svg

@@ -14,7 +14,10 @@
    id="svg2985"
    height="32"
    width="32"
-   version="1.1">
+   version="1.1"
+   inkscape:export-filename="/home/www/indefero/logo/no_logo.png"
+   inkscape:export-xdpi="89.989998"
+   inkscape:export-ydpi="89.989998">
   <sodipodi:namedview
      pagecolor="#ffffff"
      bordercolor="#666666"
@@ -45,97 +48,41 @@
         <dc:format>image/svg+xml</dc:format>
         <dc:type
            rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
-        <dc:title />
+        <dc:title></dc:title>
       </cc:Work>
     </rdf:RDF>
   </metadata>
   <g
      id="layer1">
     <g
-       id="g3838">
+       id="g3838" />
-      <g
-         id="g3776">
-        <path
-           inkscape:connector-curvature="0"
-           id="path2988"
-           d="m 0.34564999,22.338428 0,9.323144"
-           style="fill:none;stroke:#000000;stroke-width:0.68403965;stroke-linecap:square;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none" />
-        <path
-           inkscape:connector-curvature="0"
-           id="path2988-2"
-           d="m 9.6546337,31.65435 -9.31645142,0"
-           style="fill:none;stroke:#000000;stroke-width:0.68379408;stroke-linecap:square;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none" />
-      </g>
-      <g
-         transform="matrix(0,1,-1,0,32.003592,0.00346926)"
-         id="g3776-3">
-        <path
-           inkscape:connector-curvature="0"
-           id="path2988-5"
-           d="m 0.34564999,22.338428 0,9.323144"
-           style="fill:none;stroke:#000000;stroke-width:0.68403965;stroke-linecap:square;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none" />
-        <path
-           inkscape:connector-curvature="0"
-           id="path2988-2-8"
-           d="m 9.6546337,31.65435 -9.31645142,0"
-           style="fill:none;stroke:#000000;stroke-width:0.68379408;stroke-linecap:square;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none" />
-      </g>
-      <g
-         transform="matrix(0,-1,1,0,0.00359183,31.996285)"
-         id="g3776-36">
-        <path
-           inkscape:connector-curvature="0"
-           id="path2988-21"
-           d="m 0.34564999,22.338428 0,9.323144"
-           style="fill:none;stroke:#000000;stroke-width:0.68403965;stroke-linecap:square;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none" />
-        <path
-           inkscape:connector-curvature="0"
-           id="path2988-2-2"
-           d="m 9.6546337,31.65435 -9.31645142,0"
-           style="fill:none;stroke:#000000;stroke-width:0.68379408;stroke-linecap:square;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none" />
-      </g>
-      <g
-         transform="matrix(-1,0,0,-1,31.996531,31.996408)"
-         id="g3776-6">
-        <path
-           inkscape:connector-curvature="0"
-           id="path2988-4"
-           d="m 0.34564999,22.338428 0,9.323144"
-           style="fill:none;stroke:#000000;stroke-width:0.68403965;stroke-linecap:square;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none" />
-        <path
-           inkscape:connector-curvature="0"
-           id="path2988-2-3"
-           d="m 9.6546337,31.65435 -9.31645142,0"
-           style="fill:none;stroke:#000000;stroke-width:0.68379408;stroke-linecap:square;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none" />
-      </g>
-    </g>
     <g
        inkscape:export-ydpi="12.330909"
        inkscape:export-xdpi="12.330909"
        inkscape:export-filename="/home/loa/Projects/indefero/logo/powered-by-indefero.png"
-       style="fill:#b4b4b4;stroke:#727272;stroke-width:2.4000001;stroke-miterlimit:4;stroke-dasharray:none"
+       style="fill:#e6e6e6;stroke:#a0a0a0;stroke-width:2.40000010000000019;stroke-miterlimit:4;stroke-dasharray:none;fill-opacity:1;stroke-opacity:1"
        transform="matrix(0.21219597,0,0,0.21219597,-70.751966,-27.73328)"
        id="g2401">
       <path
          inkscape:connector-curvature="0"
-         style="fill:#b4b4b4;fill-opacity:1;fill-rule:nonzero;stroke:#727272;stroke-width:2.4000001;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;stroke-dashoffset:0"
+         style="fill:#e6e6e6;fill-opacity:1;fill-rule:nonzero;stroke:#a0a0a0;stroke-width:2.40000010000000019;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;stroke-dashoffset:0"
          d="m 396.19089,173.14471 c -7.67621,0.80661 -14.40195,5.39406 -19.58101,10.89131 -7.23597,7.88004 -11.69742,18.07908 -13.32198,28.60362 -1.7236,11.28173 -0.25925,23.20635 5.07686,33.37271 3.78607,7.24384 9.53161,13.92339 17.29701,16.96772 3.86478,1.53937 8.98362,1.03284 11.67912,-2.41036 2.64357,-3.5671 2.69463,-8.234 2.85756,-12.48867 0.045,-7.61054 -0.54749,-15.25544 0.45618,-22.83193 0.87131,-9.50623 4.03944,-18.56751 6.71612,-27.66851 1.16242,-4.44333 2.25094,-9.02808 1.97499,-13.64988 -0.48817,-4.62476 -3.58059,-9.31042 -8.2964,-10.4067 -1.57489,-0.44882 -3.23412,-0.48948 -4.85845,-0.37931 z"
          id="path2383" />
       <path
          inkscape:connector-curvature="0"
-         style="fill:#b4b4b4;fill-opacity:1;fill-rule:nonzero;stroke:#727272;stroke-width:2.4000001;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;stroke-dashoffset:0"
+         style="fill:#e6e6e6;fill-opacity:1;fill-rule:nonzero;stroke:#a0a0a0;stroke-width:2.40000010000000019;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;stroke-dashoffset:0"
          d="m 433.14691,149.28687 c 7.2059,2.76589 12.51512,8.93778 16.09494,15.58815 4.94991,9.48434 6.61962,20.49058 5.46486,31.07695 -1.25505,11.34342 -5.75582,22.48271 -13.54134,30.92159 -5.53192,6.01709 -12.81048,10.98198 -21.09918,11.91276 -4.13154,0.4866 -8.94486,-1.32748 -10.65734,-5.35104 -1.63027,-4.12976 -0.4717,-8.65084 0.47212,-12.80269 1.92628,-7.36287 4.47721,-14.59393 5.4687,-22.17201 1.61875,-9.40784 0.90381,-18.98034 0.67386,-28.46402 0.0272,-4.59278 0.1624,-9.30303 1.62515,-13.69592 1.66851,-4.34082 5.86829,-8.06645 10.70716,-7.90484 1.63738,-0.0259 3.25061,0.36424 4.79107,0.89107 z"
          id="path2391" />
     </g>
     <text
        transform="scale(1.118034,0.89442719)"
        sodipodi:linespacing="125%"
-       style="font-size:30.97047043px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;line-height:125%;letter-spacing:0px;word-spacing:0px;fill:#000000;fill-opacity:1;stroke:none;font-family:Ubuntu;-inkscape-font-specification:Ubuntu"
+       style="font-size:30.97047042999999888px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;line-height:125%;letter-spacing:0px;word-spacing:0px;fill:#828282;fill-opacity:1;stroke:none;font-family:Ubuntu;-inkscape-font-specification:Ubuntu"
        xml:space="preserve"
        id="text3763"
        y="28.666267"
        x="8.1167412"><tspan
-         style="fill:#000000;fill-opacity:1"
+         style="fill:#828282;fill-opacity:1"
          id="tspan3765"
          y="28.666267"
          x="8.1167412">?</tspan></text>

src/IDF/Form/ProjectConf.php

@@ -3,7 +3,7 @@
 /*
 # ***** BEGIN LICENSE BLOCK *****
 # This file is part of InDefero, an open source project management application.
-# Copyright(C) 2008 Céondo Ltd and contributors.
+# Copyright(C) 2008-2011 Céondo Ltd and contributors.
 #
 # InDefero is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -63,7 +63,7 @@ class IDF_Form_ProjectConf extends Pluf_Form
                                                          'label' => __('Update the logo'),
                                                          'initial' => '',
                                                          'help_text' => __('The logo must be a picture with a size of 32 by 32.'),
-                                                         'max_size' => Pluf::f('max_upload_size', 100 * 1024),
+                                                         'max_size' => Pluf::f('max_upload_size', 5 * 1024),
                                                          'move_function_params' => 
                                                          array('upload_path' => $upload_path,
                                                                'upload_path_create' => true,

src/IDF/Views/Project.php

@@ -40,7 +40,7 @@ class IDF_Views_Project
         $prj = $request->project;
         
         $logo = $prj->getConf()->getVal('logo');
-        if(empty($logo)) {
+        if (empty($logo)) {
             $url = Pluf::f('url_media') . '/idf/img/no_logo.png';
             return new Pluf_HTTP_Response_Redirect($url);
         }

src/IDF/templates/idf/admin/summary.html

@@ -34,7 +34,7 @@
 <th><strong>{trans 'Current logo'}:</strong></th>
 <td>
 {if $logo}
-<img src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'project logo'}" />
+<img src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'Project logo'}" />
 {else}
 {trans 'Your project does not have a logo configured yet.'}
 {/if}

src/IDF/templates/idf/base-full.html

@@ -37,7 +37,7 @@
 <body>
 <div id="{block docid}doc3{/block}">
   <div id="hd">
-    {if $project}<h1 class="project-title">{$project}</h1>{/if}
+    {if $project}<h1 class="project-title">{$project} <img src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'Project logo'}" /></h1>{/if}
     {include 'idf/main-menu.html'}
 <div id="header">
 <div id="main-tabs">

src/IDF/templates/idf/base.html

@@ -37,7 +37,7 @@
 <body>
 <div id="{block docid}doc3{/block}" class="{block docclass}yui-t3{/block}">
   <div id="hd">
-    {if $project}<h1 class="project-title">{$project}</h1>{/if}
+    {if $project}<h1 class="project-title">{$project} <img src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'Project logo'}" /></h1>{/if}
     {include 'idf/main-menu.html'}
 <div id="header">
 <div id="main-tabs">

www/media/idf/css/style.css

@@ -330,9 +330,7 @@ h1.project-title {
   font-weight: normal;
   float: right;
   z-index: 100;
-  text-align: right;
+  margin: 0;
-  padding-right: 5px;
-  margin-bottom: 0;
 }
 
 .note {