natalie/indefero
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Second pass of code review

Browse Source
This commit is contained in:
William MARTIN
2011-04-11 15:37:40 +02:00
parent 0bae69908b
commit dc31155de1
9 changed files with 24 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/IDF/Form/ProjectConf.php
View File

@@ -3,7 +3,7 @@
/*
# ***** BEGIN LICENSE BLOCK *****
# This file is part of InDefero, an open source project management application.
# Copyright(C) 2008 Céondo Ltd and contributors.
# Copyright(C) 2008-2011 Céondo Ltd and contributors.
#
# InDefero is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -63,7 +63,7 @@ class IDF_Form_ProjectConf extends Pluf_Form
'label' => __('Update the logo'),
'initial' => '',
'help_text' => __('The logo must be a picture with a size of 32 by 32.'),
'max_size' => Pluf::f('max_upload_size', 100 * 1024),
'max_size' => Pluf::f('max_upload_size', 5 * 1024),
'move_function_params' =>
array('upload_path' => $upload_path,
'upload_path_create' => true,

2
src/IDF/Views/Project.php
View File

@@ -40,7 +40,7 @@ class IDF_Views_Project
$prj = $request->project;
$logo = $prj->getConf()->getVal('logo');
if(empty($logo)) {
if (empty($logo)) {
$url = Pluf::f('url_media') . '/idf/img/no_logo.png';
return new Pluf_HTTP_Response_Redirect($url);
}

2
src/IDF/templates/idf/admin/summary.html
View File

@@ -34,7 +34,7 @@
<th><strong>{trans 'Current logo'}:</strong></th>
<td>
{if $logo}
<img src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'project logo'}" />
<img src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'Project logo'}" />
{else}
{trans 'Your project does not have a logo configured yet.'}
{/if}

2
src/IDF/templates/idf/base-full.html
View File

@@ -37,7 +37,7 @@
<body>
<div id="{block docid}doc3{/block}">
<div id="hd">
{if $project}<h1 class="project-title">{$project}</h1>{/if}
{if $project}<h1 class="project-title">{$project} <img src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'Project logo'}" /></h1>{/if}
{include 'idf/main-menu.html'}
<div id="header">
<div id="main-tabs">

2
src/IDF/templates/idf/base.html
View File

@@ -37,7 +37,7 @@
<body>
<div id="{block docid}doc3{/block}" class="{block docclass}yui-t3{/block}">
<div id="hd">
{if $project}<h1 class="project-title">{$project}</h1>{/if}
{if $project}<h1 class="project-title">{$project} <img src="{url 'IDF_Views_Project::logo', array($project.shortname)}" alt="{trans 'Project logo'}" /></h1>{/if}
{include 'idf/main-menu.html'}
<div id="header">
<div id="main-tabs">