natalie/indefero
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed issue 229, code review broken with new SCM backend.

Browse Source
This commit is contained in:
Loic d'Anterroches 2009-05-30 20:04:43 +02:00
parent 1c8490be6b
commit cefdceba13
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/IDF/Views/Review.php
View File

@ -207,7 +207,7 @@ class IDF_Views_Review
$files = array(); $files = array();
$reviewers = array(); $reviewers = array();
foreach ($diff->files as $filename => $def) { foreach ($diff->files as $filename => $def) {
$fileinfo = $scm->getFileInfo($filename, $patch->get_commit()->scm_id); $fileinfo = $scm->getPathInfo($filename, $patch->get_commit()->scm_id);
$sql = new Pluf_SQL('cfile=%s', array($filename)); $sql = new Pluf_SQL('cfile=%s', array($filename));
$cts = $patch->get_filecomments_list(array('filter'=>$sql->gen(), $cts = $patch->get_filecomments_list(array('filter'=>$sql->gen(),
'order'=>'creation_dtime ASC')); 'order'=>'creation_dtime ASC'));
@ -215,7 +215,7 @@ class IDF_Views_Review
$reviewers[] = $ct->get_submitter(); $reviewers[] = $ct->get_submitter();
} }
if (count($def['chunks'])) { if (count($def['chunks'])) {
$orig_file = ($fileinfo) ? $scm->getBlob($fileinfo) : ''; $orig_file = ($fileinfo) ? $scm->getFile($fileinfo) : '';
$files[$filename] = array( $files[$filename] = array(
$diff->fileCompare($orig_file, $def, $filename), $diff->fileCompare($orig_file, $def, $filename),
$form->f->{md5($filename)}, $form->f->{md5($filename)},