natalie/indefero
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Write-protect git repository over HTTP!

Browse Source 
I totally misunderstood the access control mechanism (but it's logical
that it behaves the way it does), and so on git projects with "open"
source access, repos were write-for-all.

This should fix it by enforcing member-or-owner auth for writes.

Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
Patrick Georgi 2011-09-03 19:30:34 +02:00
parent 33b22f95ab
commit cdb8dbafe2
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/IDF/Scm/Git.php
View File

@ -982,8 +982,14 @@ class IDF_Scm_Git extends IDF_Scm
if ($path == 'info/refs' && !empty($request->GET['service'])){ if ($path == 'info/refs' && !empty($request->GET['service'])){
$service = $request->GET['service']; $service = $request->GET['service'];
switch ($service) { switch ($service) {
case 'git-upload-pack':
case 'git-receive-pack': case 'git-receive-pack':
if (IDF_Precondition::projectMemberOrOwner($request) !== true) {
$response = new Pluf_HTTP_Response("");
$response->status_code = 401;
$response->headers['WWW-Authenticate']='Basic realm="git for '.$this->project.'"';
return $response;
}
case 'git-upload-pack':
$content = sprintf('%04x',strlen($service)+15). $content = sprintf('%04x',strlen($service)+15).
'# service='.$service."\n0000"; '# service='.$service."\n0000";
$content .= self::shell_exec('IDF_Scm_Git::repository', $content .= self::shell_exec('IDF_Scm_Git::repository',
@ -1000,8 +1006,14 @@ class IDF_Scm_Git extends IDF_Scm
switch($path) { switch($path) {
// smart HTTP RPC // smart HTTP RPC
case 'git-upload-pack':
case 'git-receive-pack': case 'git-receive-pack':
if (IDF_Precondition::projectMemberOrOwner($request) !== true) {
$response = new Pluf_HTTP_Response("");
$response->status_code = 401;
$response->headers['WWW-Authenticate']='Basic realm="git for '.$this->project.'"';
return $response;
}
case 'git-upload-pack':
$response = new Pluf_HTTP_Response_CommandPassThru( $response = new Pluf_HTTP_Response_CommandPassThru(
Pluf::f('idf_exec_cmd_prefix', '').$path. Pluf::f('idf_exec_cmd_prefix', '').$path.
' --stateless-rpc '.$this->repo, ' --stateless-rpc '.$this->repo,