From a30a62d48f54d953663a9b5c1e82f54a139212ae Mon Sep 17 00:00:00 2001 From: Loic d'Anterroches Date: Tue, 6 Jan 2009 22:04:48 +0100 Subject: [PATCH] Fixed issue 97, project created as private is not private. It was not a security issue, just a display issue. --- src/IDF/Views/Project.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/IDF/Views/Project.php b/src/IDF/Views/Project.php index dad368b..0c97580 100644 --- a/src/IDF/Views/Project.php +++ b/src/IDF/Views/Project.php @@ -416,7 +416,9 @@ class IDF_Views_Project $form = new IDF_Form_TabsConf($request->POST, $extra); if ($form->isValid()) { foreach ($form->cleaned_data as $key=>$val) { - $request->conf->setVal($key, $val); + if (!in_array($key, array('private_project', 'authorized_users'))) { + $request->conf->setVal($key, $val); + } } $form->save(); // Save the authorized users. $request->user->setMessage(__('The project tabs access rights have been saved.')); @@ -427,8 +429,8 @@ class IDF_Views_Project } else { $params = array(); $keys = array('downloads_access_rights', 'source_access_rights', - 'issues_access_rights', 'private_project', - 'review_access_rights', 'wiki_access_rights'); + 'issues_access_rights', 'review_access_rights', + 'wiki_access_rights'); foreach ($keys as $key) { $_val = $request->conf->getVal($key, false); if ($_val !== false) { @@ -438,9 +440,7 @@ class IDF_Views_Project // Add the authorized users. $md = $prj->getMembershipData('string'); $params['authorized_users'] = $md['authorized']; - if (count($params) == 0) { - $params = null; //Nothing in the db, so new form. - } + $params['private_project'] = $prj->private; $form = new IDF_Form_TabsConf($params, $extra); } return Pluf_Shortcuts_RenderToResponse('idf/admin/tabs.html',