diff --git a/src/IDF/Review.php b/src/IDF/Review.php index 224ce85..5f14a34 100644 --- a/src/IDF/Review.php +++ b/src/IDF/Review.php @@ -32,6 +32,15 @@ Pluf::loadFunction('Pluf_Template_dateAgo'); * * The real content of the review is in the IDF_Review_Patch which * contains a given patch and associated comments from reviewers. + * + * Basically the hierarchy of the models is: + * - Review > Patch > Comment > Comment on file + * + * For each review, one can have several patches. Each patch, is + * getting a series of comments. A comment is tracking the state + * change in the review (like the issue comments). For each comment, + * we have a series of file comments. The file comments are associated + * to the a given modified file in the patch. */ class IDF_Review extends Pluf_Model { @@ -71,12 +80,12 @@ class IDF_Review extends Pluf_Model 'verbose' => __('submitter'), 'relate_name' => 'submitted_review', ), - 'reviewers' => + 'interested' => array( 'type' => 'Pluf_DB_Field_Manytomany', 'model' => 'Pluf_User', 'blank' => true, - 'help_text' => 'Reviewers will get an email notification when the review is changed.', + 'help_text' => 'Interested users will get an email notification when the review is changed.', ), 'tags' => array( diff --git a/src/IDF/Review/Patch.php b/src/IDF/Review/Patch.php index f00845b..343cccb 100644 --- a/src/IDF/Review/Patch.php +++ b/src/IDF/Review/Patch.php @@ -24,6 +24,10 @@ /** * A patch to be reviewed. * + * A patch can be marked as being directly the commit, in that case + * the patch does not store the diff file as it can be retrieved from + * the backend. + * */ class IDF_Review_Patch extends Pluf_Model { diff --git a/src/IDF/conf/idf.php-dist b/src/IDF/conf/idf.php-dist index 416fdd8..2a8d958 100644 --- a/src/IDF/conf/idf.php-dist +++ b/src/IDF/conf/idf.php-dist @@ -161,8 +161,8 @@ $cfg['db_database'] = 'website'; # put absolute path to the db if you # are using SQLite. # # The extension of the downloads are limited. You can add extra -# extensions here. -# $cfg['idf_extra_upload_ext'] = 'ext1 ext2'; +# extensions here. It must start with a space. +# $cfg['idf_extra_upload_ext'] = ' ext1 ext2'; # # By default, the size of the downloads is limited to 2MB. # $cfg['max_upload_size'] = 2097152; // Size in bytes