natalie/indefero
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Added an exception when the scm command fails.

Browse Source 
This will help the debugging for people.
This commit is contained in:
Loic d'Anterroches 2008-11-27 09:03:21 +01:00
parent f9b6a022c8
commit 83fd312c81
2 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/IDF/Scm.php
View File

@ -55,6 +55,9 @@ class IDF_Scm
$cache = Pluf_Cache::factory(); $cache = Pluf_Cache::factory();
if (null === ($res=$cache->get($key))) { if (null === ($res=$cache->get($key))) {
$ll = exec($command, $output, $return); $ll = exec($command, $output, $return);
if ($return != 0) {
throw new IDF_Scm_Exception(sprintf('Error when running command: "%s", return code: %d', $command, $return));
}
$cache->set($key, array($ll, $return, $output)); $cache->set($key, array($ll, $return, $output));
} else { } else {
list($ll, $return, $output) = $res; list($ll, $return, $output) = $res;

26
src/IDF/Scm/Exception.php Normal file
View File

@ -0,0 +1,26 @@
<?php
/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
# ***** BEGIN LICENSE BLOCK *****
# This file is part of InDefero, an open source project management application.
# Copyright (C) 2008 Céondo Ltd and contributors.
#
# InDefero is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# InDefero is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#
# ***** END LICENSE BLOCK ***** */
class IDF_Scm_Exception extends Exception
{
}