Make the project field in the tags table nullable so it is (hopefully)
optional on setups with enabled foreign key constraints.
This commit is contained in:
parent
169fbe6216
commit
75f62663a9
@ -53,7 +53,7 @@ class IDF_Forge
|
|||||||
}
|
}
|
||||||
|
|
||||||
public function getProjectLabelsWithCounts() {
|
public function getProjectLabelsWithCounts() {
|
||||||
$sql = new Pluf_SQL('project=0');
|
$sql = new Pluf_SQL('project IS NULL');
|
||||||
$tagList = Pluf::factory('IDF_Tag')->getList(array(
|
$tagList = Pluf::factory('IDF_Tag')->getList(array(
|
||||||
'filter' => $sql->gen(),
|
'filter' => $sql->gen(),
|
||||||
'view' => 'join_projects',
|
'view' => 'join_projects',
|
||||||
@ -92,4 +92,4 @@ class IDF_Forge
|
|||||||
public function setCustomForgePageContent($content) {
|
public function setCustomForgePageContent($content) {
|
||||||
$this->conf->setVal('custom_forge_page_content', $content);
|
$this->conf->setVal('custom_forge_page_content', $content);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
46
src/IDF/Migrations/25NullableProjectInTag.php
Normal file
46
src/IDF/Migrations/25NullableProjectInTag.php
Normal file
@ -0,0 +1,46 @@
|
|||||||
|
<?php
|
||||||
|
/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
||||||
|
/*
|
||||||
|
# ***** BEGIN LICENSE BLOCK *****
|
||||||
|
# This file is part of InDefero, an open source project management application.
|
||||||
|
# Copyright (C) 2008-2011 Céondo Ltd and contributors.
|
||||||
|
#
|
||||||
|
# InDefero is free software; you can redistribute it and/or modify
|
||||||
|
# it under the terms of the GNU General Public License as published by
|
||||||
|
# the Free Software Foundation; either version 2 of the License, or
|
||||||
|
# (at your option) any later version.
|
||||||
|
#
|
||||||
|
# InDefero is distributed in the hope that it will be useful,
|
||||||
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
# GNU General Public License for more details.
|
||||||
|
#
|
||||||
|
# You should have received a copy of the GNU General Public License
|
||||||
|
# along with this program; if not, write to the Free Software
|
||||||
|
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
||||||
|
#
|
||||||
|
# ***** END LICENSE BLOCK ***** */
|
||||||
|
|
||||||
|
function IDF_Migrations_25NullableProjectInTag_up($params=null)
|
||||||
|
{
|
||||||
|
$engine = Pluf::f('db_engine');
|
||||||
|
$db = Pluf::db();
|
||||||
|
|
||||||
|
if ($engine === 'PostgreSQL') {
|
||||||
|
$db->execute('ALTER TABLE '.$db->pfx.'idf_tags ALTER COLUMN project DROP NOT NULL');
|
||||||
|
} else if ($engine === 'MySQL') {
|
||||||
|
$db->execute('ALTER TABLE '.$db->pfx.'idf_tags MODIFY project MEDIUMINT NULL');
|
||||||
|
// this is only needed for non-transactional setups where MySQL set 0 as default value
|
||||||
|
$db->execute('UPDATE '.$db->pfx.'idf_tags SET project=NULL WHERE project=0');
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
function IDF_Migrations_25NullableProjectInTag_down($params=null)
|
||||||
|
{
|
||||||
|
$db = Pluf::db();
|
||||||
|
if ($engine === 'PostgreSQL') {
|
||||||
|
$db->execute('ALTER TABLE '.$db->pfx.'idf_tags ALTER COLUMN project SET NOT NULL');
|
||||||
|
} else if ($engine === 'MySQL') {
|
||||||
|
$db->execute('ALTER TABLE '.$db->pfx.'idf_tags MODIFY project MEDIUMINT NOT NULL');
|
||||||
|
}
|
||||||
|
}
|
@ -48,7 +48,8 @@ class IDF_Tag extends Pluf_Model
|
|||||||
array(
|
array(
|
||||||
'type' => 'Pluf_DB_Field_Foreignkey',
|
'type' => 'Pluf_DB_Field_Foreignkey',
|
||||||
'model' => 'IDF_Project',
|
'model' => 'IDF_Project',
|
||||||
'blank' => false,
|
'blank' => true,
|
||||||
|
'is_null' => true,
|
||||||
'verbose' => __('project'),
|
'verbose' => __('project'),
|
||||||
),
|
),
|
||||||
'class' =>
|
'class' =>
|
||||||
@ -147,7 +148,7 @@ class IDF_Tag extends Pluf_Model
|
|||||||
$class = trim($class);
|
$class = trim($class);
|
||||||
$name = trim($name);
|
$name = trim($name);
|
||||||
$gtag = new IDF_Tag();
|
$gtag = new IDF_Tag();
|
||||||
$sql = new Pluf_SQL('class=%s AND lcname=%s AND project=0',
|
$sql = new Pluf_SQL('class=%s AND lcname=%s AND project IS NULL',
|
||||||
array($class, mb_strtolower($name)));
|
array($class, mb_strtolower($name)));
|
||||||
$tags = $gtag->getList(array('filter' => $sql->gen()));
|
$tags = $gtag->getList(array('filter' => $sql->gen()));
|
||||||
if ($tags->count() < 1) {
|
if ($tags->count() < 1) {
|
||||||
|
@ -83,7 +83,7 @@ class IDF_Template_MarkdownForge extends Pluf_Template_Tag
|
|||||||
$name = $class;
|
$name = $class;
|
||||||
$class = IDF_TAG_DEFAULT_CLASS;
|
$class = IDF_TAG_DEFAULT_CLASS;
|
||||||
}
|
}
|
||||||
$sql = new Pluf_SQL('class=%s AND lcname=%s AND project=0',
|
$sql = new Pluf_SQL('class=%s AND lcname=%s AND project IS NULL',
|
||||||
array(strtolower($class), mb_strtolower($name)));
|
array(strtolower($class), mb_strtolower($name)));
|
||||||
$tag = Pluf::factory('IDF_Tag')->getOne(array('filter' => $sql->gen()));
|
$tag = Pluf::factory('IDF_Tag')->getOne(array('filter' => $sql->gen()));
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user