natalie/indefero
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed the submission of a code review and the display.

Browse Source 
The display of a code review was crashing when a new file was added in
the diff.
The form to submit a review now proposes directly a choice of commits.
This commit is contained in:
Loic d'Anterroches
2009-02-02 17:38:48 +01:00
parent 088f426986
commit 6c83169f1c
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/IDF/Views/Review.php
View File

@@ -208,7 +208,6 @@ class IDF_Views_Review
$reviewers = array();
foreach ($diff->files as $filename => $def) {
$fileinfo = $scm->getFileInfo($filename, $patch->get_commit()->scm_id);
$sql = new Pluf_SQL('cfile=%s', array($filename));
$cts = $patch->get_filecomments_list(array('filter'=>$sql->gen(),
'order'=>'creation_dtime ASC'));
@@ -216,7 +215,7 @@ class IDF_Views_Review
$reviewers[] = $ct->get_submitter();
}
if (count($def['chunks'])) {
$orig_file = $scm->getBlob($fileinfo);
$orig_file = ($fileinfo) ? $scm->getBlob($fileinfo) : '';
$files[$filename] = array(
$diff->fileCompare($orig_file, $def, $filename),
$form->f->{md5($filename)},