diff --git a/NEWS.mdtext b/NEWS.mdtext index f0ecaf0..5f52c3c 100644 --- a/NEWS.mdtext +++ b/NEWS.mdtext @@ -31,6 +31,7 @@ or newer to properly run this version of Indefero! a new project or monotone key, in case an error popped up in the middle (issue 697) - Indefero now sends the MD5 checksum as HTTP header when downloading a file from the download area. Additionally, a unneeded redirect has been removed. (issue 716) +- Source links without a specific revision did not work due to a wrong regex (issue 730) - Better error detection and reporting in the SyncMonotone plugin ATTENTION: This needs Pluf 46b7f251 or newer! - Fix the branch links users of the Subversion frontend get when they enter a wrong revision diff --git a/src/IDF/Middleware.php b/src/IDF/Middleware.php index 013929d..5e44abe 100644 --- a/src/IDF/Middleware.php +++ b/src/IDF/Middleware.php @@ -88,6 +88,7 @@ class IDF_Middleware 'showuser' => 'IDF_Template_ShowUser', 'ashowuser' => 'IDF_Template_AssignShowUser', 'appversion' => 'IDF_Template_AppVersion', + 'upload' => 'IDF_Template_Tag_UploadUrl', )); $params['modifiers'] = array_merge($params['modifiers'], array( diff --git a/src/IDF/Template/IssueComment.php b/src/IDF/Template/IssueComment.php index da7fe19..f2b8e84 100644 --- a/src/IDF/Template/IssueComment.php +++ b/src/IDF/Template/IssueComment.php @@ -58,7 +58,7 @@ class IDF_Template_IssueComment extends Pluf_Template_Tag implode('|', $nouns); $text = IDF_Template_safePregReplace('#((?:'.$prefix.')(?:\s+r?))([0-9a-f]{1,40}((?:\s+and|\s+or|,)\s+r?[0-9a-f]{1,40})*)\b#i', array($this, 'callbackCommits'), $text); - $text = IDF_Template_safePregReplace('=(src:)([^\s@#,\(\)\\\\]+(?:(\\\\)[\s@#][^\s@#,\(\)\\\\]+){0,})+(?:\@([^\s#,]+))(?:#(\d+))?=im', + $text = IDF_Template_safePregReplace('=(src:)([^\s@#,\(\)\\\\]+(?:(\\\\)[\s@#][^\s@#,\(\)\\\\]+){0,})+(?:\@([^\s#,]+))?(?:#(\d+))?=im', array($this, 'callbackSource'), $text); } if ($wordwrap) $text = Pluf_Text::wrapHtml($text, 69, "\n"); diff --git a/src/IDF/Template/Tag/UploadUrl.php b/src/IDF/Template/Tag/UploadUrl.php new file mode 100644 index 0000000..a5461ff --- /dev/null +++ b/src/IDF/Template/Tag/UploadUrl.php @@ -0,0 +1,35 @@ + {if $submitter_data.avatar != ''} - + {else} {/if} diff --git a/src/IDF/templates/idf/review/view.html b/src/IDF/templates/idf/review/view.html index 462a275..d655083 100644 --- a/src/IDF/templates/idf/review/view.html +++ b/src/IDF/templates/idf/review/view.html @@ -109,7 +109,7 @@ to propose more contributions. {foreach $comments as $c}{ashowuser 'submitter', $c.get_submitter(), $request}{assign $submitter = $c.get_submitter()}{assign $submitter_data = $c.get_submitter_data()}
{if $user_data.avatar != ''} - + {else} {/if} |
---|