From 346b2c6cf8dc944417021ba5c6580a56fe2f698f Mon Sep 17 00:00:00 2001 From: Thomas Keller Date: Fri, 1 Apr 2011 11:15:13 +0200 Subject: [PATCH] Call validateRevision(), not isValidRevision(), fixes issue 657 --- src/IDF/Scm/Mercurial.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/IDF/Scm/Mercurial.php b/src/IDF/Scm/Mercurial.php index b981138..605a715 100644 --- a/src/IDF/Scm/Mercurial.php +++ b/src/IDF/Scm/Mercurial.php @@ -94,7 +94,7 @@ class IDF_Scm_Mercurial extends IDF_Scm escapeshellarg($this->repo), escapeshellarg($rev)); $cmd = Pluf::f('idf_exec_cmd_prefix', '').$cmd; - self::exec('IDF_Scm_Mercurial::isValidRevision', $cmd, $out, $ret); + self::exec('IDF_Scm_Mercurial::validateRevision', $cmd, $out, $ret); // FIXME: apparently a given hg revision can also be ambigious - // handle this case here sometime @@ -336,7 +336,7 @@ class IDF_Scm_Mercurial extends IDF_Scm */ public function getCommit($commit, $getdiff=false) { - if (!$this->isValidRevision($commit)) { + if ($this->validateRevision($commit) != IDF_Scm::REVISION_VALID) { return false; } $tmpl = ($getdiff)