From 2c7b3e1e1a08849d276698dd6d9ef903df90f12f Mon Sep 17 00:00:00 2001 From: Loic d'Anterroches Date: Fri, 29 Aug 2008 19:59:53 +0200 Subject: [PATCH] Cosmetic improvements. --- src/IDF/ScmFactory.php | 15 +++++---------- src/IDF/Views/Source.php | 3 ++- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/IDF/ScmFactory.php b/src/IDF/ScmFactory.php index d8ae0a1..aae081f 100644 --- a/src/IDF/ScmFactory.php +++ b/src/IDF/ScmFactory.php @@ -35,19 +35,14 @@ class IDF_ScmFactory public static function getScm($request=null) { // Get scm type from project conf ; defaults to git - $scm = $request->conf->getVal('scm', 'git'); - - // CASE: git - if ($scm === 'git') { - return new IDF_Git($request->project->getGitRepository()); - } - - // CASE: svn - if ($scm === 'svn') { + switch ($request->conf->getVal('scm', 'git')) { + case 'svn': return new IDF_Svn($request->conf->getVal('svn_repository'), $request->conf->getVal('svn_username'), $request->conf->getVal('svn_password')); - } + case 'git': + default: + return new IDF_Git($request->project->getGitRepository()); } } diff --git a/src/IDF/Views/Source.php b/src/IDF/Views/Source.php index 9fe5503..244927c 100644 --- a/src/IDF/Views/Source.php +++ b/src/IDF/Views/Source.php @@ -334,7 +334,8 @@ class IDF_Views_Source */ private function getScmType($request) { - return ucfirst($scm = $request->conf->getVal('scm', 'git')); + return mb_convert_case($request->conf->getVal('scm', 'git'), + MB_CASE_TITLE, 'UTF-8'); } }